DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process
@ 2021-10-27  3:49 Kumara Parameshwaran
  2021-10-27  8:37 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Kumara Parameshwaran @ 2021-10-27  3:49 UTC (permalink / raw)
  To: grive; +Cc: dev, Kumara Parameshwaran

Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
---
 drivers/net/failsafe/failsafe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 8216063..1adccaf 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -329,8 +329,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
 	INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s",
 			name);
 
-	if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
-	    strlen(rte_vdev_device_args(vdev)) == 0) {
+	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
 			ERROR("Failed to probe %s", name);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process
  2021-10-27  3:49 [dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process Kumara Parameshwaran
@ 2021-10-27  8:37 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-10-27  8:37 UTC (permalink / raw)
  To: Kumara Parameshwaran, grive; +Cc: dev

On 10/27/2021 4:49 AM, Kumara Parameshwaran wrote:
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>

Hi Kumara,

Can you please provide more detail in the commit log?

> ---
>   drivers/net/failsafe/failsafe.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
> index 8216063..1adccaf 100644
> --- a/drivers/net/failsafe/failsafe.c
> +++ b/drivers/net/failsafe/failsafe.c
> @@ -329,8 +329,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
>   	INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s",
>   			name);
>   
> -	if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
> -	    strlen(rte_vdev_device_args(vdev)) == 0) {
> +	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
>   		eth_dev = rte_eth_dev_attach_secondary(name);
>   		if (!eth_dev) {
>   			ERROR("Failed to probe %s", name);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-27  8:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27  3:49 [dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process Kumara Parameshwaran
2021-10-27  8:37 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).