From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] service: add component useful work attribute
Date: Mon, 14 Sep 2020 14:37:54 +0000 [thread overview]
Message-ID: <BYAPR11MB3143911451AD6A3DF80B9473D7230@BYAPR11MB3143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8w0FcUUXVjUTt3prjJ8=OpDQArcB1k-kn6DENfA3_FZpw@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, September 14, 2020 9:37 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH 1/2] service: add component useful work attribute
>
> On Mon, Sep 7, 2020 at 6:20 PM Harry van Haaren
> <harry.van.haaren@intel.com> wrote:
> > diff --git a/lib/librte_eal/include/rte_service_component.h
> b/lib/librte_eal/include/rte_service_component.h
> > index 9e66ee7e29..2caa7981b5 100644
> > --- a/lib/librte_eal/include/rte_service_component.h
> > +++ b/lib/librte_eal/include/rte_service_component.h
> > @@ -87,6 +87,18 @@ int32_t rte_service_component_register(const struct
> rte_service_spec *spec,
> > */
> > int32_t rte_service_component_unregister(uint32_t id);
> >
> > +/**
> > + * Set an attribute for this service.
> > + *
> > + * Note this API is to be called by the service implementation, to make the
> > + * statistic available via the usual attr_get() service APIs.
> > + *
> > + * @retval 0 Success
> > + * @retval -EINVAL Invalid service id or attribute provided
> > + */
> > +int32_t rte_service_component_attr_set(uint32_t id, uint32_t attr,
> > + uint64_t value);
> > +
>
> The experimental tag is missing for this declaration.
>
> https://travis-ci.com/ovsrobot/dpdk/builds/183185060
> http://mails.dpdk.org/archives/test-report/2020-September/150152.html
Fixed, and v2 sent; thanks; http://patches.dpdk.org/project/dpdk/list/?series=12201
<snip>
next prev parent reply other threads:[~2020-09-14 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:21 Harry van Haaren
2020-09-07 16:21 ` [dpdk-dev] [PATCH 2/2] event/sw: add useful work done attribute Harry van Haaren
2020-09-14 8:37 ` [dpdk-dev] [PATCH 1/2] service: add component useful work attribute David Marchand
2020-09-14 14:37 ` Van Haaren, Harry [this message]
2020-09-14 14:37 ` [dpdk-dev] [PATCH v2 " Harry van Haaren
2020-09-14 14:37 ` [dpdk-dev] [PATCH v2 2/2] event/sw: add useful work done attribute Harry van Haaren
2020-09-21 14:49 ` [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute David Marchand
2020-09-21 15:17 ` Van Haaren, Harry
2020-09-21 23:47 ` Honnappa Nagarahalli
2020-09-23 11:39 ` Mattias Rönnblom
2020-09-23 14:16 ` Van Haaren, Harry
2020-10-05 16:45 ` Van Haaren, Harry
2020-10-16 12:20 ` David Marchand
2020-10-16 12:57 ` Van Haaren, Harry
2021-01-13 14:42 ` David Marchand
2021-01-14 12:15 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3143911451AD6A3DF80B9473D7230@BYAPR11MB3143.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).