Re: [dpdk-dev] [PATCH 1/2] service: add component useful work attribute

[David Marchand <david.marchand@redhat.com>]

On Mon, Sep 7, 2020 at 6:20 PM Harry van Haaren
<harry.van.haaren@intel.com> wrote:
> diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
> index 9e66ee7e29..2caa7981b5 100644
> --- a/lib/librte_eal/include/rte_service_component.h
> +++ b/lib/librte_eal/include/rte_service_component.h
> @@ -87,6 +87,18 @@ int32_t rte_service_component_register(const struct rte_service_spec *spec,
>   */
>  int32_t rte_service_component_unregister(uint32_t id);
>
> +/**
> + * Set an attribute for this service.
> + *
> + * Note this API is to be called by the service implementation, to make the
> + * statistic available via the usual attr_get() service APIs.
> + *
> + * @retval 0 Success
> + * @retval -EINVAL Invalid service id or attribute provided
> + */
> +int32_t rte_service_component_attr_set(uint32_t id, uint32_t attr,
> +               uint64_t value);
> +

The experimental tag is missing for this declaration.

https://travis-ci.com/ovsrobot/dpdk/builds/183185060
http://mails.dpdk.org/archives/test-report/2020-September/150152.html

>  /**
>   * Private function to allow EAL to initialized default mappings.
>   *
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 0b18e2ef85..bb5e19ae9e 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -397,6 +397,9 @@ EXPERIMENTAL {
>         rte_mp_disable;
>         rte_thread_register;
>         rte_thread_unregister;
> +
> +       # added in 20.11
> +       rte_service_component_attr_set;
>  };
>
>  INTERNAL {
> --
> 2.17.1
>


-- 
David Marchand