From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> To: David Marchand <david.marchand@redhat.com>, Harry van Haaren <harry.van.haaren@intel.com> Cc: dev <dev@dpdk.org>, Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, nd <nd@arm.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute Date: Mon, 21 Sep 2020 23:47:12 +0000 Message-ID: <DBAPR08MB58142033875BC0093AFCDB37983A0@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw) In-Reply-To: <CAJFAV8zNuCuOdzAiCGP2sFaes+1tZmaa2OA+b=fcLjtZ3KOH-g@mail.gmail.com> <snip> > > Hello Harry, > > On Mon, Sep 14, 2020 at 4:36 PM Harry van Haaren > <harry.van.haaren@intel.com> wrote: > > > > This commit adds a new attribute which allows the service to indicate > > if the previous iteration of work was "useful". Useful work here > > implies forward progress was made. > > > > Exposing this information via an attribute to the application allows > > tracking of CPU cycles as being useful or not-useful, and a CPU load > > estimate can be deduced from that information. > > > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > > This is missing a unit test. > Getting others' opinion on this addition would be good too. Yes, adding unit tests would be good. > > Thanks. > > > -- > David Marchand
next prev parent reply other threads:[~2020-09-21 23:47 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-07 16:21 [dpdk-dev] [PATCH " Harry van Haaren 2020-09-07 16:21 ` [dpdk-dev] [PATCH 2/2] event/sw: add useful work done attribute Harry van Haaren 2020-09-14 8:37 ` [dpdk-dev] [PATCH 1/2] service: add component useful work attribute David Marchand 2020-09-14 14:37 ` Van Haaren, Harry 2020-09-14 14:37 ` [dpdk-dev] [PATCH v2 " Harry van Haaren 2020-09-14 14:37 ` [dpdk-dev] [PATCH v2 2/2] event/sw: add useful work done attribute Harry van Haaren 2020-09-21 14:49 ` [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute David Marchand 2020-09-21 15:17 ` Van Haaren, Harry 2020-09-21 23:47 ` Honnappa Nagarahalli [this message] 2020-09-23 11:39 ` Mattias Rönnblom 2020-09-23 14:16 ` Van Haaren, Harry 2020-10-05 16:45 ` Van Haaren, Harry 2020-10-16 12:20 ` David Marchand 2020-10-16 12:57 ` Van Haaren, Harry 2021-01-13 14:42 ` David Marchand 2021-01-14 12:15 ` Van Haaren, Harry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DBAPR08MB58142033875BC0093AFCDB37983A0@DBAPR08MB5814.eurprd08.prod.outlook.com \ --to=honnappa.nagarahalli@arm.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=harry.van.haaren@intel.com \ --cc=l.wojciechow@partner.samsung.com \ --cc=nd@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git