From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, Kevin Laatz <kevin.laatz@intel.com>,
Luca Boccassi <bluca@debian.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking
Date: Wed, 28 Aug 2019 16:48:32 +0200 [thread overview]
Message-ID: <CAATJJ0+auuRmGzddrOejkv09wQ0t14FY7QMQexkCts3JFv08Mg@mail.gmail.com> (raw)
In-Reply-To: <f7td0gppfb3.fsf@dhcp-25.97.bos.redhat.com>
On Wed, Aug 28, 2019 at 3:53 PM Aaron Conole <aconole@redhat.com> wrote:
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com> writes:
>
> > A while ago telemetry was added in 57ae0ec6 and it also added as-needed
> > to config/meson.build. This seems no more needed these days as due to other
> > build changes the ordering in buildlogs is:
> > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
> > Which means telemetry no more benefits from --no-as-needed anyway.
> >
> > Overlinking problems get triggered by the meson generated pkgconfig which
> > will have:
> > [...] -Wl,--no-as-needed <somelibsusedbydpdk>
> > This will overlink <somelibs> and in addition anything that follows
> > as it also doesn't wrap back to --as-needed. So if a projects includes
> > dpdk libs + <other> it will also consider <other> with --no-as-needed.
> >
> > Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
> >
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > ---
>
> Hi Christian,
>
> I agree this is something to be fixed. It will need additional work,
> though:
>
> https://travis-ci.com/ovsrobot/dpdk/builds/124909245
>
Thanks for the Link Aaron, yet I'm puzzled what to do there atm.
The kind of error I found in the failing logs were misleading at first:
- linker can't find -lvirt / -lpqos / ...
well the test env needs to install them, maybe it was added as
dependency by accident before?
I'd understand (due to the change) if it would complain about missing symbols
(no more added due to as-needed, but then for some reason needed)
But this is vice versa, it just doesn't find the libs in the build env
- error: unrecognized command line option '-Wformat-truncation'
I don't see how I'd cause this ...
=> Maybe this is just an artifact that is even part of the normal/good tests?
Comparing former logs - last good test was
https://travis-ci.com/ovsrobot/dpdk/builds/124875383
This first seemed more helpful.
DPDK:fast-tests / eal_flags_w_opt_autotest FAIL
DPDK:fast-tests / func_reentrancy_autotest FAIL
DPDK:fast-tests / mbuf_autotest FAIL
DPDK:fast-tests / mempool_autotest FAIL
DPDK:fast-tests / ring_pmd_autotest FAIL
DPDK:fast-tests / sched_autotest FAIL
DPDK:fast-tests / table_autotest FAIL
[...]
Overall about 14/60 of the tests failed with no recognizable pattern
why just those and not the others.
I only see "Full log written ... on_error", so I can't directly
compare how a good run would look in the configure/build stage.
Looking just at the bad case there are plenty of messages like
- "no available hugepages"
- "cannot reserve memory", ..
But all those indicate more a flaky test(-env) than an error in the
commit, there must be more to it.
@Aaron is there a good way to get the rest of the log for a good case
to compare?
Maybe I'm yet to blind for all the potential side effects of the change?
next prev parent reply other threads:[~2019-08-28 14:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:27 Christian Ehrhardt
2019-08-28 13:49 ` Luca Boccassi
2019-08-28 13:53 ` Aaron Conole
2019-08-28 14:48 ` Christian Ehrhardt [this message]
2019-08-28 15:14 ` Aaron Conole
2019-08-28 15:23 ` Aaron Conole
2019-08-29 10:18 ` Christian Ehrhardt
2019-08-29 15:25 ` Christian Ehrhardt
2019-08-29 15:30 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2019-08-29 15:34 ` Bruce Richardson
2019-08-29 16:02 ` Luca Boccassi
2019-09-02 7:09 ` Christian Ehrhardt
2019-09-04 9:13 ` Christian Ehrhardt
2019-09-04 9:18 ` Bruce Richardson
2019-09-10 6:48 ` Christian Ehrhardt
2019-09-12 13:43 ` Christian Ehrhardt
2019-10-12 13:02 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0+auuRmGzddrOejkv09wQ0t14FY7QMQexkCts3JFv08Mg@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=aconole@redhat.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).