From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Conor Walsh <conor.walsh@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Luca Boccassi <bluca@debian.org>,
Randy Schacher <stuart.schacher@broadcom.com>,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
Michael Wildt <michael.wildt@broadcom.com>,
dpdk-dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
linglix.chen@intel.com, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values
Date: Thu, 19 Nov 2020 15:12:29 -0800
Message-ID: <CACZ4nhtq+=Ah4HM5aZe9z4o8_GJNVsHMJ3Tihj2E1T=tG_6JHg@mail.gmail.com> (raw)
In-Reply-To: <20201119101700.3869583-3-conor.walsh@intel.com>
On Thu, Nov 19, 2020 at 2:17 AM Conor Walsh <conor.walsh@intel.com> wrote:
>
> &device requires the %u format specifer not the %d specifier, as
> &device is unsigned.
>
> Fixes: a46bbb57605b ("net/bnxt: update multi device design")
> Cc: michael.wildt@broadcom.com
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/tf_core/tf_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/tf_core/tf_core.c b/drivers/net/bnxt/tf_core/tf_core.c
> index 0f49a00256..24d49096a7 100644
> --- a/drivers/net/bnxt/tf_core/tf_core.c
> +++ b/drivers/net/bnxt/tf_core/tf_core.c
> @@ -44,7 +44,7 @@ tf_open_session(struct tf *tfp,
>
> /* Verify control channel and build the beginning of session_id */
> rc = sscanf(parms->ctrl_chan_name,
> - "%x:%x:%x.%d",
> + "%x:%x:%x.%u",
> &domain,
> &bus,
> &slot,
> @@ -57,7 +57,7 @@ tf_open_session(struct tf *tfp,
>
> /* Check parsing of bus/slot/device */
> rc = sscanf(parms->ctrl_chan_name,
> - "%x:%x.%d",
> + "%x:%x.%u",
> &bus,
> &slot,
> &device);
> @@ -102,7 +102,7 @@ tf_attach_session(struct tf *tfp,
>
> /* Verify control channel */
> rc = sscanf(parms->ctrl_chan_name,
> - "%x:%x:%x.%d",
> + "%x:%x:%x.%u",
> &domain,
> &bus,
> &slot,
> @@ -115,7 +115,7 @@ tf_attach_session(struct tf *tfp,
>
> /* Verify 'attach' channel */
> rc = sscanf(parms->attach_chan_name,
> - "%x:%x:%x.%d",
> + "%x:%x:%x.%u",
> &domain,
> &bus,
> &slot,
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-11-19 23:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 11:35 [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error Conor Walsh
2020-11-12 18:47 ` Thomas Monjalon
2020-11-13 13:54 ` Walsh, Conor
2020-11-13 3:39 ` Chen, LingliX
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Conor Walsh
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-18 18:37 ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Luca Boccassi
2020-11-19 10:24 ` Walsh, Conor
2020-11-19 10:16 ` [dpdk-dev] [PATCH v3 " Conor Walsh
2020-11-19 10:16 ` [dpdk-dev] [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-20 7:23 ` Chen, LingliX
2020-11-19 10:17 ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-19 23:12 ` Ajit Khaparde [this message]
2020-11-22 20:07 ` [dpdk-dev] [dpdk-stable] [PATCH v3 0/2] build: add Wformat to fix gcc compile warnings and format fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtq+=Ah4HM5aZe9z4o8_GJNVsHMJ3Tihj2E1T=tG_6JHg@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=linglix.chen@intel.com \
--cc=michael.wildt@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=stuart.schacher@broadcom.com \
--cc=thomas@monjalon.net \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git