From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build
Date: Wed, 13 Oct 2021 14:35:15 -0700 [thread overview]
Message-ID: <CACZ4nhuN0FORvF1GGqwggRSHjht7r-HWYaqsKCsqG7asDgi44A@mail.gmail.com> (raw)
In-Reply-To: <bf4d99e1-28ee-6f78-2425-ab6ca4d58064@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/13/2021 6:34 PM, Ajit Khaparde wrote:
> > On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error,
> >> removing it.
> >>
> >> Also with meson build system compile time debug macros should be
> >> documented in driver documentation, since there is not other way to
> > s/not/no
> >
> >> figure out their existence.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > With thanks and above nit, :-)
> >
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> >
>
> Other option is to fix the build error when macro is set, would you like
> to go with that option?
No. There is more that we would like to add if we want to add debug capability.
Currently what you are trying to remove is a bit half baked which
should not have sneaked in.
So removing it for now is perfectly fine.
>
> And can you please send a separate patch to document the remaining
> compile time macros in the driver guide?
Sure. I will go through the code and take care of that.
next prev parent reply other threads:[~2021-10-13 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 16:31 Ferruh Yigit
2021-10-13 17:34 ` Ajit Khaparde
2021-10-13 19:23 ` Ferruh Yigit
2021-10-13 21:35 ` Ajit Khaparde [this message]
2021-10-13 22:02 ` Ferruh Yigit
2021-10-13 22:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhuN0FORvF1GGqwggRSHjht7r-HWYaqsKCsqG7asDgi44A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).