From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, Lance Richardson <lance.richardson@broadcom.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code
Date: Tue, 1 Oct 2019 18:28:36 -0700 [thread overview]
Message-ID: <CACZ4nhv6dOc4__S6QxD49XoxOGF4zZu3KpQSB6L7NV=pkFJzXg@mail.gmail.com> (raw)
In-Reply-To: <20191001130405.7076-2-ktraynor@redhat.com>
On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor <ktraynor@redhat.com> wrote:
> If rc contains a non-zero return code from bnxt_hwrm_send_message(),
> HWRM_CHECK_RESULT_SILENT() will return.
>
> Just after that code, there is an 'if (!rc) {...} else {...}'.
> Coverity is complaining that this if else statement is dead code as
> rc will always be 0 if that code is reached.
>
> 4309 rc = bnxt_hwrm_send_message(bp, &req, sizeof(req),
> BNXT_USE_CHIMP_MB);
> cond_const: Condition rc, taking false branch.
> Now the value of rc is equal to 0.
> 4310 HWRM_CHECK_RESULT_SILENT();
> 4311
> const: At condition rc, the value of rc must be equal to 0.
> dead_error_condition: The condition !rc must be true.
> 4312 if (!rc) {
>
> [snip]
>
> 4373 } else {
> CID 343450 (#1 of 1): Logically dead code
> (DEADCODE)dead_error_line: Execution cannot
> reach this statement: rc = 0;.
> 4374 rc = 0;
> 4375 }
>
> Coverity issue: 343450
> Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
> Cc: lance.richardson@broadcom.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 118 +++++++++++++++++------------------
> 1 file changed, 56 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 9883fb506..5378e3e9c 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -4298,5 +4298,7 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt
> *bp)
> struct hwrm_func_backing_store_qcaps_output *resp =
> bp->hwrm_cmd_resp_addr;
> - int rc;
> + struct bnxt_ctx_pg_info *ctx_pg;
> + struct bnxt_ctx_mem_info *ctx;
> + int rc, total_alloc_len, i;
>
> if (!BNXT_CHIP_THOR(bp) ||
> @@ -4310,68 +4312,60 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt
> *bp)
> HWRM_CHECK_RESULT_SILENT();
>
> - if (!rc) {
> - struct bnxt_ctx_pg_info *ctx_pg;
> - struct bnxt_ctx_mem_info *ctx;
> - int total_alloc_len;
> - int i;
> + total_alloc_len = sizeof(*ctx);
> + ctx = rte_malloc("bnxt_ctx_mem", total_alloc_len,
> + RTE_CACHE_LINE_SIZE);
> + if (!ctx) {
> + rc = -ENOMEM;
> + goto ctx_err;
> + }
> + memset(ctx, 0, total_alloc_len);
>
> - total_alloc_len = sizeof(*ctx);
> - ctx = rte_malloc("bnxt_ctx_mem", total_alloc_len,
> - RTE_CACHE_LINE_SIZE);
> - if (!ctx) {
> - rc = -ENOMEM;
> - goto ctx_err;
> - }
> - memset(ctx, 0, total_alloc_len);
> + ctx_pg = rte_malloc("bnxt_ctx_pg_mem",
> + sizeof(*ctx_pg) * BNXT_MAX_Q,
> + RTE_CACHE_LINE_SIZE);
> + if (!ctx_pg) {
> + rc = -ENOMEM;
> + goto ctx_err;
> + }
> + for (i = 0; i < BNXT_MAX_Q; i++, ctx_pg++)
> + ctx->tqm_mem[i] = ctx_pg;
>
> - ctx_pg = rte_malloc("bnxt_ctx_pg_mem",
> - sizeof(*ctx_pg) * BNXT_MAX_Q,
> - RTE_CACHE_LINE_SIZE);
> - if (!ctx_pg) {
> - rc = -ENOMEM;
> - goto ctx_err;
> - }
> - for (i = 0; i < BNXT_MAX_Q; i++, ctx_pg++)
> - ctx->tqm_mem[i] = ctx_pg;
> + bp->ctx = ctx;
> + ctx->qp_max_entries = rte_le_to_cpu_32(resp->qp_max_entries);
> + ctx->qp_min_qp1_entries =
> + rte_le_to_cpu_16(resp->qp_min_qp1_entries);
> + ctx->qp_max_l2_entries =
> + rte_le_to_cpu_16(resp->qp_max_l2_entries);
> + ctx->qp_entry_size = rte_le_to_cpu_16(resp->qp_entry_size);
> + ctx->srq_max_l2_entries =
> + rte_le_to_cpu_16(resp->srq_max_l2_entries);
> + ctx->srq_max_entries = rte_le_to_cpu_32(resp->srq_max_entries);
> + ctx->srq_entry_size = rte_le_to_cpu_16(resp->srq_entry_size);
> + ctx->cq_max_l2_entries =
> + rte_le_to_cpu_16(resp->cq_max_l2_entries);
> + ctx->cq_max_entries = rte_le_to_cpu_32(resp->cq_max_entries);
> + ctx->cq_entry_size = rte_le_to_cpu_16(resp->cq_entry_size);
> + ctx->vnic_max_vnic_entries =
> + rte_le_to_cpu_16(resp->vnic_max_vnic_entries);
> + ctx->vnic_max_ring_table_entries =
> + rte_le_to_cpu_16(resp->vnic_max_ring_table_entries);
> + ctx->vnic_entry_size = rte_le_to_cpu_16(resp->vnic_entry_size);
> + ctx->stat_max_entries =
> + rte_le_to_cpu_32(resp->stat_max_entries);
> + ctx->stat_entry_size = rte_le_to_cpu_16(resp->stat_entry_size);
> + ctx->tqm_entry_size = rte_le_to_cpu_16(resp->tqm_entry_size);
> + ctx->tqm_min_entries_per_ring =
> + rte_le_to_cpu_32(resp->tqm_min_entries_per_ring);
> + ctx->tqm_max_entries_per_ring =
> + rte_le_to_cpu_32(resp->tqm_max_entries_per_ring);
> + ctx->tqm_entries_multiple = resp->tqm_entries_multiple;
> + if (!ctx->tqm_entries_multiple)
> + ctx->tqm_entries_multiple = 1;
> + ctx->mrav_max_entries =
> + rte_le_to_cpu_32(resp->mrav_max_entries);
> + ctx->mrav_entry_size = rte_le_to_cpu_16(resp->mrav_entry_size);
> + ctx->tim_entry_size = rte_le_to_cpu_16(resp->tim_entry_size);
> + ctx->tim_max_entries = rte_le_to_cpu_32(resp->tim_max_entries);
>
> - bp->ctx = ctx;
> - ctx->qp_max_entries =
> rte_le_to_cpu_32(resp->qp_max_entries);
> - ctx->qp_min_qp1_entries =
> - rte_le_to_cpu_16(resp->qp_min_qp1_entries);
> - ctx->qp_max_l2_entries =
> - rte_le_to_cpu_16(resp->qp_max_l2_entries);
> - ctx->qp_entry_size = rte_le_to_cpu_16(resp->qp_entry_size);
> - ctx->srq_max_l2_entries =
> - rte_le_to_cpu_16(resp->srq_max_l2_entries);
> - ctx->srq_max_entries =
> rte_le_to_cpu_32(resp->srq_max_entries);
> - ctx->srq_entry_size =
> rte_le_to_cpu_16(resp->srq_entry_size);
> - ctx->cq_max_l2_entries =
> - rte_le_to_cpu_16(resp->cq_max_l2_entries);
> - ctx->cq_max_entries =
> rte_le_to_cpu_32(resp->cq_max_entries);
> - ctx->cq_entry_size = rte_le_to_cpu_16(resp->cq_entry_size);
> - ctx->vnic_max_vnic_entries =
> - rte_le_to_cpu_16(resp->vnic_max_vnic_entries);
> - ctx->vnic_max_ring_table_entries =
> -
> rte_le_to_cpu_16(resp->vnic_max_ring_table_entries);
> - ctx->vnic_entry_size =
> rte_le_to_cpu_16(resp->vnic_entry_size);
> - ctx->stat_max_entries =
> - rte_le_to_cpu_32(resp->stat_max_entries);
> - ctx->stat_entry_size =
> rte_le_to_cpu_16(resp->stat_entry_size);
> - ctx->tqm_entry_size =
> rte_le_to_cpu_16(resp->tqm_entry_size);
> - ctx->tqm_min_entries_per_ring =
> - rte_le_to_cpu_32(resp->tqm_min_entries_per_ring);
> - ctx->tqm_max_entries_per_ring =
> - rte_le_to_cpu_32(resp->tqm_max_entries_per_ring);
> - ctx->tqm_entries_multiple = resp->tqm_entries_multiple;
> - if (!ctx->tqm_entries_multiple)
> - ctx->tqm_entries_multiple = 1;
> - ctx->mrav_max_entries =
> - rte_le_to_cpu_32(resp->mrav_max_entries);
> - ctx->mrav_entry_size =
> rte_le_to_cpu_16(resp->mrav_entry_size);
> - ctx->tim_entry_size =
> rte_le_to_cpu_16(resp->tim_entry_size);
> - ctx->tim_max_entries =
> rte_le_to_cpu_32(resp->tim_max_entries);
> - } else {
> - rc = 0;
> - }
> ctx_err:
> HWRM_UNLOCK();
> --
> 2.21.0
>
>
next prev parent reply other threads:[~2019-10-02 1:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:53 [dpdk-dev] [PATCH 0/9] Coverity fixes and other cleanups Kevin Traynor
2019-10-01 12:53 ` [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks Kevin Traynor
2019-10-04 10:57 ` Ferriter, Cian
2019-10-30 7:52 ` David Marchand
2019-11-05 16:40 ` Kevin Traynor
2019-11-05 17:10 ` Ferriter, Cian
2019-11-06 19:03 ` Kevin Traynor
2019-10-01 13:03 ` [dpdk-dev] [PATCH 2/9] crypto/octeontx: fix possible NULL deference Kevin Traynor
2019-10-01 13:03 ` [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code Kevin Traynor
2019-10-02 1:28 ` Ajit Khaparde [this message]
2019-10-30 7:43 ` David Marchand
2019-10-30 16:27 ` Ajit Khaparde
2019-11-05 15:39 ` Kevin Traynor
2019-10-01 13:04 ` [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic Kevin Traynor
2019-10-30 7:59 ` David Marchand
2019-11-05 15:41 ` Kevin Traynor
2019-11-08 14:45 ` Xu, Rosen
2019-11-08 14:47 ` Kevin Traynor
2019-11-08 14:35 ` Xu, Rosen
2019-11-08 14:52 ` Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 5/9] net/ipn3ke: remove useless if statement Kevin Traynor
2019-10-30 8:01 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-08 14:35 ` Xu, Rosen
2019-11-08 14:52 ` [dpdk-dev] " Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 6/9] net/ipn3ke: remove commented out code Kevin Traynor
2019-10-30 8:04 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-08 14:40 ` Xu, Rosen
2019-11-08 14:51 ` [dpdk-dev] " Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 7/9] compress/octeontx: " Kevin Traynor
2019-10-30 8:06 ` David Marchand
2019-10-01 13:04 ` [dpdk-dev] [PATCH 8/9] event/opdl: " Kevin Traynor
2019-10-03 10:50 ` Liang, Ma
2019-10-01 13:04 ` [dpdk-dev] [PATCH 9/9] net/bnxt: " Kevin Traynor
2019-10-01 15:42 ` Ajit Khaparde
2019-10-30 7:56 ` [dpdk-dev] [dpdk-stable] [PATCH 2/9] crypto/octeontx: fix possible NULL deference David Marchand
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 1/8] net/pcap: fix argument checks Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 2/8] common/cpt: fix possible NULL deference Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 3/8] net/ipn3ke: fix incorrect commit check logic Kevin Traynor
2019-11-08 14:50 ` Xu, Rosen
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 4/8] net/ipn3ke: remove useless if statement Kevin Traynor
2019-11-08 14:49 ` Xu, Rosen
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 5/8] net/ipn3ke: remove commented out code Kevin Traynor
2019-11-08 14:50 ` Xu, Rosen
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 6/8] compress/octeontx: " Kevin Traynor
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 7/8] event/opdl: " Kevin Traynor
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 8/8] net/bnxt: " Kevin Traynor
2019-11-08 14:07 ` [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups David Marchand
2019-11-08 14:41 ` Xu, Rosen
2019-11-08 15:15 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhv6dOc4__S6QxD49XoxOGF4zZu3KpQSB6L7NV=pkFJzXg@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=lance.richardson@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).