* [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation
@ 2019-10-28 16:53 Stephen Hemminger
2019-10-31 18:23 ` Ajit Khaparde
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2019-10-28 16:53 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
Creating a flow is a normal event; should not be logged at error level.
Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index cad232aba7da..8f386cdf1331 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
}
STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
- PMD_DRV_LOG(ERR, "Successfully created flow.\n");
+ PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
bnxt_release_flow_lock(bp);
return flow;
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation
2019-10-28 16:53 [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation Stephen Hemminger
@ 2019-10-31 18:23 ` Ajit Khaparde
2019-10-31 18:35 ` Ajit Khaparde
0 siblings, 1 reply; 3+ messages in thread
From: Ajit Khaparde @ 2019-10-31 18:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Somnath Kotur, dpdk-dev
On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> Creating a flow is a normal event; should not be logged at error level.
>
> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index cad232aba7da..8f386cdf1331 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
> }
>
> STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
> - PMD_DRV_LOG(ERR, "Successfully created flow.\n");
> + PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
> STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
> bnxt_release_flow_lock(bp);
> return flow;
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation
2019-10-31 18:23 ` Ajit Khaparde
@ 2019-10-31 18:35 ` Ajit Khaparde
0 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2019-10-31 18:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Somnath Kotur, dpdk-dev
On Thu, Oct 31, 2019 at 11:23 AM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
>
>
> On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
>> Creating a flow is a normal event; should not be logged at error level.
>>
>> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
>
>
>> ---
>> drivers/net/bnxt/bnxt_flow.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
>> index cad232aba7da..8f386cdf1331 100644
>> --- a/drivers/net/bnxt/bnxt_flow.c
>> +++ b/drivers/net/bnxt/bnxt_flow.c
>> @@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
>> }
>>
>> STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
>> - PMD_DRV_LOG(ERR, "Successfully created flow.\n");
>> + PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
>> STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
>> bnxt_release_flow_lock(bp);
>> return flow;
>> --
>> 2.20.1
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-31 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 16:53 [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation Stephen Hemminger
2019-10-31 18:23 ` Ajit Khaparde
2019-10-31 18:35 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).