DPDK patches and discussions
 help / color / mirror / Atom feed
From: Li Feng <fengli@smartx.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Tiwei Bie <tiwei.bie@intel.com>,
	Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] vhost: add config change slave msg support
Date: Wed, 11 Dec 2019 10:58:28 +0800	[thread overview]
Message-ID: <CAHckoCwCn61X0k-XtsME9pJF2ZPRDOKbJn+jsxV-rUnCKQQxeA@mail.gmail.com> (raw)
In-Reply-To: <20191205053833.29068-1-fengli@smartx.com>

ping, any update about this?

Thanks,

Feng Li

Li Feng <fengli@smartx.com> 于2019年12月5日周四 下午1:38写道:
>
> This msg is used to notify qemu that should get the config of backend.
>
> For example, vhost-user-blk uses this msg to notify guest os the
> compacity of backend has changed.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> v3:
> * Move the declare to rte_vhost.h
> * Add the symbol in rte_vhost_version.map
>
> v2:
> * Fix a little log typo.
>
>  lib/librte_vhost/rte_vhost.h           | 12 ++++++++++++
>  lib/librte_vhost/rte_vhost_version.map |  1 +
>  lib/librte_vhost/vhost_user.c          | 31 +++++++++++++++++++++++++++++++
>  lib/librte_vhost/vhost_user.h          |  1 +
>  4 files changed, 45 insertions(+)
>
> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
> index 7b5dc87c2..fc28da264 100644
> --- a/lib/librte_vhost/rte_vhost.h
> +++ b/lib/librte_vhost/rte_vhost.h
> @@ -977,6 +977,18 @@ __rte_experimental
>  int
>  rte_vhost_get_vdpa_device_id(int vid);
>
> +/**
> + * Notify the guest that should get config from backend.
> + *
> + * @param vid
> + *  vhost device ID
> + * @return
> + *  0 on success, < 0 on failure
> + */
> +__rte_experimental
> +int
> +rte_vhost_user_slave_config_change(int vid);
> +
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index c512377fe..acf013d6d 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -65,4 +65,5 @@ EXPERIMENTAL {
>         rte_vhost_clr_inflight_desc_packed;
>         rte_vhost_get_vhost_ring_inflight;
>         rte_vhost_get_vring_base_from_inflight;
> +       rte_vhost_user_slave_config_change;
>  };
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 0cfb8b792..10f2e47d5 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -2840,6 +2840,37 @@ vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)
>         return 0;
>  }
>
> +static int
> +vhost_user_slave_config_change(struct virtio_net *dev)
> +{
> +       int ret;
> +       struct VhostUserMsg msg = {
> +               .request.slave = VHOST_USER_SLAVE_CONFIG_CHANGE_MSG,
> +               .flags = VHOST_USER_VERSION,
> +               .size = 0,
> +       };
> +
> +       ret = send_vhost_message(dev->slave_req_fd, &msg);
> +       if (ret < 0) {
> +               RTE_LOG(ERR, VHOST_CONFIG,
> +                               "Failed to send config change (%d)\n",
> +                               ret);
> +               return ret;
> +       }
> +
> +       return 0;
> +}
> +
> +int
> +rte_vhost_user_slave_config_change(int vid)
> +{
> +       struct virtio_net *dev;
> +       dev = get_device(vid);
> +       if (!dev)
> +               return -ENODEV;
> +       return vhost_user_slave_config_change(dev);
> +}
> +
>  static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,
>                                                     int index, int fd,
>                                                     uint64_t offset,
> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> index 6563f7315..86c364a93 100644
> --- a/lib/librte_vhost/vhost_user.h
> +++ b/lib/librte_vhost/vhost_user.h
> @@ -62,6 +62,7 @@ typedef enum VhostUserRequest {
>  typedef enum VhostUserSlaveRequest {
>         VHOST_USER_SLAVE_NONE = 0,
>         VHOST_USER_SLAVE_IOTLB_MSG = 1,
> +       VHOST_USER_SLAVE_CONFIG_CHANGE_MSG = 2,
>         VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG = 3,
>         VHOST_USER_SLAVE_MAX
>  } VhostUserSlaveRequest;
> --
> 2.11.0
>

-- 
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.



  reply	other threads:[~2019-12-11  2:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 14:57 [dpdk-dev] [PATCH] " Li Feng
2019-12-04  5:13 ` [dpdk-dev] [PATCH v2] " Li Feng
2019-12-04  9:30   ` Tiwei Bie
2019-12-04  9:43     ` Li Feng
2019-12-05  2:07       ` Tiwei Bie
2019-12-05  4:01         ` Li Feng
2019-12-05  4:57           ` Tiwei Bie
2019-12-05  5:38 ` [dpdk-dev] [PATCH v3] " Li Feng
2019-12-11  2:58   ` Li Feng [this message]
2019-12-16  5:06   ` Tiwei Bie
2019-12-18  6:34     ` Li Feng
2019-12-19  8:54 ` [dpdk-dev] [PATCH v4] " Li Feng
2019-12-20  8:04   ` Tiwei Bie
2019-12-20  8:22 ` [dpdk-dev] [PATCH v5] " Li Feng
2020-01-14 14:57   ` Maxime Coquelin
2020-01-15 11:18   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHckoCwCn61X0k-XtsME9pJF2ZPRDOKbJn+jsxV-rUnCKQQxeA@mail.gmail.com \
    --to=fengli@smartx.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).