Re: [dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2

[David Marchand <david.marchand@redhat.com>]

On Thu, Oct 31, 2019 at 2:04 PM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> This patch disables the 1588 timer support by default on DPAA2
> platform due to the performance impact.
> By default it is disabled in the common/base, so remove the entry

config/common_base

> from DPAA2.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>
> Changes in v2:
>  - Change only the 1588 timestamp option in DPAA2 and do not touch
>    the CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA option.
>
>  config/defconfig_arm64-dpaa2-linuxapp-gcc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> index 5c7eddd5e..b2ccbec0c 100644
> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> @@ -15,8 +15,8 @@ CONFIG_RTE_CACHE_LINE_SIZE=64
>
>  CONFIG_RTE_PKTMBUF_HEADROOM=128
>
> -# Enable IEEE1588, Keep it disable by default
> -CONFIG_RTE_LIBRTE_IEEE1588=y
> +# Disable IEEE1588 by default
> +CONFIG_RTE_LIBRTE_IEEE1588=n

Removed this block when applying, since, as the commitlog mentioned,
it is disabled by default.

>
>  # Doesn't support NUMA
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


--
David Marchand