From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Harman Kalra <hkalra@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerinj@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>,
dpdk-dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable
Date: Wed, 24 Mar 2021 12:14:59 +0100 [thread overview]
Message-ID: <CAJFAV8yGxPx=62CeL-qgwmYKBGd9WgwASrRx9yS7NPUna+4yWw@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1NcOZekhd+VhHDt4DLUHFTspLW-nuLr_q8oBY8RSVEj3Q@mail.gmail.com>
On Wed, Mar 24, 2021 at 12:01 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Fri, Feb 26, 2021 at 12:31 AM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a
> > maximum of 2048 vectors.
> > The default value is unchanged and set to 512.
>
>
> IMO, We dont need to make it configurable and each platform sets its
> value. That scheme won't work as generic distribution build will fail
> to run.
> Since PCIe specification defines this value and there is no
> performance impact on increasing this,
> IMO, We can change to 2048 as default.
It probably breaks rte_intr_* ABI.
struct rte_intr_handle {
...
int efds[RTE_MAX_RXTX_INTR_VEC_ID]; /**< intr vectors/efds mapping */
struct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID];
/**< intr vector epoll event */
...
I see you need this for octeontx2, so wondering if you could handle
this differently in octeontx2 drivers?
--
David Marchand
next prev parent reply other threads:[~2021-03-24 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 19:01 pbhagavatula
2021-02-25 19:01 ` [dpdk-dev] [PATCH 2/2] config: increase interrupt vectors for octeontx2 pbhagavatula
2021-03-24 11:01 ` [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable Jerin Jacob
2021-03-24 11:14 ` David Marchand [this message]
2021-03-24 12:54 ` Jerin Jacob
2021-03-24 15:25 ` David Marchand
2021-03-24 16:20 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yGxPx=62CeL-qgwmYKBGd9WgwASrRx9yS7NPUna+4yWw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mdr@ashroe.eu \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).