Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Feb 26, 2021 at 12:31 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a
> maximum of 2048 vectors.
> The default value is unchanged and set to 512.


IMO, We dont need to make it configurable and each platform sets its
value. That scheme won't work as generic distribution build will fail
to run.
Since PCIe specification defines this value and there is no
performance impact on increasing this,
IMO, We can change to 2048 as default.

Thought from others?

>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  config/meson.build                          | 1 +
>  lib/librte_eal/include/rte_eal_interrupts.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 3cf560b8a..0fe4d0689 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -247,6 +247,7 @@ dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet'))
>  dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp'))
>  # values which have defaults which may be overridden
>  dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)
> +dpdk_conf.set('RTE_MAX_RXTX_INTR_VEC_ID', 512)
>  dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64)
>  dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true)
>  if dpdk_conf.get('RTE_ARCH_64')
> diff --git a/lib/librte_eal/include/rte_eal_interrupts.h b/lib/librte_eal/include/rte_eal_interrupts.h
> index 00bcc19b6..e9af1a4c2 100644
> --- a/lib/librte_eal/include/rte_eal_interrupts.h
> +++ b/lib/librte_eal/include/rte_eal_interrupts.h
> @@ -17,7 +17,6 @@
>  #ifndef _RTE_EAL_INTERRUPTS_H_
>  #define _RTE_EAL_INTERRUPTS_H_
>
> -#define RTE_MAX_RXTX_INTR_VEC_ID      512
>  #define RTE_INTR_VEC_ZERO_OFFSET      0
>  #define RTE_INTR_VEC_RXTX_OFFSET      1
>
> --
> 2.17.1
>