From: David Marchand <david.marchand@redhat.com>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: dev@dpdk.org, mkp@redhat.com, stable@dpdk.org,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Abhijit Sinha <abhijit.sinha@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH] net/iavf: fix checksum offloading
Date: Mon, 21 Aug 2023 10:22:49 +0200 [thread overview]
Message-ID: <CAJFAV8ybzTaFn4J9-pGdaJy4cTDcMhJTBC+UwcAF5unNWus7NA@mail.gmail.com> (raw)
In-Reply-To: <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com>
On Mon, Aug 21, 2023 at 10:03 AM Eelco Chaudron <echaudro@redhat.com> wrote:
> On 18 Aug 2023, at 11:03, David Marchand wrote:
>
> > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator
> > that a checksum offload has been requested by an application.
> > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set.
> >
> > Fixes: 1e728b01120c ("net/iavf: rework Tx path")
> > Cc: stable@dpdk.org
>
> Thanks for fixing this David! I tested and reviewed this change and it works now.
For the record, Eelco encountered an issue with OVS 3.2 which now uses
ip checksum offloading.
Packets requiring such offloading were dropped by either the net/iavf
driver or the i40e VF hw itself.
--
David Marchand
next prev parent reply other threads:[~2023-08-21 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 9:03 David Marchand
2023-08-21 8:03 ` Eelco Chaudron
2023-08-21 8:22 ` David Marchand [this message]
2023-08-21 11:54 ` Zhang, Qi Z
2023-08-21 17:29 ` David Marchand
2023-08-22 1:52 ` Zhang, Qi Z
2023-08-22 6:11 ` David Marchand
2023-08-22 7:33 ` Zhang, Qi Z
2023-08-22 7:39 ` David Marchand
2023-08-22 7:59 ` Zhang, Qi Z
2023-08-22 10:10 ` Zhang, Qi Z
2023-08-23 6:29 ` [PATCH v2] " David Marchand
2023-08-23 8:33 ` Zhang, Qi Z
2023-08-24 15:24 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ybzTaFn4J9-pGdaJy4cTDcMhJTBC+UwcAF5unNWus7NA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=abhijit.sinha@intel.com \
--cc=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=jingjing.wu@intel.com \
--cc=mkp@redhat.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).