From: Jerin Jacob <jerinjacobk@gmail.com>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
dpdk-dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: fix log message print for regex
Date: Mon, 9 Mar 2020 12:38:20 +0530 [thread overview]
Message-ID: <CALBAE1NEcmQABkf5FOPbzUdZyLfgMKvvrfDtnk06==RC=WiJyA@mail.gmail.com> (raw)
In-Reply-To: <20200309061723.19732-1-skori@marvell.com>
On Mon, Mar 9, 2020 at 11:47 AM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> If user passes log-level eal parameter to enable log level based on regex
> then in case of error message is being printed for pattern match instead of
> regex. Following is the warning message thrown:
>
> Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_options.c.o'.
> In function ‘eal_parse_log_level’,
> inlined from ‘eal_parse_common_option’ at ../lib/librte_eal/common/eal_common_options.c:1418:7:
> ../lib/librte_eal/common/eal_common_options.c:1053:4: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
> 1053 | fprintf(stderr, "cannot set log level %s,%d\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1054 | pattern, priority);
> | ~~~~~~~~~~~~~~~~~~
>
> Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> Acked-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Updated Cc: stable@dpdk.org in commit message
>
> lib/librte_eal/common/eal_common_options.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 75974dd5b..525e51e7d 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -1046,7 +1046,7 @@ eal_parse_log_level(const char *arg)
> if (regex) {
> if (rte_log_set_level_regexp(regex, priority) < 0) {
> fprintf(stderr, "cannot set log level %s,%d\n",
> - pattern, priority);
> + regex, priority);
> goto fail;
> }
> if (rte_log_save_regexp(regex, priority) < 0)
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-09 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 8:25 [dpdk-dev] [PATCH] " Sunil Kumar Kori
2020-02-27 10:57 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-02-27 11:02 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-03-03 9:55 ` David Marchand
2020-03-09 6:15 ` [dpdk-dev] [PATCH v2 1/1] " Sunil Kumar Kori
2020-03-09 6:17 ` Sunil Kumar Kori
2020-03-09 7:08 ` Jerin Jacob [this message]
2020-03-13 9:46 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NEcmQABkf5FOPbzUdZyLfgMKvvrfDtnk06==RC=WiJyA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).