DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sunil Kumar Kori <skori@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] eal: fix log message print for regex
Date: Thu, 27 Feb 2020 11:02:58 +0000	[thread overview]
Message-ID: <CH2PR18MB3270926B29621A0CDA3B53DDB4EB0@CH2PR18MB3270.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8y3E7v+zsu1mog7sWW2T+X_sR792f+qm+ja6wGZ_wZCdA@mail.gmail.com>

Hello David,

We have two build machine with two different version of GCC. 
So the issue is reported on one setup only not on the other one.
It looks like because of different version of GCC, this warning is caught. 

Regards
Sunil Kumar Kori

>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Thursday, February 27, 2020 4:28 PM
>To: Sunil Kumar Kori <skori@marvell.com>
>Cc: Olivier Matz <olivier.matz@6wind.com>; Thomas Monjalon
><thomas@monjalon.net>; dev <dev@dpdk.org>; dpdk stable
><stable@dpdk.org>
>Subject: [EXT] Re: [dpdk-stable] [PATCH] eal: fix log message print for regex
>
>External Email
>
>----------------------------------------------------------------------
>On Thu, Feb 27, 2020 at 9:25 AM Sunil Kumar Kori <skori@marvell.com>
>wrote:
>>
>> If user passes log-level eal parameter to enable log level based on
>> regex then in case of error message is being printed for pattern match
>> instead of regex. Following is the warning message thrown:
>>
>> Compiling C object
>'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_options.c.o'.
>> In function ‘eal_parse_log_level’,
>>    inlined from ‘eal_parse_common_option’ at
>../lib/librte_eal/common/eal_common_options.c:1418:7:
>> ../lib/librte_eal/common/eal_common_options.c:1053:4: warning: ‘%s’
>directive argument is null [-Wformat-overflow=]
>>  1053 |    fprintf(stderr, "cannot set log level %s,%d\n",
>>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>  1054 |     pattern, priority);
>>       |     ~~~~~~~~~~~~~~~~~~
>>
>
>Good catch.
>
>Just to understand, how did you catch it?
>Extra cflags? specific compiler?
>
>
>> Fixes: 7f0bb634a140 ("log: add ability to match log type with
>> globbing")
>
>Missing Cc: stable.
>
>
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>>  lib/librte_eal/common/eal_common_options.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_options.c
>> b/lib/librte_eal/common/eal_common_options.c
>> index 75974dd5b..525e51e7d 100644
>> --- a/lib/librte_eal/common/eal_common_options.c
>> +++ b/lib/librte_eal/common/eal_common_options.c
>> @@ -1046,7 +1046,7 @@ eal_parse_log_level(const char *arg)
>>         if (regex) {
>>                 if (rte_log_set_level_regexp(regex, priority) < 0) {
>>                         fprintf(stderr, "cannot set log level %s,%d\n",
>> -                               pattern, priority);
>> +                               regex, priority);
>>                         goto fail;
>>                 }
>>                 if (rte_log_save_regexp(regex, priority) < 0)
>> --
>> 2.17.1
>>
>
>Acked-by: David Marchand <david.marchand@redhat.com>
>
>
>
>--
>David Marchand


  reply	other threads:[~2020-02-27 11:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  8:25 [dpdk-dev] " Sunil Kumar Kori
2020-02-27 10:57 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-02-27 11:02   ` Sunil Kumar Kori [this message]
2020-03-03  9:55     ` [dpdk-dev] [EXT] " David Marchand
2020-03-09  6:15 ` [dpdk-dev] [PATCH v2 1/1] " Sunil Kumar Kori
2020-03-09  6:17 ` Sunil Kumar Kori
2020-03-09  7:08   ` Jerin Jacob
2020-03-13  9:46     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR18MB3270926B29621A0CDA3B53DDB4EB0@CH2PR18MB3270.namprd18.prod.outlook.com \
    --to=skori@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).