From: Akhil Goyal <gakhil@marvell.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
"ray.kinsella@intel.com" <ray.kinsella@intel.com>
Cc: Ramkumar Balu <rbalu@marvell.com>
Subject: RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint
Date: Thu, 10 Feb 2022 21:08:03 +0000 [thread overview]
Message-ID: <CO6PR18MB44845FC6456E8B7DB7A8BF90D82F9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <MW5PR11MB580948BC5358937320A337B1B82F9@MW5PR11MB5809.namprd11.prod.outlook.com>
Hi Fan,
> Hi Akhil,
>
> I assume everything in asym crypto is under experimental tag at the moment
> right?
> The goal is to have them updated and fixed before DPDK 22.11 so the
> experimental tag can be removed.
>
Asymmetric crypto APIs are marked as experimental, but the structures are not
explicitly marked experimental.
rte_crypto_asym_op is part of union in rte_crypto_op which is definitely not experimental.
So a change in asym_op will result in ABI issues in rte_crypto_op.
David/Ray: Can you review the patch 1/4 of this series from ABI compatibility point of view.
http://patches.dpdk.org/project/dpdk/patch/20220207113555.8431-2-arkadiuszx.kusztal@intel.com/
IMO, as per current experimental tags, we cannot change parameters inside rte_crypto_asym_op
and subsequently in struct rte_crypto_dsa_op_param. What do you suggest?
However, I remember, some exception was added to ignore ABI issues related to asymmetric
crypto. Could you please check why that exception is not working in this case?
Regards,
Akhil
next prev parent reply other threads:[~2022-02-10 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:35 [PATCH v2 0/4] Clarify asymmetric random, add 'k' and " Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 1/4] crypto: add dsa random number k Arek Kusztal
2022-02-11 10:55 ` Ray Kinsella
2022-02-07 11:35 ` [PATCH v2 2/4] crypto: clarify usage of random numbers in asym Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 3/4] crypto: use rte macro instead of direct attribute Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Arek Kusztal
2022-02-10 10:17 ` [EXT] " Akhil Goyal
2022-02-10 16:38 ` Zhang, Roy Fan
2022-02-10 21:08 ` Akhil Goyal [this message]
2022-02-11 10:54 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44845FC6456E8B7DB7A8BF90D82F9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ray.kinsella@intel.com \
--cc=rbalu@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).