DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	David Marchand <david.marchand@redhat.com>
Cc: Amit Gupta <agupta3@marvell.com>,
	"Gobriel, Sameh" <sameh.gobriel@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>, dev <dev@dpdk.org>,
	nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests
Date: Wed, 5 Feb 2020 19:57:27 +0000	[thread overview]
Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A68314785F@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <VE1PR08MB5149966D9BD2F23213F721A198020@VE1PR08MB5149.eurprd08.prod.outlook.com>

>-----Original Message-----
>From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com]
>Sent: Wednesday, February 5, 2020 11:52 AM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; David Marchand <david.marchand@redhat.com>
>Cc: Amit Gupta <agupta3@marvell.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; thomas@monjalon.net; dev <dev@dpdk.org>;
>nd <nd@arm.com>; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
>Subject: RE: [PATCH v2 3/5] test/hash: add lock free reader writer functional tests
>
><snip>
>
>> >> > >
>> >> > > Add lock-free reader writer concurrency functional tests.
>> >> > > These tests will provide the same coverage that non lock-free
>> >> > > APIs have.
>> >> > >
>> >> > > Signed-off-by: Honnappa Nagarahalli
>> >> > > <honnappa.nagarahalli@arm.com>
>> >> > > ---
>> >> > >  app/test/test_hash_readwrite.c | 58
>> >> > > +++++++++++++++++++++-------------
>> >> > >  1 file changed, 36 insertions(+), 22 deletions(-)
>> >> > >
>> >> > > diff --git a/app/test/test_hash_readwrite.c
>> >> > > b/app/test/test_hash_readwrite.c index 635ed5a9f..a9429091c
>> >> > > 100644
>> >> > > --- a/app/test/test_hash_readwrite.c
>> >> > > +++ b/app/test/test_hash_readwrite.c
>> >> > > @@ -121,7 +121,7 @@
>> >> > test_hash_readwrite_worker(__attribute__((unused))
>> >> > > void *arg)  }
>> >> > >
>> >> > >  static int
>> >> > > -init_params(int use_ext, int use_htm, int use_jhash)
>> >> > > +init_params(int use_ext, int use_htm, int rw_lf, int use_jhash)
>> >> > >  {
>> >> > >         unsigned int i;
>> >> > >
>> >> > > @@ -140,15 +140,16 @@ init_params(int use_ext, int use_htm, int
>> >> > use_jhash)
>> >> > >         else
>> >> > >                 hash_params.hash_func = rte_hash_crc;
>> >> > >
>> >> > > +       hash_params.extra_flag =
>> >> > > + RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD;
>> >> > >         if (use_htm)
>> >> > > -               hash_params.extra_flag =
>> >> > > -                       RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT |
>> >> > > -                       RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY |
>> >> > > -                       RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD;
>> >> > > +               hash_params.extra_flag |=
>> >> > > +                       RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT;
>>
>> [Wang, Yipeng] Thanks for the patch Honnappa. Here I think we still need the
>> RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY
>> Flag even with HTM.
>I have made RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY depend on 'rw_lf' flag. The test case HTM +
>RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY will still run when 'rw_lf' is set to 0.
>
[Wang, Yipeng] 
I see, thought was an "else if". It is correct then,
Thanks!

  reply	other threads:[~2020-02-05 19:57 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
2019-09-11 17:05   ` Wang, Yipeng1
2019-10-17  5:02     ` Amit Gupta
2019-11-01  4:54       ` Amit Gupta
2019-11-01 17:04         ` Wang, Yipeng1
2019-11-05 16:37           ` Ferruh Yigit
2019-11-07  3:32             ` [dpdk-dev] [EXT] " Amit Gupta
2019-12-31  4:56               ` Amit Gupta
2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
2019-09-11 17:13   ` Wang, Yipeng1
2019-09-12 15:00     ` Honnappa Nagarahalli
2019-09-13  8:24       ` Amit Gupta
2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
2019-09-13 14:40     ` Aaron Conole
2019-09-13 15:09       ` Wang, Yipeng1
2019-09-13 15:46         ` Honnappa Nagarahalli
2019-09-16  4:39           ` Amit Gupta
2019-10-17  4:57           ` Amit Gupta
2019-10-17 13:16             ` Aaron Conole
2019-10-24  7:22               ` David Marchand
2019-09-13  8:15   ` agupta3
2019-09-11  5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 0/5] " Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 1/5] test/meson: hash test split into shorter subtests Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code Honnappa Nagarahalli
2020-02-05  8:48     ` David Marchand
2020-02-05 16:42       ` David Marchand
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests Honnappa Nagarahalli
2020-02-05  9:07     ` David Marchand
2020-02-05 16:22       ` Honnappa Nagarahalli
2020-02-05 16:41         ` David Marchand
2020-02-05 19:34           ` Wang, Yipeng1
2020-02-05 19:52             ` Honnappa Nagarahalli
2020-02-05 19:57               ` Wang, Yipeng1 [this message]
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 4/5] test/hash: move reader writer lock free tests to perf tests Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 5/5] hash: correct lock free extendable table support Honnappa Nagarahalli
2020-02-05 18:41   ` [dpdk-dev] [PATCH v2 0/5] test/meson: fix hash readwrite timeout failure David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A68314785F@ORSMSX104.amr.corp.intel.com \
    --to=yipeng1.wang@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=agupta3@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).