From: Bing Zhao <bingz@nvidia.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
Date: Tue, 16 Nov 2021 10:25:33 +0000 [thread overview]
Message-ID: <DM4PR12MB51848386B980DED8509C0593D0999@DM4PR12MB5184.namprd12.prod.outlook.com> (raw)
In-Reply-To: <65a4c5ea-d0fb-c1a4-56de-7fdb99b8ac53@redhat.com>
Hi Maxime,
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, November 16, 2021 6:25 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: Re: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
>
> External email: Use caution opening links or attachments
>
>
> On 11/12/21 15:42, Bing Zhao wrote:
> > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> the
> > caller. A zero means success without any error.
> >
> > The typo in the if-condition should be fixed in case there is a
> > misjudgment.
> >
> > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> > drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > index e65e4faa47..43a2b98255 100644
> > --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv
> *priv, uint64_t log_base,
> > (void
> *)(uintptr_t)log_base,
> > log_size, &priv-
> >lm_mr);
> >
> > - if (!ret) {
> > + if (ret) {
> > DRV_LOG(ERR, "Failed to allocate wrapped MR for
> lm.");
> > return -1;
> > }
> >
>
> Applied to dpdk-next-virtio/main with Fixes tag fixed.
>
> Thanks,
> Maxime
Thank you.
BR. Bing
prev parent reply other threads:[~2021-11-16 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:42 Bing Zhao
2021-11-16 7:54 ` Xia, Chenbo
2021-11-16 8:01 ` Bing Zhao
2021-11-16 8:04 ` Xia, Chenbo
2021-11-16 8:13 ` Bing Zhao
2021-11-16 10:24 ` Maxime Coquelin
2021-11-16 10:25 ` Bing Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB51848386B980DED8509C0593D0999@DM4PR12MB5184.namprd12.prod.outlook.com \
--to=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).