From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>
Cc: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: [RFC] Rx adapter create API changes
Date: Tue, 1 Aug 2023 10:04:05 +0000 [thread overview]
Message-ID: <DM6PR11MB3868D616108C66842DB96EFCA10AA@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]
Hi all,
The API "rte_event_eth_rx_adapter_create_with_params()" is an extension to rte_event_eth_rx_adapter_create() with additional adapter configuration params structure.
There is no equivalent API existing today for "rte_event_eth_rx_adapter_create_ext()" API. We may need to have one more adapter create API for this.
That makes so many Adapter create APIs and will be confusing for the user.
I am proposing the following changes to the Rx adapter create APIs which will consolidate the create APIs to 2 in number with all possible combinations.
Current RX Adapter create APIs
Proposed changes
int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
rte_event_eth_rx_adapter_conf_cb conf_cb,
void *conf_arg)
int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
rte_event_eth_rx_adapter_conf_cb conf_cb,
void *conf_arg,
struct rte_event_eth_rx_adapter_params *rxa_params)
int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config)
int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config,
struct rte_event_eth_rx_adapter_params *rxa_params)
int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config,
struct rte_event_eth_rx_adapter_params *rxa_params)
Will be deprecated.
The applications that are currently using rte_event_eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_create() APIs for creating Rx adapter can pass NULL argument for the
Newly added argument which will behave same as before.
Let me know your comments for this change.
Patchwork link:
https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.harish.k@intel.com/
-Harish
[-- Attachment #2: Type: text/html, Size: 7723 bytes --]
reply other threads:[~2023-08-01 10:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3868D616108C66842DB96EFCA10AA@DM6PR11MB3868.namprd11.prod.outlook.com \
--to=s.v.naga.harish.k@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).