[PATCH] doc: update recipe for static rdma-core in mlx guides

[PATCH] doc: update recipe for static rdma-core in mlx guides

[Thomas Monjalon]

With recent versions of rdma-core, it becomes important to install,
so some non-standard compiler tricks are avoided.

While at it, disabling unneeded pyVerbs and man pages.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/nics/mlx4.rst     | 3 ++-
 doc/guides/platform/mlx5.rst | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 924ce6f64b..c6279f51d0 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -209,8 +209,9 @@ Current RDMA core package and Linux kernel (recommended)
 - Starting with rdma-core v21, static libraries can be built::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 .. _`RDMA core installation documentation`: https://raw.githubusercontent.com/linux-rdma/rdma-core/master/README.md
 
diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
index 3cc1dd29e2..5784b9a87b 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -162,8 +162,9 @@ https://github.com/linux-rdma/rdma-core
 It is possible to build rdma-core as static libraries starting with version 21::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 
 NVIDIA MLNX_OFED/EN
-- 
2.38.1

Re: [PATCH] doc: update recipe for static rdma-core in mlx guides

[Bruce Richardson]

On Thu, Dec 08, 2022 at 12:16:46PM +0100, Thomas Monjalon wrote:
> With recent versions of rdma-core, it becomes important to install,
> so some non-standard compiler tricks are avoided.
> 
I think this paragraph could do with a bit more explanation in it, e.g. to
clarify that this is (presumably) installing package vs working with it in
build directory.

/Bruce

[PATCH v2] doc: update recipe for static rdma-core in mlx guides

[Thomas Monjalon]

With recent versions of rdma-core, it becomes important to install
the library after its compilation.
If including rdma-core library from its build directory,
some non-standard compiler tricks are used.
When using an install directory for rdma-core, DPDK compilation is fine.

While at it, disabling unneeded pyVerbs and man pages.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: reword commit log
---
 doc/guides/nics/mlx4.rst     | 3 ++-
 doc/guides/platform/mlx5.rst | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 924ce6f64b..c6279f51d0 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -209,8 +209,9 @@ Current RDMA core package and Linux kernel (recommended)
 - Starting with rdma-core v21, static libraries can be built::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 .. _`RDMA core installation documentation`: https://raw.githubusercontent.com/linux-rdma/rdma-core/master/README.md
 
diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
index 3cc1dd29e2..5784b9a87b 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -162,8 +162,9 @@ https://github.com/linux-rdma/rdma-core
 It is possible to build rdma-core as static libraries starting with version 21::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 
 NVIDIA MLNX_OFED/EN
-- 
2.39.0

RE: [PATCH v2] doc: update recipe for static rdma-core in mlx guides

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, January 11, 2023 10:45 AM
> To: dev@dpdk.org
> Cc: Ali Alnubani <alialnu@nvidia.com>; bruce.richardson@intel.com; Matan
> Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v2] doc: update recipe for static rdma-core in mlx guides
> 
> With recent versions of rdma-core, it becomes important to install the library
> after its compilation.
> If including rdma-core library from its build directory, some non-standard
> compiler tricks are used.
> When using an install directory for rdma-core, DPDK compilation is fine.
> 
> While at it, disabling unneeded pyVerbs and man pages.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: reword commit log
> ---
>  doc/guides/nics/mlx4.rst     | 3 ++-
>  doc/guides/platform/mlx5.rst | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh