DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used
@ 2019-10-15  7:01 asomalap
  2019-10-15 11:00 ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: asomalap @ 2019-10-15  7:01 UTC (permalink / raw)
  To: dev; +Cc: stable

From: Amaranath Somalapuram <asomalap@amd.com>

when ccp_auth_opt=1 is set and
if authentication error occurred ccp driver crash.
proble is enqueue count and dequeue count miss match if we continue.
Cc: stable@dpdk.org

Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
---
 drivers/crypto/ccp/ccp_crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c
index 19ae9153d..1837c8543 100644
--- a/drivers/crypto/ccp/ccp_crypto.c
+++ b/drivers/crypto/ccp/ccp_crypto.c
@@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
 							 session, auth_ctx);
 				if (op[i]->status !=
 				    RTE_CRYPTO_OP_STATUS_SUCCESS)
-					continue;
+					CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
 			} else
 				result = ccp_crypto_auth(op[i], cmd_q, b_info);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used
  2019-10-15  7:01 [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used asomalap
@ 2019-10-15 11:00 ` Akhil Goyal
  2019-10-22  5:18   ` Somalapuram, Amaranath
  0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2019-10-15 11:00 UTC (permalink / raw)
  To: asomalap, dev; +Cc: stable

Title: crypto/ccp: fix CPU authentication crash
> 
> From: Amaranath Somalapuram <asomalap@amd.com>
> 
> when ccp_auth_opt=1 is set and
> if authentication error occurred ccp driver crash.
> proble is enqueue count and dequeue count miss match if we continue.
Please rephrase this description.

Fixes line??

> Cc: stable@dpdk.org
> 
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
>  drivers/crypto/ccp/ccp_crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c
> index 19ae9153d..1837c8543 100644
> --- a/drivers/crypto/ccp/ccp_crypto.c
> +++ b/drivers/crypto/ccp/ccp_crypto.c
> @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
>  							 session, auth_ctx);
>  				if (op[i]->status !=
>  				    RTE_CRYPTO_OP_STATUS_SUCCESS)
> -					continue;
> +
> 	CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
>  			} else
>  				result = ccp_crypto_auth(op[i], cmd_q, b_info);
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used
  2019-10-15 11:00 ` Akhil Goyal
@ 2019-10-22  5:18   ` Somalapuram, Amaranath
  2019-10-22  6:03     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Somalapuram, Amaranath @ 2019-10-22  5:18 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: stable

Hi Akhil,

Not sure about how to use fix line if I don't have bug number.

If I run ./devtools/check-git-log.sh it expect bug number. 
Do you recommend to log a bug for my patches ??

Please let me know.

Regards,
S.Amarnath

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: Tuesday, October 15, 2019 4:31 PM
To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
Cc: stable@dpdk.org
Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used

[CAUTION: External Email]

Title: crypto/ccp: fix CPU authentication crash
>
> From: Amaranath Somalapuram <asomalap@amd.com>
>
> when ccp_auth_opt=1 is set and
> if authentication error occurred ccp driver crash.
> proble is enqueue count and dequeue count miss match if we continue.
Please rephrase this description.

Fixes line??

> Cc: stable@dpdk.org
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
>  drivers/crypto/ccp/ccp_crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp_crypto.c 
> b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644
> --- a/drivers/crypto/ccp/ccp_crypto.c
> +++ b/drivers/crypto/ccp/ccp_crypto.c
> @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
>                                                        session, auth_ctx);
>                               if (op[i]->status !=
>                                   RTE_CRYPTO_OP_STATUS_SUCCESS)
> -                                     continue;
> +
>       CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
>                       } else
>                               result = ccp_crypto_auth(op[i], cmd_q, 
> b_info);
>
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used
  2019-10-22  5:18   ` Somalapuram, Amaranath
@ 2019-10-22  6:03     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2019-10-22  6:03 UTC (permalink / raw)
  To: Somalapuram, Amaranath, dev; +Cc: stable

Hi,

Please refer coding guidelines at https://doc.dpdk.org/guides/contributing/patches.html
Here is the example of a fix commit.  In this "abcdefgh1234" is the commit id which introduced this issue.
You can check the commit id of the changed commit using git blame <file name>.

doc: fix some parameter description

Update the docs, fixing description of some parameter.

Fixes: abcdefgh1234 ("doc: add some parameter")
Cc: author@example.com

Signed-off-by: Alex Smith <alex.smith@example.com>

> 
> Hi Akhil,
> 
> Not sure about how to use fix line if I don't have bug number.
> 
> If I run ./devtools/check-git-log.sh it expect bug number.
> Do you recommend to log a bug for my patches ??
> 
> Please let me know.
> 
> Regards,
> S.Amarnath
> 
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, October 15, 2019 4:31 PM
> To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>;
> dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication
> is used
> 
> [CAUTION: External Email]
> 
> Title: crypto/ccp: fix CPU authentication crash
> >
> > From: Amaranath Somalapuram <asomalap@amd.com>
> >
> > when ccp_auth_opt=1 is set and
> > if authentication error occurred ccp driver crash.
> > proble is enqueue count and dequeue count miss match if we continue.
> Please rephrase this description.
> 
> Fixes line??
> 
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> > ---
> >  drivers/crypto/ccp/ccp_crypto.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/ccp/ccp_crypto.c
> > b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644
> > --- a/drivers/crypto/ccp/ccp_crypto.c
> > +++ b/drivers/crypto/ccp/ccp_crypto.c
> > @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
> >                                                        session, auth_ctx);
> >                               if (op[i]->status !=
> >                                   RTE_CRYPTO_OP_STATUS_SUCCESS)
> > -                                     continue;
> > +
> >       CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
> >                       } else
> >                               result = ccp_crypto_auth(op[i], cmd_q,
> > b_info);
> >
> > --
> > 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-22  6:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15  7:01 [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used asomalap
2019-10-15 11:00 ` Akhil Goyal
2019-10-22  5:18   ` Somalapuram, Amaranath
2019-10-22  6:03     ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).