DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] doc: add inline protocol in feature list
@ 2019-12-10  6:53 Anoob Joseph
  2020-01-21  5:40 ` Anoob Joseph
  2020-02-17 15:22 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
  0 siblings, 2 replies; 16+ messages in thread
From: Anoob Joseph @ 2019-12-10  6:53 UTC (permalink / raw)
  To: John McNamara, Marko Kovacevic, Ferruh Yigit
  Cc: Anoob Joseph, Jerin Jacob, Narayana Prasad, dev

Update feature list to include inline protocol offload.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 doc/guides/nics/features.rst         | 18 ++++++++++++++++++
 doc/guides/nics/features/default.ini |  1 +
 2 files changed, 19 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 8394a65..f4eb2a9 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline IPsec). See Security library and
   ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
 
 
+.. _nic_features_inline_protocol_doc:
+
+Inline protocol
+---------------
+
+Supports inline protocol processing (e.g. inline IPsec). See Security library and PMD documentation for more details.
+
+* **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``,
+  ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+
+
 .. _nic_features_crc_offload:
 
 CRC offload
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 91ec619..4d0ad32 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -42,6 +42,7 @@ Flow API             =
 Rate limitation      =
 Traffic mirroring    =
 Inline crypto        =
+Inline protocol      =
 CRC offload          =
 VLAN offload         =
 QinQ offload         =
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
  2019-12-10  6:53 [dpdk-dev] [PATCH] doc: add inline protocol in feature list Anoob Joseph
@ 2020-01-21  5:40 ` Anoob Joseph
  2020-01-21 16:12   ` Ferruh Yigit
  2020-02-17 15:22 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
  1 sibling, 1 reply; 16+ messages in thread
From: Anoob Joseph @ 2020-01-21  5:40 UTC (permalink / raw)
  To: Anoob Joseph, John McNamara, Marko Kovacevic, Ferruh Yigit
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev

Hi Ferruh,

Can you review this patch?

Thanks,
Anoob

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> Sent: Tuesday, December 10, 2019 12:23 PM
> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
> 
> Update feature list to include inline protocol offload.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
>  doc/guides/nics/features/default.ini |  1 +
>  2 files changed, 19 insertions(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index
> 8394a65..f4eb2a9 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline IPsec). See
> Security library and
>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> 
> 
> +.. _nic_features_inline_protocol_doc:
> +
> +Inline protocol
> +---------------
> +
> +Supports inline protocol processing (e.g. inline IPsec). See Security library and
> PMD documentation for more details.
> +
> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
> +* **[implements] rte_security_ops**: ``session_create``,
> +``session_update``,
> +  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``,
> +``get_userdata``,
> +  ``capabilities_get``.
> +* **[provides] rte_eth_dev_info**:
> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
> +  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> +
> +
>  .. _nic_features_crc_offload:
> 
>  CRC offload
> diff --git a/doc/guides/nics/features/default.ini
> b/doc/guides/nics/features/default.ini
> index 91ec619..4d0ad32 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -42,6 +42,7 @@ Flow API             =
>  Rate limitation      =
>  Traffic mirroring    =
>  Inline crypto        =
> +Inline protocol      =
>  CRC offload          =
>  VLAN offload         =
>  QinQ offload         =
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
  2020-01-21  5:40 ` Anoob Joseph
@ 2020-01-21 16:12   ` Ferruh Yigit
  2020-01-22  9:47     ` [dpdk-dev] [EXT] " Anoob Joseph
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2020-01-21 16:12 UTC (permalink / raw)
  To: Anoob Joseph, John McNamara, Marko Kovacevic
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev

On 1/21/2020 5:40 AM, Anoob Joseph wrote:
> Hi Ferruh,
> 
> Can you review this patch?

Hi Anoob,

What is the difference between "Inline crypto" in that document and this "Inline
protocol"? Both seems providing same outpout.
Is there a way to differentiate them more clearly?

> 
> Thanks,
> Anoob
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
>> Sent: Tuesday, December 10, 2019 12:23 PM
>> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
>> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
>> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
>> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
>> <pathreya@marvell.com>; dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
>>
>> Update feature list to include inline protocol offload.
>>
>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
>>  doc/guides/nics/features/default.ini |  1 +
>>  2 files changed, 19 insertions(+)
>>
>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index
>> 8394a65..f4eb2a9 100644
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline IPsec). See
>> Security library and
>>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>>
>>
>> +.. _nic_features_inline_protocol_doc:
>> +
>> +Inline protocol
>> +---------------
>> +
>> +Supports inline protocol processing (e.g. inline IPsec). See Security library and
>> PMD documentation for more details.
>> +
>> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
>> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
>> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
>> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
>> +* **[implements] rte_security_ops**: ``session_create``,
>> +``session_update``,
>> +  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``,
>> +``get_userdata``,
>> +  ``capabilities_get``.
>> +* **[provides] rte_eth_dev_info**:
>> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
>> +  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
>> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
>> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>> +
>> +
>>  .. _nic_features_crc_offload:
>>
>>  CRC offload
>> diff --git a/doc/guides/nics/features/default.ini
>> b/doc/guides/nics/features/default.ini
>> index 91ec619..4d0ad32 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -42,6 +42,7 @@ Flow API             =
>>  Rate limitation      =
>>  Traffic mirroring    =
>>  Inline crypto        =
>> +Inline protocol      =
>>  CRC offload          =
>>  VLAN offload         =
>>  QinQ offload         =
>> --
>> 2.7.4
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-01-21 16:12   ` Ferruh Yigit
@ 2020-01-22  9:47     ` " Anoob Joseph
  2020-02-04 14:35       ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Anoob Joseph @ 2020-01-22  9:47 UTC (permalink / raw)
  To: Ferruh Yigit, John McNamara, Marko Kovacevic
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev

Hi Ferruh,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, January 21, 2020 9:42 PM
> To: Anoob Joseph <anoobj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Narayana Prasad Raju
> Athreya <pathreya@marvell.com>; dev@dpdk.org
> Subject: [EXT] Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 1/21/2020 5:40 AM, Anoob Joseph wrote:
> > Hi Ferruh,
> >
> > Can you review this patch?
> 
> Hi Anoob,
> 
> What is the difference between "Inline crypto" in that document and this
> "Inline protocol"? Both seems providing same outpout.

[Anoob] Yes. It is partly because the description of "inline crypto" is not accurate. The feature, "inline crypto" is not ipsec aware but would do crypto operation in the ipsec. This summary points to the security documentation for further details and that doc clearly explains the difference between both modes.
 
> Is there a way to differentiate them more clearly?

[Anoob] There are two options I can think of,
1. Update the feature list to describe the difference between the two. Have a line like,
	"As compared to inline crypto, inline protocol will handle the entire protocol offload in addition to the crypto operation."
2. Both inline crypto and inline protocol falls under security. So could even rename "Inline crypto" to "Inline security offload" and we should be good to go. Also, under inline protocol, there are various protocols possible. Say, tomorrow when we add MACSEC support, the same question would arise (as in whether it's a new feature or would it be under "inline protocol").
 
> 
> >
> > Thanks,
> > Anoob
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> >> Sent: Tuesday, December 10, 2019 12:23 PM
> >> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> >> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> >> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> >> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> >> <pathreya@marvell.com>; dev@dpdk.org
> >> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
> >>
> >> Update feature list to include inline protocol offload.
> >>
> >> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> >> ---
> >>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
> >>  doc/guides/nics/features/default.ini |  1 +
> >>  2 files changed, 19 insertions(+)
> >>
> >> diff --git a/doc/guides/nics/features.rst
> >> b/doc/guides/nics/features.rst index
> >> 8394a65..f4eb2a9 100644
> >> --- a/doc/guides/nics/features.rst
> >> +++ b/doc/guides/nics/features.rst
> >> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline
> >> IPsec). See Security library and
> >>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> >> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> >>
> >>
> >> +.. _nic_features_inline_protocol_doc:
> >> +
> >> +Inline protocol
> >> +---------------
> >> +
> >> +Supports inline protocol processing (e.g. inline IPsec). See
> >> +Security library and
> >> PMD documentation for more details.
> >> +
> >> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
> >> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
> >> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
> >> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
> >> +* **[implements] rte_security_ops**: ``session_create``,
> >> +``session_update``,
> >> +  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``,
> >> +``get_userdata``,
> >> +  ``capabilities_get``.
> >> +* **[provides] rte_eth_dev_info**:
> >>
> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
> >> +
> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
> >> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
> >> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> >> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> >> +
> >> +
> >>  .. _nic_features_crc_offload:
> >>
> >>  CRC offload
> >> diff --git a/doc/guides/nics/features/default.ini
> >> b/doc/guides/nics/features/default.ini
> >> index 91ec619..4d0ad32 100644
> >> --- a/doc/guides/nics/features/default.ini
> >> +++ b/doc/guides/nics/features/default.ini
> >> @@ -42,6 +42,7 @@ Flow API             =
> >>  Rate limitation      =
> >>  Traffic mirroring    =
> >>  Inline crypto        =
> >> +Inline protocol      =
> >>  CRC offload          =
> >>  VLAN offload         =
> >>  QinQ offload         =
> >> --
> >> 2.7.4
> >


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-01-22  9:47     ` [dpdk-dev] [EXT] " Anoob Joseph
@ 2020-02-04 14:35       ` Ferruh Yigit
  2020-02-10  5:44         ` Anoob Joseph
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2020-02-04 14:35 UTC (permalink / raw)
  To: Anoob Joseph, John McNamara, Marko Kovacevic
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Akhil Goyal, Konstantin Ananyev, Hemant Agrawal, Fan Zhang,
	Fiona Trahe

On 1/22/2020 9:47 AM, Anoob Joseph wrote:
> Hi Ferruh,
> 
> Please see inline.
> 
> Thanks,
> Anoob
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Tuesday, January 21, 2020 9:42 PM
>> To: Anoob Joseph <anoobj@marvell.com>; John McNamara
>> <john.mcnamara@intel.com>; Marko Kovacevic
>> <marko.kovacevic@intel.com>
>> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Narayana Prasad Raju
>> Athreya <pathreya@marvell.com>; dev@dpdk.org
>> Subject: [EXT] Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 1/21/2020 5:40 AM, Anoob Joseph wrote:
>>> Hi Ferruh,
>>>
>>> Can you review this patch?
>>
>> Hi Anoob,
>>
>> What is the difference between "Inline crypto" in that document and this
>> "Inline protocol"? Both seems providing same outpout.
> 
> [Anoob] Yes. It is partly because the description of "inline crypto" is not accurate. The feature, "inline crypto" is not ipsec aware but would do crypto operation in the ipsec. This summary points to the security documentation for further details and that doc clearly explains the difference between both modes.
>  
>> Is there a way to differentiate them more clearly?
> 
> [Anoob] There are two options I can think of,
> 1. Update the feature list to describe the difference between the two. Have a line like,
> 	"As compared to inline crypto, inline protocol will handle the entire protocol offload in addition to the crypto operation."
> 2. Both inline crypto and inline protocol falls under security. So could even rename "Inline crypto" to "Inline security offload" and we should be good to go. Also, under inline protocol, there are various protocols possible. Say, tomorrow when we add MACSEC support, the same question would arise (as in whether it's a new feature or would it be under "inline protocol").

Hi Anoob,

These seems security related and I don't know enough to comment if this is
correct thing to do. I have cc'ed a few more people for comment.

@Akhil, would you mind if I assign this to you?

Thanks,
ferruh

>  
>>
>>>
>>> Thanks,
>>> Anoob
>>>
>>>> -----Original Message-----
>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
>>>> Sent: Tuesday, December 10, 2019 12:23 PM
>>>> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
>>>> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
>>>> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
>>>> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
>>>> <pathreya@marvell.com>; dev@dpdk.org
>>>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature list
>>>>
>>>> Update feature list to include inline protocol offload.
>>>>
>>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>>> ---
>>>>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
>>>>  doc/guides/nics/features/default.ini |  1 +
>>>>  2 files changed, 19 insertions(+)
>>>>
>>>> diff --git a/doc/guides/nics/features.rst
>>>> b/doc/guides/nics/features.rst index
>>>> 8394a65..f4eb2a9 100644
>>>> --- a/doc/guides/nics/features.rst
>>>> +++ b/doc/guides/nics/features.rst
>>>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline
>>>> IPsec). See Security library and
>>>>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>>>>
>>>>
>>>> +.. _nic_features_inline_protocol_doc:
>>>> +
>>>> +Inline protocol
>>>> +---------------
>>>> +
>>>> +Supports inline protocol processing (e.g. inline IPsec). See
>>>> +Security library and
>>>> PMD documentation for more details.
>>>> +
>>>> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
>>>> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
>>>> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
>>>> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
>>>> +* **[implements] rte_security_ops**: ``session_create``,
>>>> +``session_update``,
>>>> +  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``,
>>>> +``get_userdata``,
>>>> +  ``capabilities_get``.
>>>> +* **[provides] rte_eth_dev_info**:
>>>>
>> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
>>>> +
>> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
>>>> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
>>>> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>>>> +
>>>> +
>>>>  .. _nic_features_crc_offload:
>>>>
>>>>  CRC offload
>>>> diff --git a/doc/guides/nics/features/default.ini
>>>> b/doc/guides/nics/features/default.ini
>>>> index 91ec619..4d0ad32 100644
>>>> --- a/doc/guides/nics/features/default.ini
>>>> +++ b/doc/guides/nics/features/default.ini
>>>> @@ -42,6 +42,7 @@ Flow API             =
>>>>  Rate limitation      =
>>>>  Traffic mirroring    =
>>>>  Inline crypto        =
>>>> +Inline protocol      =
>>>>  CRC offload          =
>>>>  VLAN offload         =
>>>>  QinQ offload         =
>>>> --
>>>> 2.7.4
>>>
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-04 14:35       ` Ferruh Yigit
@ 2020-02-10  5:44         ` Anoob Joseph
  2020-02-12 10:25           ` Akhil Goyal
  0 siblings, 1 reply; 16+ messages in thread
From: Anoob Joseph @ 2020-02-10  5:44 UTC (permalink / raw)
  To: Akhil Goyal
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	Ferruh Yigit, John McNamara, Marko Kovacevic

Hi Akhil, 

Can you review this patch?

Thanks,
Anoob

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, February 4, 2020 8:06 PM
> To: Anoob Joseph <anoobj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Narayana Prasad Raju
> Athreya <pathreya@marvell.com>; dev@dpdk.org; Akhil Goyal
> <akhil.goyal@nxp.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Fan Zhang <roy.fan.zhang@intel.com>; Fiona
> Trahe <fiona.trahe@intel.com>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature
> list
> 
> On 1/22/2020 9:47 AM, Anoob Joseph wrote:
> > Hi Ferruh,
> >
> > Please see inline.
> >
> > Thanks,
> > Anoob
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Tuesday, January 21, 2020 9:42 PM
> >> To: Anoob Joseph <anoobj@marvell.com>; John McNamara
> >> <john.mcnamara@intel.com>; Marko Kovacevic
> >> <marko.kovacevic@intel.com>
> >> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Narayana Prasad
> >> Raju Athreya <pathreya@marvell.com>; dev@dpdk.org
> >> Subject: [EXT] Re: [dpdk-dev] [PATCH] doc: add inline protocol in
> >> feature list
> >>
> >> External Email
> >>
> >> ---------------------------------------------------------------------
> >> - On 1/21/2020 5:40 AM, Anoob Joseph wrote:
> >>> Hi Ferruh,
> >>>
> >>> Can you review this patch?
> >>
> >> Hi Anoob,
> >>
> >> What is the difference between "Inline crypto" in that document and
> >> this "Inline protocol"? Both seems providing same outpout.
> >
> > [Anoob] Yes. It is partly because the description of "inline crypto" is not
> accurate. The feature, "inline crypto" is not ipsec aware but would do crypto
> operation in the ipsec. This summary points to the security documentation
> for further details and that doc clearly explains the difference between both
> modes.
> >
> >> Is there a way to differentiate them more clearly?
> >
> > [Anoob] There are two options I can think of, 1. Update the feature
> > list to describe the difference between the two. Have a line like,
> > 	"As compared to inline crypto, inline protocol will handle the entire
> protocol offload in addition to the crypto operation."
> > 2. Both inline crypto and inline protocol falls under security. So could even
> rename "Inline crypto" to "Inline security offload" and we should be good to
> go. Also, under inline protocol, there are various protocols possible. Say,
> tomorrow when we add MACSEC support, the same question would arise (as
> in whether it's a new feature or would it be under "inline protocol").
> 
> Hi Anoob,
> 
> These seems security related and I don't know enough to comment if this is
> correct thing to do. I have cc'ed a few more people for comment.
> 
> @Akhil, would you mind if I assign this to you?
> 
> Thanks,
> ferruh
> 
> >
> >>
> >>>
> >>> Thanks,
> >>> Anoob
> >>>
> >>>> -----Original Message-----
> >>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> >>>> Sent: Tuesday, December 10, 2019 12:23 PM
> >>>> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> >>>> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> >>>> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> >>>> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> >>>> <pathreya@marvell.com>; dev@dpdk.org
> >>>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature
> >>>> list
> >>>>
> >>>> Update feature list to include inline protocol offload.
> >>>>
> >>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> >>>> ---
> >>>>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
> >>>>  doc/guides/nics/features/default.ini |  1 +
> >>>>  2 files changed, 19 insertions(+)
> >>>>
> >>>> diff --git a/doc/guides/nics/features.rst
> >>>> b/doc/guides/nics/features.rst index
> >>>> 8394a65..f4eb2a9 100644
> >>>> --- a/doc/guides/nics/features.rst
> >>>> +++ b/doc/guides/nics/features.rst
> >>>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline
> >>>> IPsec). See Security library and
> >>>>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> >>>>
> >>>>
> >>>> +.. _nic_features_inline_protocol_doc:
> >>>> +
> >>>> +Inline protocol
> >>>> +---------------
> >>>> +
> >>>> +Supports inline protocol processing (e.g. inline IPsec). See
> >>>> +Security library and
> >>>> PMD documentation for more details.
> >>>> +
> >>>> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
> >>>> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
> >>>> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
> >>>> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
> >>>> +* **[implements] rte_security_ops**: ``session_create``,
> >>>> +``session_update``,
> >>>> +  ``session_stats_get``, ``session_destroy``,
> >>>> +``set_pkt_metadata``, ``get_userdata``,
> >>>> +  ``capabilities_get``.
> >>>> +* **[provides] rte_eth_dev_info**:
> >>>>
> >>
> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
> >>>> +
> >>
> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
> >>>> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
> >>>> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> >>>> +
> >>>> +
> >>>>  .. _nic_features_crc_offload:
> >>>>
> >>>>  CRC offload
> >>>> diff --git a/doc/guides/nics/features/default.ini
> >>>> b/doc/guides/nics/features/default.ini
> >>>> index 91ec619..4d0ad32 100644
> >>>> --- a/doc/guides/nics/features/default.ini
> >>>> +++ b/doc/guides/nics/features/default.ini
> >>>> @@ -42,6 +42,7 @@ Flow API             =
> >>>>  Rate limitation      =
> >>>>  Traffic mirroring    =
> >>>>  Inline crypto        =
> >>>> +Inline protocol      =
> >>>>  CRC offload          =
> >>>>  VLAN offload         =
> >>>>  QinQ offload         =
> >>>> --
> >>>> 2.7.4
> >>>
> >


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-10  5:44         ` Anoob Joseph
@ 2020-02-12 10:25           ` Akhil Goyal
  2020-02-12 13:30             ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Akhil Goyal @ 2020-02-12 10:25 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	Ferruh Yigit, John McNamara, Marko Kovacevic

Hi Anoob,
> > >>
> > >> Hi Anoob,
> > >>
> > >> What is the difference between "Inline crypto" in that document and
> > >> this "Inline protocol"? Both seems providing same outpout.
> > >
> > > [Anoob] Yes. It is partly because the description of "inline crypto" is not
> > accurate. The feature, "inline crypto" is not ipsec aware but would do crypto
> > operation in the ipsec. This summary points to the security documentation
> > for further details and that doc clearly explains the difference between both
> > modes.
> > >
> > >> Is there a way to differentiate them more clearly?
> > >
> > > [Anoob] There are two options I can think of, 1. Update the feature
> > > list to describe the difference between the two. Have a line like,
> > > 	"As compared to inline crypto, inline protocol will handle the entire
> > protocol offload in addition to the crypto operation."
> > > 2. Both inline crypto and inline protocol falls under security. So could even
> > rename "Inline crypto" to "Inline security offload" and we should be good to
> > go. Also, under inline protocol, there are various protocols possible. Say,
> > tomorrow when we add MACSEC support, the same question would arise (as
> > in whether it's a new feature or would it be under "inline protocol").

Please re-phrase the description of inline crypto as well so that there is a clear 
Differentiation between the two modes. Referring to rte_security is not enough.

It can be something like
For Inline crypto: An operation defined in rte_security lib to perform only crypto
Operations of the security protocol while the packet is received at NIC. NIC is not aware
of the protocol operations. See Security library and PMD documentation for more details.

For Inline protocol : An operation defined in rte_security lib to perform protocol processing for
the security protocol (e.g. IPSEC, MACSEC) while the packet is received at the NIC. The NIC is capable
to understand the security protocol operations. See Security library and PMD documentation for more details.


> >
> > Hi Anoob,
> >
> > These seems security related and I don't know enough to comment if this is
> > correct thing to do. I have cc'ed a few more people for comment.
> >
> > @Akhil, would you mind if I assign this to you?
> >
> > Thanks,
> > ferruh
> >
> > >
> > >>
> > >>>
> > >>> Thanks,
> > >>> Anoob
> > >>>
> > >>>> -----Original Message-----
> > >>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> > >>>> Sent: Tuesday, December 10, 2019 12:23 PM
> > >>>> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> > >>>> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> > >>>> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> > >>>> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> > >>>> <pathreya@marvell.com>; dev@dpdk.org
> > >>>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature
> > >>>> list
> > >>>>
> > >>>> Update feature list to include inline protocol offload.
> > >>>>
> > >>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > >>>> ---
> > >>>>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
> > >>>>  doc/guides/nics/features/default.ini |  1 +
> > >>>>  2 files changed, 19 insertions(+)
> > >>>>
> > >>>> diff --git a/doc/guides/nics/features.rst
> > >>>> b/doc/guides/nics/features.rst index
> > >>>> 8394a65..f4eb2a9 100644
> > >>>> --- a/doc/guides/nics/features.rst
> > >>>> +++ b/doc/guides/nics/features.rst
> > >>>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline
> > >>>> IPsec). See Security library and
> > >>>>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> > >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> > >>>>
> > >>>>
> > >>>> +.. _nic_features_inline_protocol_doc:
> > >>>> +
> > >>>> +Inline protocol
> > >>>> +---------------
> > >>>> +
> > >>>> +Supports inline protocol processing (e.g. inline IPsec). See
> > >>>> +Security library and
> > >>>> PMD documentation for more details.
> > >>>> +
> > >>>> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
> > >>>> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
> > >>>> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
> > >>>> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
> > >>>> +* **[implements] rte_security_ops**: ``session_create``,
> > >>>> +``session_update``,
> > >>>> +  ``session_stats_get``, ``session_destroy``,
> > >>>> +``set_pkt_metadata``, ``get_userdata``,
> > >>>> +  ``capabilities_get``.
> > >>>> +* **[provides] rte_eth_dev_info**:
> > >>>>
> > >>
> > +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
> > >>>> +
> > >>
> > ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
> > >>>> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
> > >>>> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
> > >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
> > >>>> +
> > >>>> +
> > >>>>  .. _nic_features_crc_offload:
> > >>>>
> > >>>>  CRC offload
> > >>>> diff --git a/doc/guides/nics/features/default.ini
> > >>>> b/doc/guides/nics/features/default.ini
> > >>>> index 91ec619..4d0ad32 100644
> > >>>> --- a/doc/guides/nics/features/default.ini
> > >>>> +++ b/doc/guides/nics/features/default.ini
> > >>>> @@ -42,6 +42,7 @@ Flow API             =
> > >>>>  Rate limitation      =
> > >>>>  Traffic mirroring    =
> > >>>>  Inline crypto        =
> > >>>> +Inline protocol      =
> > >>>>  CRC offload          =
> > >>>>  VLAN offload         =
> > >>>>  QinQ offload         =
> > >>>> --
> > >>>> 2.7.4
> > >>>
> > >


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-12 10:25           ` Akhil Goyal
@ 2020-02-12 13:30             ` Ferruh Yigit
  2020-02-12 13:48               ` Akhil Goyal
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2020-02-12 13:30 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	John McNamara, Marko Kovacevic

On 2/12/2020 10:25 AM, Akhil Goyal wrote:
> Hi Anoob,
>>>>>
>>>>> Hi Anoob,
>>>>>
>>>>> What is the difference between "Inline crypto" in that document and
>>>>> this "Inline protocol"? Both seems providing same outpout.
>>>>
>>>> [Anoob] Yes. It is partly because the description of "inline crypto" is not
>>> accurate. The feature, "inline crypto" is not ipsec aware but would do crypto
>>> operation in the ipsec. This summary points to the security documentation
>>> for further details and that doc clearly explains the difference between both
>>> modes.
>>>>
>>>>> Is there a way to differentiate them more clearly?
>>>>
>>>> [Anoob] There are two options I can think of, 1. Update the feature
>>>> list to describe the difference between the two. Have a line like,
>>>> 	"As compared to inline crypto, inline protocol will handle the entire
>>> protocol offload in addition to the crypto operation."
>>>> 2. Both inline crypto and inline protocol falls under security. So could even
>>> rename "Inline crypto" to "Inline security offload" and we should be good to
>>> go. Also, under inline protocol, there are various protocols possible. Say,
>>> tomorrow when we add MACSEC support, the same question would arise (as
>>> in whether it's a new feature or would it be under "inline protocol").
> 
> Please re-phrase the description of inline crypto as well so that there is a clear 
> Differentiation between the two modes. Referring to rte_security is not enough.
> 
> It can be something like
> For Inline crypto: An operation defined in rte_security lib to perform only crypto
> Operations of the security protocol while the packet is received at NIC. NIC is not aware
> of the protocol operations. See Security library and PMD documentation for more details.
> 
> For Inline protocol : An operation defined in rte_security lib to perform protocol processing for
> the security protocol (e.g. IPSEC, MACSEC) while the packet is received at the NIC. The NIC is capable
> to understand the security protocol operations. See Security library and PMD documentation for more details.

Since both using the rte_security, for a PMD isn't there a way to say if it is
supporting any one of them or both? If so what do you think documenting it too?

> 
> 
>>>
>>> Hi Anoob,
>>>
>>> These seems security related and I don't know enough to comment if this is
>>> correct thing to do. I have cc'ed a few more people for comment.
>>>
>>> @Akhil, would you mind if I assign this to you?
>>>
>>> Thanks,
>>> ferruh
>>>
>>>>
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Anoob
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
>>>>>>> Sent: Tuesday, December 10, 2019 12:23 PM
>>>>>>> To: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
>>>>>>> <marko.kovacevic@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
>>>>>>> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
>>>>>>> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
>>>>>>> <pathreya@marvell.com>; dev@dpdk.org
>>>>>>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature
>>>>>>> list
>>>>>>>
>>>>>>> Update feature list to include inline protocol offload.
>>>>>>>
>>>>>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>>>>>> ---
>>>>>>>  doc/guides/nics/features.rst         | 18 ++++++++++++++++++
>>>>>>>  doc/guides/nics/features/default.ini |  1 +
>>>>>>>  2 files changed, 19 insertions(+)
>>>>>>>
>>>>>>> diff --git a/doc/guides/nics/features.rst
>>>>>>> b/doc/guides/nics/features.rst index
>>>>>>> 8394a65..f4eb2a9 100644
>>>>>>> --- a/doc/guides/nics/features.rst
>>>>>>> +++ b/doc/guides/nics/features.rst
>>>>>>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline
>>>>>>> IPsec). See Security library and
>>>>>>>    ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>>>>>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>>>>>>>
>>>>>>>
>>>>>>> +.. _nic_features_inline_protocol_doc:
>>>>>>> +
>>>>>>> +Inline protocol
>>>>>>> +---------------
>>>>>>> +
>>>>>>> +Supports inline protocol processing (e.g. inline IPsec). See
>>>>>>> +Security library and
>>>>>>> PMD documentation for more details.
>>>>>>> +
>>>>>>> +* **[uses]       rte_eth_rxconf,rte_eth_rxmode**:
>>>>>>> ``offloads:DEV_RX_OFFLOAD_SECURITY``,
>>>>>>> +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
>>>>>>> ``offloads:DEV_TX_OFFLOAD_SECURITY``.
>>>>>>> +* **[implements] rte_security_ops**: ``session_create``,
>>>>>>> +``session_update``,
>>>>>>> +  ``session_stats_get``, ``session_destroy``,
>>>>>>> +``set_pkt_metadata``, ``get_userdata``,
>>>>>>> +  ``capabilities_get``.
>>>>>>> +* **[provides] rte_eth_dev_info**:
>>>>>>>
>>>>>
>>> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
>>>>>>> +
>>>>>
>>> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
>>>>>>> +* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
>>>>>>> +  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``,
>>>>>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
>>>>>>> +
>>>>>>> +
>>>>>>>  .. _nic_features_crc_offload:
>>>>>>>
>>>>>>>  CRC offload
>>>>>>> diff --git a/doc/guides/nics/features/default.ini
>>>>>>> b/doc/guides/nics/features/default.ini
>>>>>>> index 91ec619..4d0ad32 100644
>>>>>>> --- a/doc/guides/nics/features/default.ini
>>>>>>> +++ b/doc/guides/nics/features/default.ini
>>>>>>> @@ -42,6 +42,7 @@ Flow API             =
>>>>>>>  Rate limitation      =
>>>>>>>  Traffic mirroring    =
>>>>>>>  Inline crypto        =
>>>>>>> +Inline protocol      =
>>>>>>>  CRC offload          =
>>>>>>>  VLAN offload         =
>>>>>>>  QinQ offload         =
>>>>>>> --
>>>>>>> 2.7.4
>>>>>>
>>>>
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-12 13:30             ` Ferruh Yigit
@ 2020-02-12 13:48               ` Akhil Goyal
  2020-02-12 13:53                 ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Akhil Goyal @ 2020-02-12 13:48 UTC (permalink / raw)
  To: Ferruh Yigit, Anoob Joseph
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	John McNamara, Marko Kovacevic

Hi Ferruh,
> 
> 
> Since both using the rte_security, for a PMD isn't there a way to say if it is
> supporting any one of them or both? If so what do you think documenting it too?
> 
I think that is mentioned in the rte_security capabilities about the action types
Which are supported by the driver. One of the dev->security_ctx->ops is to get the security
Capabilities which will return the supported action type by the PMD.

I am not sure if we can add that here or not. It is your call.

- Akhil




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-12 13:48               ` Akhil Goyal
@ 2020-02-12 13:53                 ` Ferruh Yigit
  2020-02-12 14:10                   ` Akhil Goyal
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2020-02-12 13:53 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	John McNamara, Marko Kovacevic

On 2/12/2020 1:48 PM, Akhil Goyal wrote:
> Hi Ferruh,
>>
>>
>> Since both using the rte_security, for a PMD isn't there a way to say if it is
>> supporting any one of them or both? If so what do you think documenting it too?
>>
> I think that is mentioned in the rte_security capabilities about the action types
> Which are supported by the driver. One of the dev->security_ctx->ops is to get the security
> Capabilities which will return the supported action type by the PMD.
> 
> I am not sure if we can add that here or not. It is your call.
> 

I think it make sense to document action types needs to be supported to claim
that the feature is supported, but most probably you will judge better on the
matter.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list
  2020-02-12 13:53                 ` Ferruh Yigit
@ 2020-02-12 14:10                   ` Akhil Goyal
  0 siblings, 0 replies; 16+ messages in thread
From: Akhil Goyal @ 2020-02-12 14:10 UTC (permalink / raw)
  To: Ferruh Yigit, Anoob Joseph
  Cc: Jerin Jacob Kollanukkaran, Narayana Prasad Raju Athreya, dev,
	Konstantin Ananyev, Hemant Agrawal, Fan Zhang, Fiona Trahe,
	John McNamara, Marko Kovacevic


> On 2/12/2020 1:48 PM, Akhil Goyal wrote:
> > Hi Ferruh,
> >>
> >>
> >> Since both using the rte_security, for a PMD isn't there a way to say if it is
> >> supporting any one of them or both? If so what do you think documenting it
> too?
> >>
> > I think that is mentioned in the rte_security capabilities about the action types
> > Which are supported by the driver. One of the dev->security_ctx->ops is to get
> the security
> > Capabilities which will return the supported action type by the PMD.
> >
> > I am not sure if we can add that here or not. It is your call.
> >
> 
> I think it make sense to document action types needs to be supported to claim
> that the feature is supported, but most probably you will judge better on the
> matter.

If we can add specifics of security in ethernet feature definition,
Then probably we can add 
**[provides]   rte_security_ops, capabilities_get**: `` action: RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO ``

For inline crypto
And
**[provides]   rte_security_ops, capabilities_get**: `` action: RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL`` 

Please check my syntax if it is not correct.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* [dpdk-dev] [PATCH v2] doc: add inline protocol in feature list
  2019-12-10  6:53 [dpdk-dev] [PATCH] doc: add inline protocol in feature list Anoob Joseph
  2020-01-21  5:40 ` Anoob Joseph
@ 2020-02-17 15:22 ` " Anoob Joseph
  2020-02-17 15:39   ` [dpdk-dev] [PATCH v3] " Anoob Joseph
  1 sibling, 1 reply; 16+ messages in thread
From: Anoob Joseph @ 2020-02-17 15:22 UTC (permalink / raw)
  To: Akhil Goyal, Ferruh Yigit, Thomas Monjalon
  Cc: Anoob Joseph, Jerin Jacob, Narayana Prasad, dev

Update feature list to include inline protocol offload.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 doc/guides/nics/features.rst           | 27 ++++++++++++++++++++++++++-
 doc/guides/nics/features/default.ini   |  1 +
 doc/guides/nics/features/octeontx2.ini |  1 +
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 8394a65..edd21c4 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -421,7 +421,9 @@ Supports adding traffic mirroring rules.
 Inline crypto
 -------------
 
-Supports inline crypto processing (e.g. inline IPsec). See Security library and PMD documentation for more details.
+Supports inline crypto processing defined by rte_security library to perform crypto
+operations of security protocol while packet is received in NIC. NIC is not aware
+of protocol operations. See Security library and PMD documentation for more details.
 
 * **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
 * **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
@@ -431,6 +433,29 @@ Supports inline crypto processing (e.g. inline IPsec). See Security library and
   ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
 * **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
   ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO``
+
+
+.. _nic_features_inline_protocol_doc:
+
+Inline protocol
+---------------
+
+Supports inline protocol processing defined by rte_security library to perform
+protocol processing for the security protocol (e.g. IPsec, MACSEC) while the
+packet is received at NIC. The NIC is capable of understanding the security
+protocol operations. See security library and PMD documentation for more details.
+
+* **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``,
+  ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL``
 
 
 .. _nic_features_crc_offload:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 91ec619..4d0ad32 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -42,6 +42,7 @@ Flow API             =
 Rate limitation      =
 Traffic mirroring    =
 Inline crypto        =
+Inline protocol      =
 CRC offload          =
 VLAN offload         =
 QinQ offload         =
diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini
index c2a3f47b..473fe56 100644
--- a/doc/guides/nics/features/octeontx2.ini
+++ b/doc/guides/nics/features/octeontx2.ini
@@ -27,6 +27,7 @@ RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 Inner RSS            = Y
+Inline protocol      = Y
 VLAN filter          = Y
 Flow control         = Y
 Flow API             = Y
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list
  2020-02-17 15:22 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
@ 2020-02-17 15:39   ` " Anoob Joseph
  2020-02-18  7:40     ` Akhil Goyal
  0 siblings, 1 reply; 16+ messages in thread
From: Anoob Joseph @ 2020-02-17 15:39 UTC (permalink / raw)
  To: Akhil Goyal, Ferruh Yigit, Thomas Monjalon
  Cc: Anoob Joseph, Jerin Jacob, Narayana Prasad, dev

Update feature list to include inline protocol offload.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
v3
* Added inline protocol in octeontx2_vf.ini

v2
* Reworded doc following suggestions from Akhil

 doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
 doc/guides/nics/features/default.ini      |  1 +
 doc/guides/nics/features/octeontx2.ini    |  1 +
 doc/guides/nics/features/octeontx2_vf.ini |  1 +
 4 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 8394a65..edd21c4 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -421,7 +421,9 @@ Supports adding traffic mirroring rules.
 Inline crypto
 -------------
 
-Supports inline crypto processing (e.g. inline IPsec). See Security library and PMD documentation for more details.
+Supports inline crypto processing defined by rte_security library to perform crypto
+operations of security protocol while packet is received in NIC. NIC is not aware
+of protocol operations. See Security library and PMD documentation for more details.
 
 * **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
 * **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
@@ -431,6 +433,29 @@ Supports inline crypto processing (e.g. inline IPsec). See Security library and
   ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
 * **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
   ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO``
+
+
+.. _nic_features_inline_protocol_doc:
+
+Inline protocol
+---------------
+
+Supports inline protocol processing defined by rte_security library to perform
+protocol processing for the security protocol (e.g. IPsec, MACSEC) while the
+packet is received at NIC. The NIC is capable of understanding the security
+protocol operations. See security library and PMD documentation for more details.
+
+* **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``,
+  ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL``
 
 
 .. _nic_features_crc_offload:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 91ec619..4d0ad32 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -42,6 +42,7 @@ Flow API             =
 Rate limitation      =
 Traffic mirroring    =
 Inline crypto        =
+Inline protocol      =
 CRC offload          =
 VLAN offload         =
 QinQ offload         =
diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini
index c2a3f47b..473fe56 100644
--- a/doc/guides/nics/features/octeontx2.ini
+++ b/doc/guides/nics/features/octeontx2.ini
@@ -27,6 +27,7 @@ RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 Inner RSS            = Y
+Inline protocol      = Y
 VLAN filter          = Y
 Flow control         = Y
 Flow API             = Y
diff --git a/doc/guides/nics/features/octeontx2_vf.ini b/doc/guides/nics/features/octeontx2_vf.ini
index a70d195..96ef098 100644
--- a/doc/guides/nics/features/octeontx2_vf.ini
+++ b/doc/guides/nics/features/octeontx2_vf.ini
@@ -21,6 +21,7 @@ RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 Inner RSS            = Y
+Inline protocol      = Y
 VLAN filter          = Y
 Flow API             = Y
 Jumbo frame          = Y
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list
  2020-02-17 15:39   ` [dpdk-dev] [PATCH v3] " Anoob Joseph
@ 2020-02-18  7:40     ` Akhil Goyal
  2020-02-18  9:28       ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Akhil Goyal @ 2020-02-18  7:40 UTC (permalink / raw)
  To: Anoob Joseph, Ferruh Yigit, Thomas Monjalon
  Cc: Jerin Jacob, Narayana Prasad, dev


> 
> Update feature list to include inline protocol offload.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> v3
> * Added inline protocol in octeontx2_vf.ini
> 
> v2
> * Reworded doc following suggestions from Akhil
> 
>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>  doc/guides/nics/features/default.ini      |  1 +
>  doc/guides/nics/features/octeontx2.ini    |  1 +
>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>  4 files changed, 29 insertions(+), 1 deletion(-)
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Ferruh,
Do you want me to take this patch on crypto tree or you would be taking it.

Regards,
Akhil

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list
  2020-02-18  7:40     ` Akhil Goyal
@ 2020-02-18  9:28       ` Ferruh Yigit
  2020-02-18 10:02         ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2020-02-18  9:28 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph, Thomas Monjalon
  Cc: Jerin Jacob, Narayana Prasad, dev

On 2/18/2020 7:40 AM, Akhil Goyal wrote:
> 
>>
>> Update feature list to include inline protocol offload.
>>
>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>> v3
>> * Added inline protocol in octeontx2_vf.ini
>>
>> v2
>> * Reworded doc following suggestions from Akhil
>>
>>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>>  doc/guides/nics/features/default.ini      |  1 +
>>  doc/guides/nics/features/octeontx2.ini    |  1 +
>>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>>  4 files changed, 29 insertions(+), 1 deletion(-)
>>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Ferruh,
> Do you want me to take this patch on crypto tree or you would be taking it.
> 

Thanks Akhil, both are OK for me, but there are already a few patches merged in
next-net so let me get this one too to simply merging to main repo.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list
  2020-02-18  9:28       ` Ferruh Yigit
@ 2020-02-18 10:02         ` Ferruh Yigit
  0 siblings, 0 replies; 16+ messages in thread
From: Ferruh Yigit @ 2020-02-18 10:02 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph, Thomas Monjalon
  Cc: Jerin Jacob, Narayana Prasad, dev

On 2/18/2020 9:28 AM, Ferruh Yigit wrote:
> On 2/18/2020 7:40 AM, Akhil Goyal wrote:
>>
>>>
>>> Update feature list to include inline protocol offload.
>>>
>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>> ---
>>> v3
>>> * Added inline protocol in octeontx2_vf.ini
>>>
>>> v2
>>> * Reworded doc following suggestions from Akhil
>>>
>>>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>>>  doc/guides/nics/features/default.ini      |  1 +
>>>  doc/guides/nics/features/octeontx2.ini    |  1 +
>>>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>>>  4 files changed, 29 insertions(+), 1 deletion(-)
>>>
>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>
>> Ferruh,
>> Do you want me to take this patch on crypto tree or you would be taking it.
>>
> 
> Thanks Akhil, both are OK for me, but there are already a few patches merged in
> next-net so let me get this one too to simply merging to main repo.
> 

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10  6:53 [dpdk-dev] [PATCH] doc: add inline protocol in feature list Anoob Joseph
2020-01-21  5:40 ` Anoob Joseph
2020-01-21 16:12   ` Ferruh Yigit
2020-01-22  9:47     ` [dpdk-dev] [EXT] " Anoob Joseph
2020-02-04 14:35       ` Ferruh Yigit
2020-02-10  5:44         ` Anoob Joseph
2020-02-12 10:25           ` Akhil Goyal
2020-02-12 13:30             ` Ferruh Yigit
2020-02-12 13:48               ` Akhil Goyal
2020-02-12 13:53                 ` Ferruh Yigit
2020-02-12 14:10                   ` Akhil Goyal
2020-02-17 15:22 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2020-02-17 15:39   ` [dpdk-dev] [PATCH v3] " Anoob Joseph
2020-02-18  7:40     ` Akhil Goyal
2020-02-18  9:28       ` Ferruh Yigit
2020-02-18 10:02         ` Ferruh Yigit

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox