From: Bruce Richardson <bruce.richardson@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [PATCH 2/3] buildtools: make AVX512 check script portable
Date: Mon, 15 Nov 2021 09:28:46 +0000 [thread overview]
Message-ID: <YZIoTgv17jRLU32g@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20211112214826.333853-3-dmitry.kozliuk@gmail.com>
On Sat, Nov 13, 2021 at 12:48:25AM +0300, Dmitry Kozlyuk wrote:
> buildtools/binutils-avx512-check.sh was Unix-only
> and could not be used in cross builds:
> 1) written in shell;
> 2) used the assembler binary that may be missing,
> e.g. when building on Windows with LLVM;
> 3) located the assembler as ${AS:-as} and referenced objdump,
> but those binaries may be overridden via --cross-file.
>
> Rewrite the script in Python.
> Use the C compiler for the check.
> Locate objdump and the C compiler using Meson.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> buildtools/binutils-avx512-check.py | 21 +++++++++++++++++++++
> buildtools/binutils-avx512-check.sh | 16 ----------------
> buildtools/meson.build | 4 +++-
> 3 files changed, 24 insertions(+), 17 deletions(-)
> create mode 100644 buildtools/binutils-avx512-check.py
> delete mode 100755 buildtools/binutils-avx512-check.sh
>
> diff --git a/buildtools/binutils-avx512-check.py b/buildtools/binutils-avx512-check.py
> new file mode 100644
> index 0000000000..a4e14f3593
> --- /dev/null
> +++ b/buildtools/binutils-avx512-check.py
> @@ -0,0 +1,21 @@
> +#! /usr/bin/env python3
> +# SPDX-License-Identitifer: BSD-3-Clause
> +# Copyright(c) 2020 Intel Corporation
> +
This probably should have your own copyright instead of or alongside the
Intel one, since this is a rewrite.
Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-11-15 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 21:48 [PATCH 0/3] config/x86: improve AVX512 availability check Dmitry Kozlyuk
2021-11-12 21:48 ` [PATCH 1/3] config/x86: skip GNU binutils bug check for LLVM Dmitry Kozlyuk
2021-11-15 9:17 ` Bruce Richardson
2021-11-12 21:48 ` [PATCH 2/3] buildtools: make AVX512 check script portable Dmitry Kozlyuk
2021-11-15 9:28 ` Bruce Richardson [this message]
2021-11-12 21:48 ` [PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49 Dmitry Kozlyuk
2021-11-15 9:30 ` Bruce Richardson
2021-11-17 8:42 ` [PATCH 0/3] config/x86: improve AVX512 availability check Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIoTgv17jRLU32g@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).