From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jakub Grajciar <jgrajcia@cisco.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Rosen Xu <rosen.xu@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ajit Khaparde <ajit.khaparde@broadcom.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/memif: fix driver init with default MTU
Date: Wed, 27 Oct 2021 09:27:43 +0100 [thread overview]
Message-ID: <b11d9ec4-15d6-eb3e-359e-badf8d0bd0b0@intel.com> (raw)
In-Reply-To: <20211026134724.5478f4c1@hermes.local>
On 10/26/2021 9:47 PM, Stephen Hemminger wrote:
> On Tue, 26 Oct 2021 16:38:01 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
>> index 8cec493ffdb9..cbc99067c1c8 100644
>> --- a/drivers/net/memif/rte_eth_memif.c
>> +++ b/drivers/net/memif/rte_eth_memif.c
>> @@ -195,7 +195,7 @@ static int
>> memif_dev_info(struct rte_eth_dev *dev __rte_unused, struct rte_eth_dev_info *dev_info)
>> {
>> dev_info->max_mac_addrs = 1;
>> - dev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN;
>> + dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_LEN;
>
> The cast is not necessary here. Not sure why the original code had it?
>
ack.
I will send a new version to remove the cast, since touching those lines.
next prev parent reply other threads:[~2021-10-27 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:38 [dpdk-dev] [PATCH 1/2] net/af_packet: " Ferruh Yigit
2021-10-26 15:38 ` [dpdk-dev] [PATCH 2/2] net/memif: " Ferruh Yigit
2021-10-26 15:45 ` David Christensen
2021-10-26 20:47 ` Stephen Hemminger
2021-10-27 8:27 ` Ferruh Yigit [this message]
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Ferruh Yigit
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 2/2] net/memif: " Ferruh Yigit
2021-10-27 15:13 ` Andrew Rybchenko
2021-10-27 15:12 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Andrew Rybchenko
2021-10-27 15:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11d9ec4-15d6-eb3e-359e-badf8d0bd0b0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=rosen.xu@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).