From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"John W. Linville" <linville@tuxdriver.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
"Konstantin Ananyev" <konstantin.ananyev@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Huisong Li <lihuisong@huawei.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/af_packet: fix driver init with default MTU
Date: Wed, 27 Oct 2021 16:51:24 +0100 [thread overview]
Message-ID: <cff52b05-c66a-f444-9a08-bf82018a9756@intel.com> (raw)
In-Reply-To: <1bf9fa5c-4b7c-6b96-5723-e3d8af958bdb@oktetlabs.ru>
On 10/27/2021 4:12 PM, Andrew Rybchenko wrote:
> On 10/27/21 12:14 PM, Ferruh Yigit wrote:
>> Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length,
>> which doesn't include FCS (4 bytes CRC). But ethdev by default uses
>> frame size with FCS when application doesn't define any explicit value.
>>
>> As a result device configuration fails because device is tried to be
>> configured with a frame size length that is bigger than what device
>> reported as supported. Device reports as max supported frame size is
>> 1514 but configured value is 1518.
>>
>> Instead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the
>> driver to report the max supported frame size, this matches to the
>> initial intention.
>>
>> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>>
>> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Series applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-10-27 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:38 [dpdk-dev] [PATCH " Ferruh Yigit
2021-10-26 15:38 ` [dpdk-dev] [PATCH 2/2] net/memif: " Ferruh Yigit
2021-10-26 15:45 ` David Christensen
2021-10-26 20:47 ` Stephen Hemminger
2021-10-27 8:27 ` Ferruh Yigit
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Ferruh Yigit
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 2/2] net/memif: " Ferruh Yigit
2021-10-27 15:13 ` Andrew Rybchenko
2021-10-27 15:12 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Andrew Rybchenko
2021-10-27 15:51 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff52b05-c66a-f444-9a08-bf82018a9756@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=lihuisong@huawei.com \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).