From: Ilya Maximets <i.maximets@samsung.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Aaron Conole <aconole@redhat.com>,
Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] meson: don't check dependencies for tests if not required
Date: Thu, 30 May 2019 15:06:17 +0300 [thread overview]
Message-ID: <e4a198e3-6f63-3b5f-0439-c2a3f04f66fa@samsung.com> (raw)
In-Reply-To: <20190530115558.GA1279@bricha3-MOBL.ger.corp.intel.com>
On 30.05.2019 14:55, Bruce Richardson wrote:
> On Wed, May 29, 2019 at 07:39:57PM +0300, Ilya Maximets wrote:
>> Don't need to check dependencies if test apps will not be built anyway.
>>
>> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>> ---
>> app/test/meson.build | 38 +++++++++++++++++++-------------------
>> 1 file changed, 19 insertions(+), 19 deletions(-)
>>
> Agree with the idea.
>
> Would this work as a shorter alternative placed at the top of the file?
>
> if not get_option('tests')
> subdir_done()
> endif
This looks good to me.
However, the resulted patch will be much larger because we'll have to
shift most of it to the left. If it's OK, I'll prepare v2 with this change.
What do you think?
Best regards, Ilya Maximets.
next prev parent reply other threads:[~2019-05-30 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190529164004eucas1p154674b298c0b906f663ae04ebfcbc33c@eucas1p1.samsung.com>
2019-05-29 16:39 ` [dpdk-dev] [PATCH 0/2] Make meson configurable Ilya Maximets
[not found] ` <CGME20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b@eucas1p2.samsung.com>
2019-05-29 16:39 ` [dpdk-dev] [PATCH 1/2] meson: don't check dependencies for tests if not required Ilya Maximets
2019-05-30 11:55 ` Bruce Richardson
2019-05-30 12:06 ` Ilya Maximets [this message]
2019-05-30 12:20 ` Bruce Richardson
[not found] ` <CGME20190530123840eucas1p216e6df3737209db26e2b0ce678ba9da4@eucas1p2.samsung.com>
2019-05-30 12:38 ` [dpdk-dev] [PATCH v2] " Ilya Maximets
2019-05-30 12:48 ` Bruce Richardson
2019-06-05 16:48 ` Thomas Monjalon
2019-05-30 13:08 ` Aaron Conole
2019-05-30 13:34 ` Luca Boccassi
[not found] ` <CGME20190529164009eucas1p289f1dcf87012ecf049efc8eee2c2ea9d@eucas1p2.samsung.com>
2019-05-29 16:39 ` [dpdk-dev] [PATCH 2/2] meson: make build configurable Ilya Maximets
2019-05-29 20:15 ` Michael Santana Francisco
2019-05-30 9:22 ` Ilya Maximets
2019-05-29 20:37 ` Luca Boccassi
2019-05-30 10:03 ` Ilya Maximets
2019-05-30 11:06 ` Luca Boccassi
2019-05-30 11:59 ` Ilya Maximets
2019-05-30 13:30 ` Luca Boccassi
2019-05-30 10:22 ` Bruce Richardson
2019-05-30 11:46 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a198e3-6f63-3b5f-0439-c2a3f04f66fa@samsung.com \
--to=i.maximets@samsung.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).