DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] ci: do not dump error logs in GHA containers
@ 2022-04-26  7:09 David Marchand
  2022-04-26  7:18 ` David Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2022-04-26  7:09 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

On error, the build logs are displayed in GHA console and logs unless
the GITHUB_WORKFLOW env variable is set.
However, containers in GHA do not automatically inherit this variable.
We could pass this variable in the container environment, but in the
end, dumping those logs is only for Travis which we don't really care
about anymore.

Let's make the linux-build.sh more generic and dump logs from Travis
yaml itself.

Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .ci/linux-build.sh | 19 -------------------
 .travis.yml        |  4 ++++
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 774a1441bf..6a937611fa 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -3,25 +3,6 @@
 # Builds are run as root in containers, no need for sudo
 [ "$(id -u)" != '0' ] || alias sudo=
 
-on_error() {
-    if [ $? = 0 ]; then
-        exit
-    fi
-    FILES_TO_PRINT="build/meson-logs/testlog.txt"
-    FILES_TO_PRINT="$FILES_TO_PRINT build/.ninja_log"
-    FILES_TO_PRINT="$FILES_TO_PRINT build/meson-logs/meson-log.txt"
-    FILES_TO_PRINT="$FILES_TO_PRINT build/gdb.log"
-
-    for pr_file in $FILES_TO_PRINT; do
-        if [ -e "$pr_file" ]; then
-            cat "$pr_file"
-        fi
-    done
-}
-# We capture the error logs as artifacts in Github Actions, no need to dump
-# them via a EXIT handler.
-[ -n "$GITHUB_WORKFLOW" ] || trap on_error EXIT
-
 install_libabigail() {
     version=$1
     instdir=$2
diff --git a/.travis.yml b/.travis.yml
index 5f46dccb54..e4e70fa560 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,6 +38,10 @@ _doc_packages: &doc_packages
 
 before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
 script: ./.ci/${TRAVIS_OS_NAME}-build.sh
+after_failure:
+- [ ! -e build/meson-logs/testlog.txt ] || cat build/meson-logs/testlog.txt
+- [ ! -e build/.ninja_log ] || cat build/.ninja_log
+- [ ! -e build/meson-logs/meson-log.txt ] || cat build/meson-logs/meson-log.txt
 
 env:
   global:
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ci: do not dump error logs in GHA containers
  2022-04-26  7:09 [PATCH] ci: do not dump error logs in GHA containers David Marchand
@ 2022-04-26  7:18 ` David Marchand
  2022-04-26 15:05   ` Aaron Conole
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2022-04-26  7:18 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

On Tue, Apr 26, 2022 at 9:09 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On error, the build logs are displayed in GHA console and logs unless
> the GITHUB_WORKFLOW env variable is set.
> However, containers in GHA do not automatically inherit this variable.
> We could pass this variable in the container environment, but in the
> end, dumping those logs is only for Travis which we don't really care
> about anymore.
>
> Let's make the linux-build.sh more generic and dump logs from Travis
> yaml itself.
>
> Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

TBH, I did not test Travis by lack of interest (plus I don't want to
be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.

Opinions?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ci: do not dump error logs in GHA containers
  2022-04-26  7:18 ` David Marchand
@ 2022-04-26 15:05   ` Aaron Conole
  2022-04-28  9:51     ` David Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: Aaron Conole @ 2022-04-26 15:05 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Michael Santana

David Marchand <david.marchand@redhat.com> writes:

> On Tue, Apr 26, 2022 at 9:09 AM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On error, the build logs are displayed in GHA console and logs unless
>> the GITHUB_WORKFLOW env variable is set.
>> However, containers in GHA do not automatically inherit this variable.
>> We could pass this variable in the container environment, but in the
>> end, dumping those logs is only for Travis which we don't really care
>> about anymore.
>>
>> Let's make the linux-build.sh more generic and dump logs from Travis
>> yaml itself.
>>
>> Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> TBH, I did not test Travis by lack of interest (plus I don't want to
> be bothered with their ui / credit stuff).
> We could consider dropping Travis in the near future.
>
> Opinions?

I think it makes sense.  We haven't had travis reports in a while
because their credit system made it impossible to use.  We had kept it
around for users of travis, but at this point, I think most people have
migrated to GHA.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ci: do not dump error logs in GHA containers
  2022-04-26 15:05   ` Aaron Conole
@ 2022-04-28  9:51     ` David Marchand
  2022-04-29  4:16       ` Honnappa Nagarahalli
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2022-04-28  9:51 UTC (permalink / raw)
  To: Honnappa Nagarahalli; +Cc: dev, Michael Santana, Thomas Monjalon, Aaron Conole

On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> > TBH, I did not test Travis by lack of interest (plus I don't want to
> > be bothered with their ui / credit stuff).
> > We could consider dropping Travis in the near future.
> >
> > Opinions?
>
> I think it makes sense.  We haven't had travis reports in a while
> because their credit system made it impossible to use.  We had kept it
> around for users of travis, but at this point, I think most people have
> migrated to GHA.
>

Honnappa, do you see an issue if we stop maintaining the Travis
configuration in the DPDK repo?

Thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] ci: do not dump error logs in GHA containers
  2022-04-28  9:51     ` David Marchand
@ 2022-04-29  4:16       ` Honnappa Nagarahalli
  2022-04-29 20:12         ` Aaron Conole
  0 siblings, 1 reply; 6+ messages in thread
From: Honnappa Nagarahalli @ 2022-04-29  4:16 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Michael Santana, thomas, Aaron Conole, nd, nd

<snip>

> 
> On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole <aconole@redhat.com>
> wrote:
> > >
> > > TBH, I did not test Travis by lack of interest (plus I don't want to
> > > be bothered with their ui / credit stuff).
> > > We could consider dropping Travis in the near future.
> > >
> > > Opinions?
> >
> > I think it makes sense.  We haven't had travis reports in a while
> > because their credit system made it impossible to use.  We had kept it
> > around for users of travis, but at this point, I think most people
> > have migrated to GHA.
> >
> 
> Honnappa, do you see an issue if we stop maintaining the Travis configuration
> in the DPDK repo?
I do not see much of an issue from Arm side. The machines in the UNH lab provide the cover.

I am wondering that this might still be useful for individual developers who I believe are not affected by the Travis's credit system (I am not sure on this). 

> 
> Thanks.
> 
> --
> David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ci: do not dump error logs in GHA containers
  2022-04-29  4:16       ` Honnappa Nagarahalli
@ 2022-04-29 20:12         ` Aaron Conole
  0 siblings, 0 replies; 6+ messages in thread
From: Aaron Conole @ 2022-04-29 20:12 UTC (permalink / raw)
  To: Honnappa Nagarahalli; +Cc: David Marchand, dev, Michael Santana, thomas, nd

Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> writes:

> <snip>
>
>> 
>> On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole <aconole@redhat.com>
>> wrote:
>> > >
>> > > TBH, I did not test Travis by lack of interest (plus I don't want to
>> > > be bothered with their ui / credit stuff).
>> > > We could consider dropping Travis in the near future.
>> > >
>> > > Opinions?
>> >
>> > I think it makes sense.  We haven't had travis reports in a while
>> > because their credit system made it impossible to use.  We had kept it
>> > around for users of travis, but at this point, I think most people
>> > have migrated to GHA.
>> >
>> 
>> Honnappa, do you see an issue if we stop maintaining the Travis configuration
>> in the DPDK repo?
> I do not see much of an issue from Arm side. The machines in the UNH lab provide the cover.
>
> I am wondering that this might still be useful for individual
> developers who I believe are not affected by the Travis's credit
> system (I am not sure on this).

I don't use travis now that GHA "just works" for my private
repositories.  I would guess most developers will prefer GHA anyway.

>> 
>> Thanks.
>> 
>> --
>> David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-29 20:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26  7:09 [PATCH] ci: do not dump error logs in GHA containers David Marchand
2022-04-26  7:18 ` David Marchand
2022-04-26 15:05   ` Aaron Conole
2022-04-28  9:51     ` David Marchand
2022-04-29  4:16       ` Honnappa Nagarahalli
2022-04-29 20:12         ` Aaron Conole

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).