[dts] [PATCH] packetgen: Corrected return values and parameters of loss function

[dts] [PATCH] packetgen: Corrected return values and parameters of loss function

[Phanendra Vukkisala]

From: pvukkisala <pvukkisala@marvell.com>

Updated return values of loss function of packetgen to match with IXIA loss function
Removed passing delay argument to packetgen loss as it is not required.

Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
 framework/etgen.py  |    2 +-
 framework/tester.py |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/etgen.py b/framework/etgen.py
index 2856a28..6c85384 100644
--- a/framework/etgen.py
+++ b/framework/etgen.py
@@ -158,7 +158,7 @@ class SoftwarePacketGenerator():
     def loss(self, portList, ratePercent):
         (bps_rx, bps_tx, _) = self.packet_generator(portList, ratePercent)
         assert bps_tx != 0
-        return (float(bps_tx) - float(bps_rx)) / float(bps_tx)
+        return (float(bps_tx) - float(bps_rx)) / float(bps_tx), float(bps_tx), float(bps_rx)
 
 
 class IxiaPacketGenerator(SSHConnection):
diff --git a/framework/tester.py b/framework/tester.py
index 4e651a1..e1416d8 100755
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -535,7 +535,7 @@ class Tester(Crb):
         elif not self.check_port_list(portList):
             self.logger.warning("exception by mixed port types")
             return None
-        return self.packet_gen.loss(portList, ratePercent, delay)
+        return self.packet_gen.loss(portList, ratePercent)
 
     def traffic_generator_latency(self, portList, ratePercent=100, delay=5):
         """
-- 
1.7.9.5

Re: [dts] [PATCH] packetgen: Corrected return values and parameters of loss function

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 17, 2019 3:26 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] packetgen: Corrected return values and parameters of
> loss function
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> Updated return values of loss function of packetgen to match with IXIA loss
> function Removed passing delay argument to packetgen loss as it is not required.
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  framework/etgen.py  |    2 +-
>  framework/tester.py |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/etgen.py b/framework/etgen.py index 2856a28..6c85384
> 100644
> --- a/framework/etgen.py
> +++ b/framework/etgen.py
> @@ -158,7 +158,7 @@ class SoftwarePacketGenerator():
>      def loss(self, portList, ratePercent):
>          (bps_rx, bps_tx, _) = self.packet_generator(portList, ratePercent)
>          assert bps_tx != 0
> -        return (float(bps_tx) - float(bps_rx)) / float(bps_tx)
> +        return (float(bps_tx) - float(bps_rx)) / float(bps_tx),
> + float(bps_tx), float(bps_rx)
> 
> 
>  class IxiaPacketGenerator(SSHConnection):
> diff --git a/framework/tester.py b/framework/tester.py index
> 4e651a1..e1416d8 100755
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -535,7 +535,7 @@ class Tester(Crb):
>          elif not self.check_port_list(portList):
>              self.logger.warning("exception by mixed port types")
>              return None
> -        return self.packet_gen.loss(portList, ratePercent, delay)
> +        return self.packet_gen.loss(portList, ratePercent)
> 
>      def traffic_generator_latency(self, portList, ratePercent=100, delay=5):
>          """
> --
> 1.7.9.5