test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] framework/dut.py:correct the code defect.
@ 2019-11-05  8:11 Jianwei Mei
  2019-11-05  9:30 ` Mei, JianweiX
  0 siblings, 1 reply; 2+ messages in thread
From: Jianwei Mei @ 2019-11-05  8:11 UTC (permalink / raw)
  To: dts; +Cc: Jianwei Mei

code logic error and modify it.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 54ff28b..99a02d5 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -144,7 +144,7 @@ class Dut(Crb):
                             port_option = config['port_options'][port]
                             w_pci_list.append('-w %s,%s' % (self.ports_info[config['ports'].index(port)]['pci'], port_option))
                         else:
-                            w_pci_list = ['-w %s' % pci for pci in config['ports']]
+                            w_pci_list.append('-w %s' % self.ports_info[config['ports'].index(port)]['pci'])
             w_pci_str = ' '.join(w_pci_list)
 
             # deal with black ports
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] framework/dut.py:correct the code defect.
  2019-11-05  8:11 [dts] [PATCH V1] framework/dut.py:correct the code defect Jianwei Mei
@ 2019-11-05  9:30 ` Mei, JianweiX
  0 siblings, 0 replies; 2+ messages in thread
From: Mei, JianweiX @ 2019-11-05  9:30 UTC (permalink / raw)
  To: Tu, Lijuan, dts

Hi Lijuan,
Please ignore this patch, because there is a patch v2 submitted. 

-----Original Message-----
From: Mei, JianweiX 
Sent: Tuesday, November 5, 2019 4:12 PM
To: dts@dpdk.org
Cc: Mei, JianweiX <jianweix.mei@intel.com>
Subject: [dts][PATCH V1] framework/dut.py:correct the code defect.

code logic error and modify it.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py index 54ff28b..99a02d5 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -144,7 +144,7 @@ class Dut(Crb):
                             port_option = config['port_options'][port]
                             w_pci_list.append('-w %s,%s' % (self.ports_info[config['ports'].index(port)]['pci'], port_option))
                         else:
-                            w_pci_list = ['-w %s' % pci for pci in config['ports']]
+                            w_pci_list.append('-w %s' % 
+ self.ports_info[config['ports'].index(port)]['pci'])
             w_pci_str = ' '.join(w_pci_list)
 
             # deal with black ports
--
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05  8:11 [dts] [PATCH V1] framework/dut.py:correct the code defect Jianwei Mei
2019-11-05  9:30 ` Mei, JianweiX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox