test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues
@ 2019-01-08  4:28 Xueqin Lin
  2019-01-15  1:07 ` Zhu, WenhuiX
  2019-01-15  4:55 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xueqin Lin @ 2019-01-08  4:28 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin

From: "xueqin.lin" <xueqin.lin@intel.com>

1. Dynamic flowtype could support FVL nic, not only fortville_25g.
2. RSS works also could receive packets from queue 0.
3. Restore original profile instead of core reset to avoid exception. 

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_dynamic_flowtype.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_dynamic_flowtype.py b/tests/TestSuite_dynamic_flowtype.py
index 05e6bcb..4652955 100644
--- a/tests/TestSuite_dynamic_flowtype.py
+++ b/tests/TestSuite_dynamic_flowtype.py
@@ -12,7 +12,7 @@ VM_CORES_MASK = 'all'
 class TestDynamicFlowtype(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'],
+        self.verify('fortville' in self.nic,
                     'dynamic flow type mapping can not support %s nic'
                     % self.nic)
         ports = self.dut.get_ports()
@@ -61,7 +61,7 @@ class TestDynamicFlowtype(TestCase):
         self.dut_testpmd.execute_cmd('port stop all')
         time.sleep(1)
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo,/tmp/gtp.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
                     "Failed to load ddp profile!!!")
@@ -179,8 +179,6 @@ class TestDynamicFlowtype(TestCase):
             self.tester.scapy_execute()
             out = self.dut.get_session_output(timeout=2)
             if match_opt == 'matched':
-                self.verify("port 0/queue 0" not in out,
-                            "Failed to receive packet in rss queue!!!")
                 self.verify("PKT_RX_RSS_HASH" in out,
                             "Failed to receive packet in rss queue!!!")
             elif match_opt == 'not matched':
@@ -280,10 +278,17 @@ class TestDynamicFlowtype(TestCase):
         self.dynamic_flowtype_test(pctype=25, flowtype=25, reset=False)
 
     def tear_down(self):
-        if self.dut_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.dut_testpmd.quit()
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/gtp.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete ddp profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.dut_testpmd.quit()
 
     def tear_down_all(self):
         self.dut.kill_all()
-- 
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues
  2019-01-08  4:28 [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues Xueqin Lin
@ 2019-01-15  1:07 ` Zhu, WenhuiX
  2019-01-15  4:55 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-01-15  1:07 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin


Tested-by : Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
Sent: Tuesday, January 8, 2019 12:28 PM
To: dts@dpdk.org
Cc: Lin, Xueqin <xueqin.lin@intel.com>
Subject: [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues

From: "xueqin.lin" <xueqin.lin@intel.com>

1. Dynamic flowtype could support FVL nic, not only fortville_25g.
2. RSS works also could receive packets from queue 0.
3. Restore original profile instead of core reset to avoid exception. 

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_dynamic_flowtype.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_dynamic_flowtype.py b/tests/TestSuite_dynamic_flowtype.py
index 05e6bcb..4652955 100644
--- a/tests/TestSuite_dynamic_flowtype.py
+++ b/tests/TestSuite_dynamic_flowtype.py
@@ -12,7 +12,7 @@ VM_CORES_MASK = 'all'
 class TestDynamicFlowtype(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'],
+        self.verify('fortville' in self.nic,
                     'dynamic flow type mapping can not support %s nic'
                     % self.nic)
         ports = self.dut.get_ports()
@@ -61,7 +61,7 @@ class TestDynamicFlowtype(TestCase):
         self.dut_testpmd.execute_cmd('port stop all')
         time.sleep(1)
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 
+ /tmp/gtp.pkgo,/tmp/gtp.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
                     "Failed to load ddp profile!!!") @@ -179,8 +179,6 @@ class TestDynamicFlowtype(TestCase):
             self.tester.scapy_execute()
             out = self.dut.get_session_output(timeout=2)
             if match_opt == 'matched':
-                self.verify("port 0/queue 0" not in out,
-                            "Failed to receive packet in rss queue!!!")
                 self.verify("PKT_RX_RSS_HASH" in out,
                             "Failed to receive packet in rss queue!!!")
             elif match_opt == 'not matched':
@@ -280,10 +278,17 @@ class TestDynamicFlowtype(TestCase):
         self.dynamic_flowtype_test(pctype=25, flowtype=25, reset=False)
 
     def tear_down(self):
-        if self.dut_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.dut_testpmd.quit()
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/gtp.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete ddp profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.dut_testpmd.quit()
 
     def tear_down_all(self):
         self.dut.kill_all()
--
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues
  2019-01-08  4:28 [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues Xueqin Lin
  2019-01-15  1:07 ` Zhu, WenhuiX
@ 2019-01-15  4:55 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-01-15  4:55 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Tuesday, January 8, 2019 12:28 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues
> 
> From: "xueqin.lin" <xueqin.lin@intel.com>
> 
> 1. Dynamic flowtype could support FVL nic, not only fortville_25g.
> 2. RSS works also could receive packets from queue 0.
> 3. Restore original profile instead of core reset to avoid exception.
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  tests/TestSuite_dynamic_flowtype.py | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_flowtype.py
> b/tests/TestSuite_dynamic_flowtype.py
> index 05e6bcb..4652955 100644
> --- a/tests/TestSuite_dynamic_flowtype.py
> +++ b/tests/TestSuite_dynamic_flowtype.py
> @@ -12,7 +12,7 @@ VM_CORES_MASK = 'all'
>  class TestDynamicFlowtype(TestCase):
> 
>      def set_up_all(self):
> -        self.verify(self.nic in ['fortville_25g'],
> +        self.verify('fortville' in self.nic,
>                      'dynamic flow type mapping can not support %s nic'
>                      % self.nic)
>          ports = self.dut.get_ports()
> @@ -61,7 +61,7 @@ class TestDynamicFlowtype(TestCase):
>          self.dut_testpmd.execute_cmd('port stop all')
>          time.sleep(1)
>          out = self.dut_testpmd.execute_cmd('ddp get list 0')
> -        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo')
> +        self.dut_testpmd.execute_cmd('ddp add 0
> + /tmp/gtp.pkgo,/tmp/gtp.bak')
>          out = self.dut_testpmd.execute_cmd('ddp get list 0')
>          self.verify("Profile number is: 1" in out,
>                      "Failed to load ddp profile!!!") @@ -179,8 +179,6 @@ class
> TestDynamicFlowtype(TestCase):
>              self.tester.scapy_execute()
>              out = self.dut.get_session_output(timeout=2)
>              if match_opt == 'matched':
> -                self.verify("port 0/queue 0" not in out,
> -                            "Failed to receive packet in rss queue!!!")
>                  self.verify("PKT_RX_RSS_HASH" in out,
>                              "Failed to receive packet in rss queue!!!")
>              elif match_opt == 'not matched':
> @@ -280,10 +278,17 @@ class TestDynamicFlowtype(TestCase):
>          self.dynamic_flowtype_test(pctype=25, flowtype=25, reset=False)
> 
>      def tear_down(self):
> -        if self.dut_testpmd:
> -            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
> -            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
> -            self.dut_testpmd.quit()
> +        self.dut_testpmd.execute_cmd('stop')
> +        out = self.dut_testpmd.execute_cmd('ddp get list 0')
> +        if "Profile number is: 0" not in out:
> +            self.dut_testpmd.execute_cmd('port stop all')
> +            time.sleep(1)
> +            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/gtp.bak')
> +            out = self.dut_testpmd.execute_cmd('ddp get list 0')
> +            self.verify("Profile number is: 0" in out,
> +                        "Failed to delete ddp profile!!!")
> +            self.dut_testpmd.execute_cmd('port start all')
> +        self.dut_testpmd.quit()
> 
>      def tear_down_all(self):
>          self.dut.kill_all()
> --
> 2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-15  4:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08  4:28 [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues Xueqin Lin
2019-01-15  1:07 ` Zhu, WenhuiX
2019-01-15  4:55 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).