test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
@ 2019-07-15  6:43 pvukkisala
  2019-08-07  3:23 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: pvukkisala @ 2019-07-15  6:43 UTC (permalink / raw)
  To: dts; +Cc: avijay, fmasood, Phanendra Vukkisala

From: Phanendra Vukkisala <pvukkisala@marvell.com>

our pmd completely blocks queuing up the pkts into TXD when queue is in stop state

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 tests/TestSuite_dynamic_queue.py |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index b055e5e..906fff8 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -152,9 +152,13 @@ class TestDynamicQueue(TestCase):
             out = self.dut_testpmd.execute_cmd('stop')
             tx_num = qringsize - 1
 
-            # Check Tx stopped queue only transmits qringsize-1 packets
-            self.verify("TX-packets: %d" % tx_num in out,
-                        "Fail to stop txq at runtime")
+            if self.nic == "cavium_a063":
+                self.verify("TX-packets: 0" in out,
+                            "Fail to stop txq at runtime")
+            else:
+                # Check Tx stopped queue only transmits qringsize-1 packets 
+                self.verify("TX-packets: %d" % tx_num in out,
+                            "Fail to stop txq at runtime")
             if chgflag == 1:
                 chg_qringsize = qringsize % 1024 + 256
                 if qringsize == 512:
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
  2019-07-15  6:43 [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device pvukkisala
@ 2019-08-07  3:23 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-08-07  3:23 UTC (permalink / raw)
  To: pvukkisala, dts; +Cc: avijay, fmasood

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Monday, July 15, 2019 2:43 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> our pmd completely blocks queuing up the pkts into TXD when queue is in
> stop state
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_dynamic_queue.py |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index b055e5e..906fff8 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -152,9 +152,13 @@ class TestDynamicQueue(TestCase):
>              out = self.dut_testpmd.execute_cmd('stop')
>              tx_num = qringsize - 1
> 
> -            # Check Tx stopped queue only transmits qringsize-1 packets
> -            self.verify("TX-packets: %d" % tx_num in out,
> -                        "Fail to stop txq at runtime")
> +            if self.nic == "cavium_a063":
> +                self.verify("TX-packets: 0" in out,
> +                            "Fail to stop txq at runtime")
> +            else:
> +                # Check Tx stopped queue only transmits qringsize-1 packets
> +                self.verify("TX-packets: %d" % tx_num in out,
> +                            "Fail to stop txq at runtime")
>              if chgflag == 1:
>                  chg_qringsize = qringsize % 1024 + 256
>                  if qringsize == 512:
> --
> 1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
  2019-07-04 13:57 pvukkisala
@ 2019-07-10  5:25 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-07-10  5:25 UTC (permalink / raw)
  To: pvukkisala, dts; +Cc: avijay, fmasood

Sorry, applied error, could you fix it?

Applying: dynamic_queue: Fix Tx queue tests on cavium device
.git/rebase-apply/patch:20: trailing whitespace.
                # Check Tx stopped queue only transmits qringsize-1 packets
error: patch failed: tests/TestSuite_dynamic_queue.py:150
error: tests/TestSuite_dynamic_queue.py: patch does not apply
Patch failed at 0001 dynamic_queue: Fix Tx queue tests on cavium device

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Thursday, July 4, 2019 9:57 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> our pmd completely blocks queuing up the pkts into TXD when queue is in
> stop state
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_dynamic_queue.py |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index f334a96..912e858 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -150,9 +150,13 @@ class TestDynamicQueue(TestCase):
>              out = self.dut_testpmd.execute_cmd('stop')
>              tx_num = qringsize - 1
> 
> -            # Check Tx stopped queue only transmits qringsize-1 packets
> -            self.verify("TX-packets: %d" % tx_num in out,
> -                        "Fail to stop txq at runtime")
> +            if self.nic == "cavium_a063":
> +                self.verify("TX-packets: 0" in out,
> +                            "Fail to stop txq at runtime")
> +            else:
> +                # Check Tx stopped queue only transmits qringsize-1 packets
> +                self.verify("TX-packets: %d" % tx_num in out,
> +                            "Fail to stop txq at runtime")
>              if chgflag == 1:
>                  chg_qringsize = qringsize % 1024 + 256
>                  self.dut_testpmd.execute_cmd(
> --
> 1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
@ 2019-07-04 13:57 pvukkisala
  2019-07-10  5:25 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: pvukkisala @ 2019-07-04 13:57 UTC (permalink / raw)
  To: dts; +Cc: avijay, fmasood, Phanendra Vukkisala

From: Phanendra Vukkisala <pvukkisala@marvell.com>

our pmd completely blocks queuing up the pkts into TXD when queue is in stop state

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 tests/TestSuite_dynamic_queue.py |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index f334a96..912e858 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -150,9 +150,13 @@ class TestDynamicQueue(TestCase):
             out = self.dut_testpmd.execute_cmd('stop')
             tx_num = qringsize - 1
 
-            # Check Tx stopped queue only transmits qringsize-1 packets
-            self.verify("TX-packets: %d" % tx_num in out,
-                        "Fail to stop txq at runtime")
+            if self.nic == "cavium_a063":
+                self.verify("TX-packets: 0" in out,
+                            "Fail to stop txq at runtime")
+            else:
+                # Check Tx stopped queue only transmits qringsize-1 packets 
+                self.verify("TX-packets: %d" % tx_num in out,
+                            "Fail to stop txq at runtime")
             if chgflag == 1:
                 chg_qringsize = qringsize % 1024 + 256
                 self.dut_testpmd.execute_cmd(
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15  6:43 [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device pvukkisala
2019-08-07  3:23 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2019-07-04 13:57 pvukkisala
2019-07-10  5:25 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox