test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port ownership
@ 2019-08-14 14:07 pvukkisala
  2019-08-28 10:06 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: pvukkisala @ 2019-08-14 14:07 UTC (permalink / raw)
  To: dts; +Cc: avijay, fmasood, Phanendra Vukkisala

From: Phanendra Vukkisala <pvukkisala@marvell.com>

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 framework/pktgen_ixia.py |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py
index 2895c6b..1e0675d 100644
--- a/framework/pktgen_ixia.py
+++ b/framework/pktgen_ixia.py
@@ -601,14 +601,18 @@ class Ixia(SSHConnection):
                     "set chasId [ixGetChassisID %s]" % self.tclServerIP, "% ")
         self.chasId = int(out.strip())
 
-        self.send_expect("ixClearOwnership [list %s]" % string.join(
+        out = self.send_expect("ixClearOwnership [list %s]" % string.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
                 for item in self.ports], ' '),
             "% ", 10)
-        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
+        if out.strip()[-1] != '0':
+            return False
+        out = self.send_expect("ixTakeOwnership [list %s] force" % string.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
                 for item in self.ports], ' '),
             "% ", 10)
+        if out.strip()[-1] != '0':
+            return False
 
         return True
 
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port ownership
  2019-08-14 14:07 [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port ownership pvukkisala
@ 2019-08-28 10:06 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-08-28 10:06 UTC (permalink / raw)
  To: pvukkisala, dts; +Cc: avijay, fmasood

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Wednesday, August 14, 2019 10:08 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port
> ownership
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  framework/pktgen_ixia.py |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py index
> 2895c6b..1e0675d 100644
> --- a/framework/pktgen_ixia.py
> +++ b/framework/pktgen_ixia.py
> @@ -601,14 +601,18 @@ class Ixia(SSHConnection):
>                      "set chasId [ixGetChassisID %s]" % self.tclServerIP, "% ")
>          self.chasId = int(out.strip())
> 
> -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> +        out = self.send_expect("ixClearOwnership [list %s]" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
>                  for item in self.ports], ' '),
>              "% ", 10)
> -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> +        if out.strip()[-1] != '0':
> +            return False
> +        out = self.send_expect("ixTakeOwnership [list %s] force" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
>                  for item in self.ports], ' '),
>              "% ", 10)
> +        if out.strip()[-1] != '0':
> +            return False
> 
>          return True
> 
> --
> 1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 14:07 [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port ownership pvukkisala
2019-08-28 10:06 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox