test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/tx_preparation: optimize script
  2019-08-23 17:03 [dts] [PATCH V1] tests/tx_preparation: optimize script Wenjie Li
@ 2019-08-23  8:24 ` Yao, BingX Y
  2019-09-04  5:00 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Yao, BingX Y @ 2019-08-23  8:24 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Tested-by:Yao, BingX Y <bingx.y.yao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Saturday, August 24, 2019 1:03 AM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script

move stop/quit testpmd into tear_down; otherwise, if one case is failed, the testpmd is still running, it will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_tx_preparation.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index eea95c1..ba0aac7 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify()
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit() 
  
     def test_tx_preparation_TSO(self):
         """
@@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify(1)
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit()
-
 
     def tear_down(self):
         """
         Run after each test case. 
-        """ 
-        pass
-
+        """
+        self.dut_testpmd.execute_cmd('stop')
+        self.dut_testpmd.quit()
         
     def tear_down_all(self):
         """
--
2.17.1


[-- Attachment #2: TestTX_preparation.log --]
[-- Type: application/octet-stream, Size: 55884 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/tx_preparation: optimize script
@ 2019-08-23 17:03 Wenjie Li
  2019-08-23  8:24 ` Yao, BingX Y
  2019-09-04  5:00 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-08-23 17:03 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

move stop/quit testpmd into tear_down; otherwise, if one case is failed,
the testpmd is still running, it will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_tx_preparation.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index eea95c1..ba0aac7 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify()
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit() 
  
     def test_tx_preparation_TSO(self):
         """
@@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify(1)
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit()
-
 
     def tear_down(self):
         """
         Run after each test case. 
-        """ 
-        pass
-
+        """
+        self.dut_testpmd.execute_cmd('stop')
+        self.dut_testpmd.quit()
         
     def tear_down_all(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/tx_preparation: optimize script
  2019-08-23 17:03 [dts] [PATCH V1] tests/tx_preparation: optimize script Wenjie Li
  2019-08-23  8:24 ` Yao, BingX Y
@ 2019-09-04  5:00 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-09-04  5:00 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Saturday, August 24, 2019 1:03 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script
> 
> move stop/quit testpmd into tear_down; otherwise, if one case is failed, the
> testpmd is still running, it will affect the following cases.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_tx_preparation.py | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index eea95c1..ba0aac7 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
>          self.dut_testpmd.execute_cmd('start')
> 
>          self.send_packet_verify()
> -        self.dut_testpmd.execute_cmd('stop')
> -        self.dut_testpmd.quit()
> 
>      def test_tx_preparation_TSO(self):
>          """
> @@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
>          self.dut_testpmd.execute_cmd('start')
> 
>          self.send_packet_verify(1)
> -        self.dut_testpmd.execute_cmd('stop')
> -        self.dut_testpmd.quit()
> -
> 
>      def tear_down(self):
>          """
>          Run after each test case.
> -        """
> -        pass
> -
> +        """
> +        self.dut_testpmd.execute_cmd('stop')
> +        self.dut_testpmd.quit()
> 
>      def tear_down_all(self):
>          """
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 17:03 [dts] [PATCH V1] tests/tx_preparation: optimize script Wenjie Li
2019-08-23  8:24 ` Yao, BingX Y
2019-09-04  5:00 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox