test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville and sagepond
@ 2019-09-06  6:16 Haiyang Zhao
  2019-09-18 10:25 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Haiyang Zhao @ 2019-09-06  6:16 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Haiyang Zhao

*.NIC with kernel driver ixgbe only enable queue 0 and queue 1   in
  vf rss as default. 
*.sageville and sagepond do not support sctp in vf rss.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_vf_rss.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py
index c41c932..8220926 100644
--- a/tests/TestSuite_vf_rss.py
+++ b/tests/TestSuite_vf_rss.py
@@ -157,6 +157,9 @@ class TestVfRss(TestCase):
         if not reta_entries:
             # for test_vfpmd_rss, check every queue can receive packet.
             for i in range(queue):
+                if self.kdriver == 'ixgbe' and i > 1:
+                    self.logger.info('NIC with kernel driver ixgbe only enable queue 0 and queue 1 as default')
+                    break
                 self.verify('RSS queue={}'.format(hex(i)) in out, 'queue {} did not receive packets'.format(i))
             return
         lines = out.split("\r\n")
@@ -362,6 +365,9 @@ class TestVfRss(TestCase):
                             "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]), "testpmd> ")
                     self.vm_dut_0.send_expect("port config all rss %s" % rss_type, "testpmd> ")
                 elif self.kdriver == 'i40e' or self.nic in ['sageville', 'sagepond']:
+                    if self.nic in ['sageville', 'sagepond'] and rss_type == 'sctp':
+                        self.logger.info('sageville and sagepond do not support rsstype sctp')
+                        continue
                     for i in range(64):
                         reta_entries.insert(i, random.randint(0, queue - 1))
                         self.vm_dut_0.send_expect(
@@ -407,6 +413,9 @@ class TestVfRss(TestCase):
             for iptype, rsstype in iptypes.items():
                 self.vm_dut_0.send_expect("set verbose 8", "testpmd> ")
                 self.vm_dut_0.send_expect("set fwd rxonly", "testpmd> ")
+                if self.nic in ['sageville', 'sagepond'] and rsstype == 'sctp':
+                    self.logger.info('sageville and sagepond do not support rsstype sctp')
+                    continue
                 out = self.vm_dut_0.send_expect("port config all rss %s" % rsstype, "testpmd> ")
                 self.verify("Operation not supported" not in out, "Operation not supported")
                 self.vm_dut_0.send_expect(
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville and sagepond
  2019-09-06  6:16 [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville and sagepond Haiyang Zhao
@ 2019-09-18 10:25 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-09-18 10:25 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Lin, Xueqin, Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Friday, September 6, 2019 2:17 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville
> and sagepond
> 
> *.NIC with kernel driver ixgbe only enable queue 0 and queue 1   in
>   vf rss as default.
> *.sageville and sagepond do not support sctp in vf rss.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_rss.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py index
> c41c932..8220926 100644
> --- a/tests/TestSuite_vf_rss.py
> +++ b/tests/TestSuite_vf_rss.py
> @@ -157,6 +157,9 @@ class TestVfRss(TestCase):
>          if not reta_entries:
>              # for test_vfpmd_rss, check every queue can receive packet.
>              for i in range(queue):
> +                if self.kdriver == 'ixgbe' and i > 1:
> +                    self.logger.info('NIC with kernel driver ixgbe only enable queue
> 0 and queue 1 as default')
> +                    break
>                  self.verify('RSS queue={}'.format(hex(i)) in out, 'queue {} did not
> receive packets'.format(i))
>              return
>          lines = out.split("\r\n")
> @@ -362,6 +365,9 @@ class TestVfRss(TestCase):
>                              "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]),
> "testpmd> ")
>                      self.vm_dut_0.send_expect("port config all rss %s" % rss_type,
> "testpmd> ")
>                  elif self.kdriver == 'i40e' or self.nic in ['sageville', 'sagepond']:
> +                    if self.nic in ['sageville', 'sagepond'] and rss_type == 'sctp':
> +                        self.logger.info('sageville and sagepond do not support
> rsstype sctp')
> +                        continue
>                      for i in range(64):
>                          reta_entries.insert(i, random.randint(0, queue - 1))
>                          self.vm_dut_0.send_expect( @@ -407,6 +413,9 @@ class
> TestVfRss(TestCase):
>              for iptype, rsstype in iptypes.items():
>                  self.vm_dut_0.send_expect("set verbose 8", "testpmd> ")
>                  self.vm_dut_0.send_expect("set fwd rxonly", "testpmd> ")
> +                if self.nic in ['sageville', 'sagepond'] and rsstype == 'sctp':
> +                    self.logger.info('sageville and sagepond do not support rsstype
> sctp')
> +                    continue
>                  out = self.vm_dut_0.send_expect("port config all rss %s" % rsstype,
> "testpmd> ")
>                  self.verify("Operation not supported" not in out, "Operation not
> supported")
>                  self.vm_dut_0.send_expect(
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-18 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06  6:16 [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville and sagepond Haiyang Zhao
2019-09-18 10:25 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).