test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Peng, ZhihongX" <zhihongx.peng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Peng, ZhihongX" <zhihongx.peng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl	do not check the nic status
Date: Fri, 22 Nov 2019 05:26:03 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB67638@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191122032120.5704-1-zhihongx.peng@intel.com>

Please rework it:

Applying: tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
.git/rebase-apply/patch:14: trailing whitespace.
        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:
warning: 1 line adds whitespace errors.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Friday, November 22, 2019 11:21 AM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do
> not check the nic status
> 
> tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 92724aa..743be63 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False or
> self.nic.startswith("columbiaville"):
> +        if self.nic.startswith("fortville") == False and
> self.nic.startswith("columbiaville") == False:
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


  reply	other threads:[~2019-11-22  5:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22  3:21 Peng Zhihong
2019-11-22  5:26 ` Tu, Lijuan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-22  5:38 Peng Zhihong
2019-11-22  6:37 ` Tu, Lijuan
2019-11-04  8:51 Peng Zhihong
2019-11-22  3:07 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB67638@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhihongx.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).