test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 1/2]framework: fix the error of getting vlan value
@ 2020-03-10  9:04 hanyingya
  2020-03-11  1:31 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: hanyingya @ 2020-03-10  9:04 UTC (permalink / raw)
  To: dts, lijuan.tu; +Cc: hanyingya

Signed-off-by: hanyingya <yingyax.han@intel.com>
---
 framework/pktgen.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/pktgen.py b/framework/pktgen.py
index 889e94a..404f171 100644
--- a/framework/pktgen.py
+++ b/framework/pktgen.py
@@ -167,7 +167,7 @@ class PacketGeneratorHelper(object):
                 action = config.get('action') or 'default'
                 range = config.get('range') or 64
                 # ignore 'L' suffix
-                start_vlan = int(pcap_fields.get(layer_name)[:-1])
+                start_vlan = int(pcap_fields.get(layer_name))
                 end_vlan = start_vlan + range - 1
                 fields_config[layer_name][name] = {}
                 fields_config[layer_name][name]['start'] = start_vlan
@@ -212,4 +212,4 @@ def getPacketGenerator(tester, pktgen_type=PKTGEN_IXIA):
         return CLS(tester)
     else:
         msg = "not support <{0}> packet generator".format(pktgen_type)
-        raise Exception(msg)
\ No newline at end of file
+        raise Exception(msg)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1 1/2]framework: fix the error of getting vlan value
  2020-03-10  9:04 [dts] [PATCH V1 1/2]framework: fix the error of getting vlan value hanyingya
@ 2020-03-11  1:31 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-03-11  1:31 UTC (permalink / raw)
  To: Han, YingyaX, dts, Mo, YufengX



> -----Original Message-----
> From: Han, YingyaX
> Sent: Tuesday, March 10, 2020 5:04 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts][PATCH V1 1/2]framework: fix the error of getting vlan value
> 
> Signed-off-by: hanyingya <yingyax.han@intel.com>
> ---
>  framework/pktgen.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/pktgen.py b/framework/pktgen.py index
> 889e94a..404f171 100644
> --- a/framework/pktgen.py
> +++ b/framework/pktgen.py
> @@ -167,7 +167,7 @@ class PacketGeneratorHelper(object):
>                  action = config.get('action') or 'default'
>                  range = config.get('range') or 64
>                  # ignore 'L' suffix
> -                start_vlan = int(pcap_fields.get(layer_name)[:-1])
> +                start_vlan = int(pcap_fields.get(layer_name))
[Lijuan] need consider more, how to deal with w/ or w/o "L" suffix . some scapy version may have "L" suffix, and the other may not have. 
>                  end_vlan = start_vlan + range - 1
>                  fields_config[layer_name][name] = {}
>                  fields_config[layer_name][name]['start'] = start_vlan @@ -212,4
> +212,4 @@ def getPacketGenerator(tester, pktgen_type=PKTGEN_IXIA):
>          return CLS(tester)
>      else:
>          msg = "not support <{0}> packet generator".format(pktgen_type)
> -        raise Exception(msg)
> \ No newline at end of file
> +        raise Exception(msg)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10  9:04 [dts] [PATCH V1 1/2]framework: fix the error of getting vlan value hanyingya
2020-03-11  1:31 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox