test suite reviews and discussions
 help / color / mirror / Atom feed
* RE: [dts] [PATCH V1] tests/eeprom_dump: fix script
  2022-05-07 15:31 [dts] [PATCH V1] tests/eeprom_dump: fix script Jiale Song
@ 2022-05-07 11:09 ` Huang, ZhiminX
  2022-05-09  7:45 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: Huang, ZhiminX @ 2022-05-07 11:09 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

> -----Original Message-----
> From: Jiale Song <songx.jiale@intel.com>
> Sent: Saturday, May 7, 2022 11:31 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/eeprom_dump: fix script
> 
> fix 2 issues:
>     1. with '#' in the echo, it will interfere with the test results
>     2. after the case test, the port should be tied back to the dpdk driver
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---
Tested-by: Zhimin Huang <zhiminx.huang@intel.com >



[-- Attachment #2: TestEEPROMDump.log --]
[-- Type: application/octet-stream, Size: 45983 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/eeprom_dump: fix script
@ 2022-05-07 15:31 Jiale Song
  2022-05-07 11:09 ` Huang, ZhiminX
  2022-05-09  7:45 ` lijuan.tu
  0 siblings, 2 replies; 3+ messages in thread
From: Jiale Song @ 2022-05-07 15:31 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

fix 2 issues:
    1. with '#' in the echo, it will interfere with the test results
    2. after the case test, the port should be tied back to the dpdk driver

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_eeprom_dump.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_eeprom_dump.py b/tests/TestSuite_eeprom_dump.py
index c1a5b4ea..b220316b 100644
--- a/tests/TestSuite_eeprom_dump.py
+++ b/tests/TestSuite_eeprom_dump.py
@@ -144,7 +144,7 @@ class TestEEPROMDump(TestCase):
                 "#",
             )
             portinfo["ethout"] = self.dut.send_expect(
-                f"cat ethtool_{testname}_hex_{port}.txt", "#"
+                f"cat ethtool_{testname}_hex_{port}.txt", "# ", trim_whitespace=False
             )
 
             self.dump_to_file(
@@ -171,6 +171,7 @@ class TestEEPROMDump(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+        self.dut.bind_interfaces_linux(self.drivername)
 
     def tear_down_all(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/eeprom_dump: fix script
  2022-05-07 15:31 [dts] [PATCH V1] tests/eeprom_dump: fix script Jiale Song
  2022-05-07 11:09 ` Huang, ZhiminX
@ 2022-05-09  7:45 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2022-05-09  7:45 UTC (permalink / raw)
  To: dts, Jiale Song; +Cc: Jiale Song

On Sat,  7 May 2022 23:31:06 +0800, Jiale Song <songx.jiale@intel.com> wrote:
> fix 2 issues:
>     1. with '#' in the echo, it will interfere with the test results
>     2. after the case test, the port should be tied back to the dpdk driver
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-09  7:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 15:31 [dts] [PATCH V1] tests/eeprom_dump: fix script Jiale Song
2022-05-07 11:09 ` Huang, ZhiminX
2022-05-09  7:45 ` lijuan.tu

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git