test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/vf_offload: optimize script
@ 2023-03-27 17:36 Song Jiale
  2023-03-28  1:24 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Song Jiale @ 2023-03-27 17:36 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

in general, vfs do not need to enable trust on. some intree drivers have
a issue that vfs with trust on cannot receive vf vlan packets, and
this issue will not be fixed. in order not to affect subsequent case
testing, do not enable trust on unnecessarily.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_vf_offload.py | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

V2:
-modify the comment description

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 9475ef22..47f6351b 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -91,20 +91,21 @@ class TestVfOffload(TestCase):
         self.host_intf_0 = self.dut.ports_info[self.used_dut_port_0]["intf"]
         self.host_intf_1 = self.dut.ports_info[self.used_dut_port_1]["intf"]
 
-        self.ip_link_set(
-            host_intf=self.host_intf_0,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
-        self.ip_link_set(
-            host_intf=self.host_intf_1,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
+        if self.dcf_mode:
+            self.ip_link_set(
+                host_intf=self.host_intf_0,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
+            self.ip_link_set(
+                host_intf=self.host_intf_1,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
         self.ip_link_set(
             host_intf=self.host_intf_0,
             cmd="vf",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V2] tests/vf_offload: optimize script
  2023-03-27 17:36 [dts] [PATCH V2] tests/vf_offload: optimize script Song Jiale
@ 2023-03-28  1:24 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-03-28  1:24 UTC (permalink / raw)
  To: dts, Song Jiale; +Cc: Song Jiale

On Mon, 27 Mar 2023 17:36:50 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> in general, vfs do not need to enable trust on. some intree drivers have
> a issue that vfs with trust on cannot receive vf vlan packets, and
> this issue will not be fixed. in order not to affect subsequent case
> testing, do not enable trust on unnecessarily.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-28  1:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 17:36 [dts] [PATCH V2] tests/vf_offload: optimize script Song Jiale
2023-03-28  1:24 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).