test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL
  2019-11-28 15:22 [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL Wenjie Li
@ 2019-11-28  6:38 ` Zhu, WenhuiX
  2019-12-02  6:31   ` Ma, LihongX
  2019-12-04  5:36 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Zhu, WenhuiX @ 2019-11-28  6:38 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, November 28, 2019 11:22 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
--
2.17.1


[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 648789 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL
@ 2019-11-28 15:22 Wenjie Li
  2019-11-28  6:38 ` Zhu, WenhuiX
  2019-12-04  5:36 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Wenjie Li @ 2019-11-28 15:22 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link 
status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify
the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL
  2019-11-28  6:38 ` Zhu, WenhuiX
@ 2019-12-02  6:31   ` Ma, LihongX
  0 siblings, 0 replies; 4+ messages in thread
From: Ma, LihongX @ 2019-12-02  6:31 UTC (permalink / raw)
  To: Zhu, WenhuiX, Li, WenjieX A, dts; +Cc: Li, WenjieX A

Reviewed-by: ma,lihong<lihongx.ma@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhu, WenhuiX
Sent: Thursday, November 28, 2019 2:39 PM
To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, November 28, 2019 11:22 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
--
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL
  2019-11-28 15:22 [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL Wenjie Li
  2019-11-28  6:38 ` Zhu, WenhuiX
@ 2019-12-04  5:36 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-12-04  5:36 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, November 28, 2019 11:22 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal
> link status for CVL
> 
> In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link
> status for CVL.
> If the link is up, it should be up after 'port stop'; if down, then be down.
> This is different with other NICs.
> 
> In test case stop_restart, the port is up before 'port stop', so verify the port is
> UP for CVL and down for other NICs.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
>          self.check_forwarding(received=False)
>          self.dut.send_expect("port stop all", "testpmd> ", 100)
>          time.sleep(5)
> -        self.check_ports(status=False)
> +        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
> +            self.check_ports(status=True)
> +        else:
> +            self.check_ports(status=False)
>          self.dut.send_expect("port start all", "testpmd> ", 100)
>          time.sleep(5)
>          self.check_ports(status=True)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 15:22 [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL Wenjie Li
2019-11-28  6:38 ` Zhu, WenhuiX
2019-12-02  6:31   ` Ma, LihongX
2019-12-04  5:36 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox