test suite reviews and discussions
 help / color / mirror / Atom feed
* RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
  2021-11-15 14:37 [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx Zhimin Huang
@ 2021-11-15  6:15 ` Huang, ZhiminX
  2021-11-30  3:11 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Huang, ZhiminX @ 2021-11-15  6:15 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Monday, November 15, 2021 10:38 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
> 
> sync with dev to ignore check sctp in pmd,customers only require udp and tcp.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
Tested-by: Zhimin Huang <zhiminx.huang@intel.com >



[-- Attachment #2: TestChecksumOffload.log --]
[-- Type: application/octet-stream, Size: 130303 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
@ 2021-11-15 14:37 Zhimin Huang
  2021-11-15  6:15 ` Huang, ZhiminX
  2021-11-30  3:11 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Zhimin Huang @ 2021-11-15 14:37 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

sync with dev to ignore check sctp in pmd,customers only require udp and tcp.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/checksum_offload_test_plan.rst | 2 +-
 tests/TestSuite_checksum_offload.py       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_plans/checksum_offload_test_plan.rst b/test_plans/checksum_offload_test_plan.rst
index db939b45..f4b388c4 100644
--- a/test_plans/checksum_offload_test_plan.rst
+++ b/test_plans/checksum_offload_test_plan.rst
@@ -297,7 +297,7 @@ Test Case: Hardware Checksum Check L4 TX
 ===========================================
 This test involves testing many different scenarios with a L4 checksum.
 A variety of tunneling protocols, L3 protocols and L4 protocols are combined
-to test as many scenarios as possible. Currently, UDP, TCP and SCTP are used
+to test as many scenarios as possible. Currently, UDP and TCP are used
 as L4 protocols, with IP and IPv6 being used at level 3. The tested tunneling
 protocols are VXLAN and GRE. This test is used to determine whether the
 hardware offloading of checksums works properly.
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 3338e334..bdea6a15 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -69,7 +69,7 @@ l3_proto_classes = [
 l4_proto_classes = [
     UDP,
     TCP,
-    SCTP
+#    SCTP
 ]
 
 tunnelling_proto_classes = [
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
  2021-11-15 14:37 [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx Zhimin Huang
  2021-11-15  6:15 ` Huang, ZhiminX
@ 2021-11-30  3:11 ` Tu, Lijuan
  2021-11-30  3:17   ` Huang, ZhiminX
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2021-11-30  3:11 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX



> -----Original Message-----
> From: Zhimin Huang <zhiminx.huang@intel.com>
> Sent: 2021年11月15日 22:38
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
> 
> sync with dev to ignore check sctp in pmd,customers only require udp and tcp.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  test_plans/checksum_offload_test_plan.rst | 2 +-
>  tests/TestSuite_checksum_offload.py       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test_plans/checksum_offload_test_plan.rst
> b/test_plans/checksum_offload_test_plan.rst
> index db939b45..f4b388c4 100644
> --- a/test_plans/checksum_offload_test_plan.rst
> +++ b/test_plans/checksum_offload_test_plan.rst
> @@ -297,7 +297,7 @@ Test Case: Hardware Checksum Check L4 TX
> ===========================================
>  This test involves testing many different scenarios with a L4 checksum.
>  A variety of tunneling protocols, L3 protocols and L4 protocols are combined -
> to test as many scenarios as possible. Currently, UDP, TCP and SCTP are used
> +to test as many scenarios as possible. Currently, UDP and TCP are used
>  as L4 protocols, with IP and IPv6 being used at level 3. The tested tunneling
> protocols are VXLAN and GRE. This test is used to determine whether the
> hardware offloading of checksums works properly.
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index 3338e334..bdea6a15 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -69,7 +69,7 @@ l3_proto_classes = [
>  l4_proto_classes = [
>      UDP,
>      TCP,
> -    SCTP
> +#    SCTP

It is commented here,  I think it is a know issue and will be fixed in a short time.

If there is no plan to fix it? Why keep them ?

>  ]
> 
>  tunnelling_proto_classes = [
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
  2021-11-30  3:11 ` Tu, Lijuan
@ 2021-11-30  3:17   ` Huang, ZhiminX
  0 siblings, 0 replies; 4+ messages in thread
From: Huang, ZhiminX @ 2021-11-30  3:17 UTC (permalink / raw)
  To: Tu, Lijuan, dts



> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, November 30, 2021 11:12 AM
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check
> l4 tx
> 
> 
> 
> > -----Original Message-----
> > From: Zhimin Huang <zhiminx.huang@intel.com>
> > Sent: 2021年11月15日 22:38
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in
> > check l4 tx
> >
> > sync with dev to ignore check sctp in pmd,customers only require udp and
> tcp.
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> > ---
> >  test_plans/checksum_offload_test_plan.rst | 2 +-
> >  tests/TestSuite_checksum_offload.py       | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/test_plans/checksum_offload_test_plan.rst
> > b/test_plans/checksum_offload_test_plan.rst
> > index db939b45..f4b388c4 100644
> > --- a/test_plans/checksum_offload_test_plan.rst
> > +++ b/test_plans/checksum_offload_test_plan.rst
> > @@ -297,7 +297,7 @@ Test Case: Hardware Checksum Check L4 TX
> > ===========================================
> >  This test involves testing many different scenarios with a L4 checksum.
> >  A variety of tunneling protocols, L3 protocols and L4 protocols are
> > combined - to test as many scenarios as possible. Currently, UDP, TCP
> > and SCTP are used
> > +to test as many scenarios as possible. Currently, UDP and TCP are
> > +used
> >  as L4 protocols, with IP and IPv6 being used at level 3. The tested
> > tunneling protocols are VXLAN and GRE. This test is used to determine
> > whether the hardware offloading of checksums works properly.
> > diff --git a/tests/TestSuite_checksum_offload.py
> > b/tests/TestSuite_checksum_offload.py
> > index 3338e334..bdea6a15 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -69,7 +69,7 @@ l3_proto_classes = [  l4_proto_classes = [
> >      UDP,
> >      TCP,
> > -    SCTP
> > +#    SCTP
> 
> It is commented here,  I think it is a know issue and will be fixed in a short
> time.
> 
> If there is no plan to fix it? Why keep them ?
> 
> >  ]
> >
> >  tunnelling_proto_classes = [
> > --
> > 2.17.1
> 
Ok, I will re_submit v2 patch to remove it, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-30  3:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 14:37 [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx Zhimin Huang
2021-11-15  6:15 ` Huang, ZhiminX
2021-11-30  3:11 ` Tu, Lijuan
2021-11-30  3:17   ` Huang, ZhiminX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git