From: David Marchand <david.marchand@redhat.com>
To: "Ling, WeiX" <weix.ling@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>, "Tu, Lijuan" <lijuan.tu@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dts][PATCH V4 3/3] tests/dpdk_gro_lib_cbdma: add dpdk_gro_lib_cbdma testsuite
Date: Wed, 18 May 2022 15:39:43 +0200 [thread overview]
Message-ID: <CAJFAV8yVq5R==vDJMR7gSbLVDSNE5MkbE+e6b0hbyLXoE1CaqQ@mail.gmail.com> (raw)
In-Reply-To: <PH7PR11MB600628A6EA5D3755AC71D43CEED19@PH7PR11MB6006.namprd11.prod.outlook.com>
On Wed, May 18, 2022 at 11:36 AM Ling, WeiX <weix.ling@intel.com> wrote:
> > >
> > > Add new testsuite tests/TestSuite_dpdk_gro_lib_cbdma.py.
> > >
> > > Signed-off-by: Wei Ling <weix.ling@intel.com>
> >
> > I commented on v1.
> > v4 is the same.
> >
> > NAK.
>
> Because we also need to modify DPDK code to test this suite before the
> DPDK patch merged into the DPDK.
The existing code must be cleaned and Intel should stop adding more
technical debt stuff to dts.
I can see the patch already got merged, so it seems my point was not
understood by the dts maintainer.
This patch should be reverted.
--
David Marchand
next prev parent reply other threads:[~2022-05-18 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:01 Wei Ling
2022-05-10 7:04 ` David Marchand
2022-05-18 9:36 ` Ling, WeiX
2022-05-18 13:39 ` David Marchand [this message]
2022-05-18 15:25 ` Honnappa Nagarahalli
2022-05-11 1:33 ` He, Xingguang
2022-05-11 7:47 ` Huang, ChenyuX
2022-05-18 11:03 ` lijuan.tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yVq5R==vDJMR7gSbLVDSNE5MkbE+e6b0hbyLXoE1CaqQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dts@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=lijuan.tu@intel.com \
--cc=thomas@monjalon.net \
--cc=weix.ling@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).