Soft Patch Panel
 help / color / mirror / Atom feed
* [spp] [PATCH 0/2] Remove global g_startup_param
@ 2019-06-26  5:35 yasufum.o
  2019-06-26  5:35 ` [spp] [PATCH 1/2] shared/sec: remove global var g_startup_param yasufum.o
  2019-06-26  5:35 ` [spp] [PATCH 2/2] spp_pcap: " yasufum.o
  0 siblings, 2 replies; 3+ messages in thread
From: yasufum.o @ 2019-06-26  5:35 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

From: Yasufumi Ogawa <yasufum.o@gmail.com>

This series of patches is to remove global variable of command args
`g_startup_param` because many of global variables are defined and
strongly depended on each other. It makes hard to change codes.

Instead of this global variable, each of args is retrieved with
following functions.

* get_client_id()
* get_vhost_cli_mode()
* get_spp_ctl_ip()
* get_spp_ctl_port()

Yasufumi Ogawa (2):
  shared/sec: remove global var g_startup_param
  spp_pcap: remove global var g_startup_param

 src/mirror/mir_cmd_runner.c                       | 12 ++++++------
 src/mirror/spp_mirror.c                           | 14 ++++----------
 src/pcap/cmd_runner.c                             |  8 +++-----
 src/pcap/cmd_utils.c                              | 13 +++----------
 src/pcap/cmd_utils.h                              | 15 ++-------------
 src/pcap/spp_pcap.c                               | 15 +++------------
 .../secondary/spp_worker_th/cmd_res_formatter.c   |  3 +--
 src/shared/secondary/spp_worker_th/cmd_runner.c   |  4 ++--
 src/shared/secondary/spp_worker_th/cmd_utils.c    |  9 +--------
 src/shared/secondary/spp_worker_th/cmd_utils.h    | 14 ++------------
 src/vf/spp_vf.c                                   |  8 +-------
 src/vf/vf_cmd_runner.c                            | 12 ++++++------
 12 files changed, 34 insertions(+), 93 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-26  5:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26  5:35 [spp] [PATCH 0/2] Remove global g_startup_param yasufum.o
2019-06-26  5:35 ` [spp] [PATCH 1/2] shared/sec: remove global var g_startup_param yasufum.o
2019-06-26  5:35 ` [spp] [PATCH 2/2] spp_pcap: " yasufum.o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).