patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference
@ 2020-07-25 12:14 Qi Zhang
  2020-07-27  1:28 ` [dpdk-stable] [dpdk-dev] " Lu, Nannan
  0 siblings, 1 reply; 4+ messages in thread
From: Qi Zhang @ 2020-07-25 12:14 UTC (permalink / raw)
  To: qiming.yang; +Cc: simei.su, dev, Qi Zhang, stable

A new symmetric RSS rule may force another asymmetric rule to be
symmetric, vise versa. The reason is due to the flow engine will
try to reuse the existing profile if the input set matches with the
new rule. The fix is to disable this optimization for RSS since we
are not at the situation as profile shortage.

Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_flex_pipe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 284569464..999ad6be3 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -2808,10 +2808,10 @@ ice_find_prof_id_with_mask(struct ice_hw *hw, enum ice_block blk,
 	struct ice_es *es = &hw->blk[blk].es;
 	u8 i;
 
-	/* For FD, we don't want to re-use an existed profile with the same
-	 * field vector and mask. This will cause rule interference.
+	/* For FD and RSS, we don't want to re-use an existed profile with the
+	 * same field vector and mask. This will cause rule interference.
 	 */
-	if (blk == ICE_BLK_FD)
+	if (blk == ICE_BLK_FD || blk == ICE_BLK_RSS)
 		return ICE_ERR_DOES_NOT_EXIST;
 
 	for (i = 0; i < (u8)es->count; i++) {
-- 
2.13.6


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference
  2020-07-25 12:14 [dpdk-stable] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference Qi Zhang
@ 2020-07-27  1:28 ` " Lu, Nannan
  2020-07-27  3:32   ` Jeff Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Lu, Nannan @ 2020-07-27  1:28 UTC (permalink / raw)
  To: Zhang, Qi Z, Yang, Qiming; +Cc: Su, Simei, dev, Zhang, Qi Z, stable

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Saturday, July 25, 2020 8:14 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS
> interference
> 
> A new symmetric RSS rule may force another asymmetric rule to be symmetric,
> vise versa. The reason is due to the flow engine will try to reuse the existing
> profile if the input set matches with the new rule. The fix is to disable this
> optimization for RSS since we are not at the situation as profile shortage.
> 
> Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ice/base/ice_flex_pipe.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Tested-by: Nannan Lu <nannan.lu@intel.com>

> --
> 2.13.6


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference
  2020-07-27  1:28 ` [dpdk-stable] [dpdk-dev] " Lu, Nannan
@ 2020-07-27  3:32   ` Jeff Guo
  2020-07-27  5:06     ` Zhang, Qi Z
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Guo @ 2020-07-27  3:32 UTC (permalink / raw)
  To: Lu, Nannan, Zhang, Qi Z, Yang, Qiming; +Cc: Su, Simei, dev, stable


On 7/27/2020 9:28 AM, Lu, Nannan wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
>> Sent: Saturday, July 25, 2020 8:14 PM
>> To: Yang, Qiming <qiming.yang@intel.com>
>> Cc: Su, Simei <simei.su@intel.com>; dev@dpdk.org; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS
>> interference
>>
>> A new symmetric RSS rule may force another asymmetric rule to be symmetric,
>> vise versa. The reason is due to the flow engine will try to reuse the existing
>> profile if the input set matches with the new rule. The fix is to disable this
>> optimization for RSS since we are not at the situation as profile shortage.
>>
>> Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> ---
>>   drivers/net/ice/base/ice_flex_pipe.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
> Tested-by: Nannan Lu <nannan.lu@intel.com>


Acked-by: Jeff Guo <jia.guo@intel.com>


>
>> --
>> 2.13.6

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference
  2020-07-27  3:32   ` Jeff Guo
@ 2020-07-27  5:06     ` Zhang, Qi Z
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2020-07-27  5:06 UTC (permalink / raw)
  To: Guo, Jia, Lu, Nannan, Yang, Qiming; +Cc: Su, Simei, dev, stable



> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Monday, July 27, 2020 11:32 AM
> To: Lu, Nannan <nannan.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS
> interference
> 
> 
> On 7/27/2020 9:28 AM, Lu, Nannan wrote:
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> >> Sent: Saturday, July 25, 2020 8:14 PM
> >> To: Yang, Qiming <qiming.yang@intel.com>
> >> Cc: Su, Simei <simei.su@intel.com>; dev@dpdk.org; Zhang, Qi Z
> >> <qi.z.zhang@intel.com>; stable@dpdk.org
> >> Subject: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric
> >> RSS interference
> >>
> >> A new symmetric RSS rule may force another asymmetric rule to be
> >> symmetric, vise versa. The reason is due to the flow engine will try

vice versa.

> >> to reuse the existing profile if the input set matches with the new
> >> rule. The fix is to disable this optimization for RSS since we are not at the
> situation as profile shortage.
> >>
> >> Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> >> ---
> >>   drivers/net/ice/base/ice_flex_pipe.c | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> > Tested-by: Nannan Lu <nannan.lu@intel.com>
> 
> 
> Acked-by: Jeff Guo <jia.guo@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> >
> >> --
> >> 2.13.6

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 12:14 [dpdk-stable] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference Qi Zhang
2020-07-27  1:28 ` [dpdk-stable] [dpdk-dev] " Lu, Nannan
2020-07-27  3:32   ` Jeff Guo
2020-07-27  5:06     ` Zhang, Qi Z

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox