patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] Backporting rte_intr_ack
@ 2019-10-14 15:55 David Marchand
  2019-11-19 10:40 ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2019-10-14 15:55 UTC (permalink / raw)
  To: dev; +Cc: Kevin Traynor, Luca Boccassi, Thomas Monjalon, dpdk stable

Hello guys,

The api rte_intr_ack that has been introduced to fix a race condition
observed with (at least) qede drivers/hw.
This is an experimental api in master but it still fixes a problem, so
I'd like to see this in stable branches.


Opinions?


Thanks.
-- 
David Marchand

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] Backporting rte_intr_ack
  2019-10-14 15:55 [dpdk-stable] Backporting rte_intr_ack David Marchand
@ 2019-11-19 10:40 ` Thomas Monjalon
  2019-11-22 15:12   ` Kevin Traynor
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2019-11-19 10:40 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Kevin Traynor, Luca Boccassi, dpdk stable

14/10/2019 17:55, David Marchand:
> The api rte_intr_ack that has been introduced to fix a race condition
> observed with (at least) qede drivers/hw.
> This is an experimental api in master but it still fixes a problem, so
> I'd like to see this in stable branches.

This is more a driver interface than an API.

> Opinions?

If it comes with a fix in a driver, I think it is worth backporting.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] Backporting rte_intr_ack
  2019-11-19 10:40 ` Thomas Monjalon
@ 2019-11-22 15:12   ` Kevin Traynor
  2019-11-22 15:24     ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Kevin Traynor @ 2019-11-22 15:12 UTC (permalink / raw)
  To: Thomas Monjalon, David Marchand; +Cc: dev, Luca Boccassi, dpdk stable

On 19/11/2019 10:40, Thomas Monjalon wrote:
> 14/10/2019 17:55, David Marchand:
>> The api rte_intr_ack that has been introduced to fix a race condition
>> observed with (at least) qede drivers/hw.
>> This is an experimental api in master but it still fixes a problem, so
>> I'd like to see this in stable branches.
> 
> This is more a driver interface than an API.
> 
>> Opinions?
> 
> If it comes with a fix in a driver, I think it is worth backporting.
> 
> 

I think fine to backport as it solves an observed problem for qede.
However, a bit reluctant to update all the drivers to use it without
acks from their maintainers.

Discussed with David offline and idea to backport and only update qede
now. Other drivers can be updated if there is a request from
maintainers. How does it sound?


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] Backporting rte_intr_ack
  2019-11-22 15:12   ` Kevin Traynor
@ 2019-11-22 15:24     ` Thomas Monjalon
  2019-11-22 16:33       ` Kevin Traynor
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2019-11-22 15:24 UTC (permalink / raw)
  To: Kevin Traynor; +Cc: David Marchand, dev, Luca Boccassi, dpdk stable

22/11/2019 16:12, Kevin Traynor:
> On 19/11/2019 10:40, Thomas Monjalon wrote:
> > 14/10/2019 17:55, David Marchand:
> >> The api rte_intr_ack that has been introduced to fix a race condition
> >> observed with (at least) qede drivers/hw.
> >> This is an experimental api in master but it still fixes a problem, so
> >> I'd like to see this in stable branches.
> > 
> > This is more a driver interface than an API.
> > 
> >> Opinions?
> > 
> > If it comes with a fix in a driver, I think it is worth backporting.
> > 
> > 
> 
> I think fine to backport as it solves an observed problem for qede.
> However, a bit reluctant to update all the drivers to use it without
> acks from their maintainers.
> 
> Discussed with David offline and idea to backport and only update qede
> now. Other drivers can be updated if there is a request from
> maintainers. How does it sound?

It's better than nothing.
But it makes tracking of backports more difficult.
Is it a common practice to backport half of fixes?



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] Backporting rte_intr_ack
  2019-11-22 15:24     ` Thomas Monjalon
@ 2019-11-22 16:33       ` Kevin Traynor
  0 siblings, 0 replies; 5+ messages in thread
From: Kevin Traynor @ 2019-11-22 16:33 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: David Marchand, dev, Luca Boccassi, dpdk stable

On 22/11/2019 15:24, Thomas Monjalon wrote:
> 22/11/2019 16:12, Kevin Traynor:
>> On 19/11/2019 10:40, Thomas Monjalon wrote:
>>> 14/10/2019 17:55, David Marchand:
>>>> The api rte_intr_ack that has been introduced to fix a race condition
>>>> observed with (at least) qede drivers/hw.
>>>> This is an experimental api in master but it still fixes a problem, so
>>>> I'd like to see this in stable branches.
>>>
>>> This is more a driver interface than an API.
>>>
>>>> Opinions?
>>>
>>> If it comes with a fix in a driver, I think it is worth backporting.
>>>
>>>
>>
>> I think fine to backport as it solves an observed problem for qede.
>> However, a bit reluctant to update all the drivers to use it without
>> acks from their maintainers.
>>
>> Discussed with David offline and idea to backport and only update qede
>> now. Other drivers can be updated if there is a request from
>> maintainers. How does it sound?
> 
> It's better than nothing.

Not sure whether it should be opt-in or opt-out for driver maintainers,
but if there is some bug found in this new experimental API it can break
many drivers, so was airing on the side of no regression. Open to other
suggestions. Btw, it is not urgent, as we have time before next release.

> But it makes tracking of backports more difficult.

Yes, a little. We can have a separate 18.11 only qede patch and not
claim to backport the commit which updates all drivers.

> Is it a common practice to backport half of fixes?
> 

I don't remember it before where it all can apply.

> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 15:55 [dpdk-stable] Backporting rte_intr_ack David Marchand
2019-11-19 10:40 ` Thomas Monjalon
2019-11-22 15:12   ` Kevin Traynor
2019-11-22 15:24     ` Thomas Monjalon
2019-11-22 16:33       ` Kevin Traynor

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox