patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, stable@dpdk.org,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-stable] [PATCH 7/8] net/ring: do not count unsent packets as errors
Date: Thu, 25 Jul 2019 11:14:27 +0200	[thread overview]
Message-ID: <1564046068-21905-8-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1564046068-21905-1-git-send-email-david.marchand@redhat.com>

err_pkts reflects the number of packets that the driver did not manage
to send.
This is a temporary situation, those packets are not freed and the
application can still retry to send them later.
Hence, we can't count them as transmit failed.

Fixes: e1e4017751f1 ("ring: add new driver")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/ring/rte_eth_ring.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index eb347bc..eef7606 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -172,7 +172,7 @@ static int
 eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
 	unsigned int i;
-	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
+	unsigned long rx_total = 0, tx_total = 0;
 	const struct pmd_internals *internal = dev->data->dev_private;
 
 	for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
@@ -185,12 +185,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 			i < dev->data->nb_tx_queues; i++) {
 		stats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;
 		tx_total += stats->q_opackets[i];
-		tx_err_total += internal->tx_ring_queues[i].err_pkts.cnt;
 	}
 
 	stats->ipackets = rx_total;
 	stats->opackets = tx_total;
-	stats->oerrors = tx_err_total;
 
 	return 0;
 }
-- 
1.8.3.1


  parent reply	other threads:[~2019-07-25  9:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1564046068-21905-1-git-send-email-david.marchand@redhat.com>
2019-07-25  9:14 ` [dpdk-stable] [PATCH 1/8] net/af_packet: remove unused Rx counter David Marchand
2019-07-25 16:06   ` Ferruh Yigit
2019-07-25  9:14 ` [dpdk-stable] [PATCH 3/8] net/null: remove unused Tx error counter David Marchand
2019-07-25 16:06   ` Ferruh Yigit
2019-07-25  9:14 ` [dpdk-stable] [PATCH 4/8] net/virtio: " David Marchand
2019-07-26  2:39   ` Tiwei Bie
2019-07-25  9:14 ` [dpdk-stable] [PATCH 5/8] net/kni: do not count unsent packets as errors David Marchand
2019-07-25 16:12   ` Ferruh Yigit
2019-07-25 19:07     ` David Marchand
2019-07-26  7:24       ` David Marchand
2019-07-26 10:17         ` Ferruh Yigit
2019-07-25  9:14 ` David Marchand [this message]
2019-07-25 16:19   ` [dpdk-stable] [PATCH 7/8] net/ring: " Ferruh Yigit
2019-07-25  9:14 ` [dpdk-stable] [PATCH 8/8] net/vhost: " David Marchand
2019-07-26  2:44   ` Tiwei Bie
     [not found] ` <1564136488-29065-1-git-send-email-david.marchand@redhat.com>
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 1/9] net/af_packet: remove unused Rx counter David Marchand
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 3/9] net/null: remove unused Tx error counter David Marchand
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 4/9] net/virtio: " David Marchand
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter David Marchand
2019-07-26 13:23     ` Ferruh Yigit
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 6/9] net/kni: do not count unsent packets as errors David Marchand
2019-07-26 13:23     ` Ferruh Yigit
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 8/9] net/ring: " David Marchand
2019-07-26 13:24     ` Ferruh Yigit
2019-07-26 10:21   ` [dpdk-stable] [PATCH v2 9/9] net/vhost: " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564046068-21905-8-git-send-email-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).