Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update

[Yuanhan Liu <yliu@fridaylinux.org>]

On Fri, Jun 08, 2018 at 11:10:04PM +0000, Mody, Rasesh wrote:
> > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> > Sent: Friday, June 08, 2018 7:45 AM
> > 
> > On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote:
> > > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ]
> > 
> > Note that this commit is not from upstream, instead, it's from dpdk-next-net.
> > 
> > Another thing worth noting is the commit hash will likely change after it get
> > applied to upstream, for, AFIAK, they do rebase for merging dpdk-next tress.
> > That's the reason we don't directly pick commits from dpdk-next trees.
> > 
> > For this one, I will apply it without above commit info. I have also applied the
> > others.
> 
> Thanks, we have additional fixes that are part of dpdk-next-net, but they are not part of upstream yet.
> Can you pull in these to dpdk-17.11 stable?

I suggest to not cross the line. We normally don't do that.

> https://dpdk.org/dev/patchwork/patch/40779/
> https://dpdk.org/dev/patchwork/patch/40778/

Thus, above 2 will not be applied.

> https://dpdk.org/dev/patchwork/patch/40777/

And since you have mentioned (privately to me), that this one is
critical, I have applied it to dpdk-stable/17.11.

	--yliu

> > > Fix fast path array index which is used for passing L2 handles to RSS
> > > indirection table, properly distribute rxq handles for indirection table.
> > > Currently, it is using the local copy of indirection table. When the
> > > RX queue configuration changes the local copy becomes invalid.
> > >
> > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS
> > > configuration")
> > >
> > > Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> > > Reviewed-by: Kevin Traynor <ktraynor@redhat.com>
> > > ---
> > >  drivers/net/qede/qede_ethdev.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/qede/qede_ethdev.c
> > > b/drivers/net/qede/qede_ethdev.c index d266fff..7462f1a 100644
> > > --- a/drivers/net/qede/qede_ethdev.c
> > > +++ b/drivers/net/qede/qede_ethdev.c
> > > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct rte_eth_dev
> > *eth_dev,
> > >  	vport_update_params.vport_id = 0;
> > >  	/* pass the L2 handles instead of qids */
> > >  	for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) {
> > > -		idx = qdev->rss_ind_table[i];
> > > +		idx = i % QEDE_RSS_COUNT(qdev);
> > >  		rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq-
> > >handle;
> > >  	}
> > >  	vport_update_params.rss_params = &rss_params;
> > > --
> > > 1.7.10.3