From: Ferruh Yigit <ferruh.yigit@intel.com> To: dev@dpdk.org, Maryam Tahhan <maryam.tahhan@intel.com>, Reshma Pattan <reshma.pattan@intel.com>, Harry van Haaren <harry.van.haaren@intel.com>, Roman Korynkevych <romanx.korynkevych@intel.com> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org Subject: [dpdk-stable] [v21.02 v3 01/10] app/procinfo: fix redundant condition Date: Thu, 19 Nov 2020 11:58:51 +0000 Message-ID: <20201119115900.4095566-2-ferruh.yigit@intel.com> (raw) In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com> '_filters' is compared twice, second one will be always false, removing it using the message more relevant to the '_filters'. Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- app/proc-info/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index d743209f0d..35e5b596eb 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, } else if ((type_end != NULL) && (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) { if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "operations", cnt_type_len); + strlcpy(cnt_type, "filter_result", cnt_type_len); else if (strncmp(type_end, "_errors", strlen("_errors")) == 0) strlcpy(cnt_type, "errors", cnt_type_len); - else if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "filter_result", cnt_type_len); } else if ((type_end != NULL) && (strncmp(cnt_name, "mac_", strlen("mac_"))) == 0) { if (strncmp(type_end, "_errors", strlen("_errors")) == 0) -- 2.26.2
next prev parent reply other threads:[~2020-11-19 11:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20200824094021.2323605-1-ferruh.yigit@intel.com> 2020-08-24 9:40 ` [dpdk-stable] [PATCH 6/7] ethdev: remove invalid symbols from map file Ferruh Yigit 2020-08-29 12:14 ` Andrew Rybchenko [not found] ` <20200903211000.244931-1-ferruh.yigit@intel.com> 2020-09-03 21:09 ` [dpdk-stable] [PATCH v2 " Ferruh Yigit [not found] ` <20200909111220.1195759-1-ferruh.yigit@intel.com> 2020-09-09 11:12 ` [dpdk-stable] [PATCH v3 " Ferruh Yigit [not found] ` <20200909130148.1756518-1-ferruh.yigit@intel.com> 2020-09-09 13:01 ` [dpdk-stable] [PATCH v4 " Ferruh Yigit [not found] ` <20201119115900.4095566-1-ferruh.yigit@intel.com> 2020-11-19 11:58 ` Ferruh Yigit [this message] 2021-01-08 10:36 ` [dpdk-stable] [dpdk-dev] [v21.02 v3 01/10] app/procinfo: fix redundant condition David Marchand 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 02/10] app/procinfo: fix negative check on unsigned variable Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 04/10] app/procinfo: remove useless assignment Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one Ferruh Yigit 2021-01-08 10:31 ` David Marchand 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 06/10] net/bonding: " Ferruh Yigit 2021-01-08 10:34 ` [dpdk-stable] [dpdk-dev] " David Marchand 2021-01-11 1:03 ` [dpdk-stable] " Min Hu (Connor) 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 07/10] net/af_xdp: remove useless assignment Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 08/10] net/bnxt: fix redundant return Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 09/10] app/crypto-perf: remove always true condition Ferruh Yigit 2020-11-23 15:25 ` [dpdk-stable] [dpdk-dev] " Zhang, Roy Fan 2020-11-19 11:59 ` [dpdk-stable] [v21.02 v3 10/10] net/avp: " Ferruh Yigit 2020-11-20 17:40 ` Steven Webster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201119115900.4095566-2-ferruh.yigit@intel.com \ --to=ferruh.yigit@intel.com \ --cc=dev@dpdk.org \ --cc=harry.van.haaren@intel.com \ --cc=maryam.tahhan@intel.com \ --cc=reshma.pattan@intel.com \ --cc=romanx.korynkevych@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git