From: Ferruh Yigit <ferruh.yigit@intel.com> To: dev@dpdk.org, Chas Williams <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>, Tomasz Kulasek <tomaszx.kulasek@intel.com>, Declan Doherty <declan.doherty@intel.com> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org Subject: [dpdk-stable] [v21.02 v3 06/10] net/bonding: remove local variable shadowing outer one Date: Thu, 19 Nov 2020 11:58:56 +0000 Message-ID: <20201119115900.4095566-7-ferruh.yigit@intel.com> (raw) In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com> 'retval' is already defined in the function scope, removing the 'retval' in the block scope. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- Cc: tomaszx.kulasek@intel.com --- drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 67ca0730fa..5fe004e551 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1334,8 +1334,7 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals, rte_eth_macaddr_get(slave_id, &m_hdr->eth_hdr.s_addr); if (internals->mode4.dedicated_queues.enabled == 0) { - int retval = rte_ring_enqueue(port->tx_ring, pkt); - if (retval != 0) { + if (rte_ring_enqueue(port->tx_ring, pkt) != 0) { /* reset timer */ port->rx_marker_timer = 0; wrn = WRN_TX_QUEUE_FULL; @@ -1355,8 +1354,7 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals, } } else if (likely(subtype == SLOW_SUBTYPE_LACP)) { if (internals->mode4.dedicated_queues.enabled == 0) { - int retval = rte_ring_enqueue(port->rx_ring, pkt); - if (retval != 0) { + if (rte_ring_enqueue(port->rx_ring, pkt) != 0) { /* If RX fing full free lacpdu message and drop packet */ wrn = WRN_RX_QUEUE_FULL; goto free_out; -- 2.26.2
next prev parent reply other threads:[~2020-11-19 11:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20200824094021.2323605-1-ferruh.yigit@intel.com> 2020-08-24 9:40 ` [dpdk-stable] [PATCH 6/7] ethdev: remove invalid symbols from map file Ferruh Yigit 2020-08-29 12:14 ` Andrew Rybchenko [not found] ` <20200903211000.244931-1-ferruh.yigit@intel.com> 2020-09-03 21:09 ` [dpdk-stable] [PATCH v2 " Ferruh Yigit [not found] ` <20200909111220.1195759-1-ferruh.yigit@intel.com> 2020-09-09 11:12 ` [dpdk-stable] [PATCH v3 " Ferruh Yigit [not found] ` <20200909130148.1756518-1-ferruh.yigit@intel.com> 2020-09-09 13:01 ` [dpdk-stable] [PATCH v4 " Ferruh Yigit [not found] ` <20201119115900.4095566-1-ferruh.yigit@intel.com> 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 01/10] app/procinfo: fix redundant condition Ferruh Yigit 2021-01-08 10:36 ` [dpdk-stable] [dpdk-dev] " David Marchand 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 02/10] app/procinfo: fix negative check on unsigned variable Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 04/10] app/procinfo: remove useless assignment Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one Ferruh Yigit 2021-01-08 10:31 ` David Marchand 2020-11-19 11:58 ` Ferruh Yigit [this message] 2021-01-08 10:34 ` [dpdk-stable] [dpdk-dev] [v21.02 v3 06/10] net/bonding: " David Marchand 2021-01-11 1:03 ` [dpdk-stable] " Min Hu (Connor) 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 07/10] net/af_xdp: remove useless assignment Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 08/10] net/bnxt: fix redundant return Ferruh Yigit 2020-11-19 11:58 ` [dpdk-stable] [v21.02 v3 09/10] app/crypto-perf: remove always true condition Ferruh Yigit 2020-11-23 15:25 ` [dpdk-stable] [dpdk-dev] " Zhang, Roy Fan 2020-11-19 11:59 ` [dpdk-stable] [v21.02 v3 10/10] net/avp: " Ferruh Yigit 2020-11-20 17:40 ` Steven Webster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201119115900.4095566-7-ferruh.yigit@intel.com \ --to=ferruh.yigit@intel.com \ --cc=chas3@att.com \ --cc=declan.doherty@intel.com \ --cc=dev@dpdk.org \ --cc=humin29@huawei.com \ --cc=stable@dpdk.org \ --cc=tomaszx.kulasek@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git