patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Kerlin, Marcin" <marcin.kerlin@intel.com>,
	"Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
	"Kobylinski, Michal" <michal.kobylinski@intel.com>,
	Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true	condition
Date: Mon, 23 Nov 2020 15:25:38 +0000
Message-ID: <BL0PR11MB3043FBF564EF340269A65E78B8FC0@BL0PR11MB3043.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201119115900.4095566-10-ferruh.yigit@intel.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> Sent: Thursday, November 19, 2020 11:59 AM
> To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; Kerlin,
> Marcin <marcin.kerlin@intel.com>; Mrozowicz, SlawomirX
> <slawomirx.mrozowicz@intel.com>; Kobylinski, Michal
> <michal.kobylinski@intel.com>; Piotr Azarewicz
> <piotrx.t.azarewicz@intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true
> condition
> 
> This is already 'else' leg of the opposite comparison, simple 'else'
> will be logically same.
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  app/test-crypto-perf/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
> index 5f035519c3..99f86e9019 100644
> --- a/app/test-crypto-perf/main.c
> +++ b/app/test-crypto-perf/main.c
> @@ -390,7 +390,7 @@ cperf_check_test_vector(struct cperf_options *opts,
>  		if (opts->cipher_algo == RTE_CRYPTO_CIPHER_NULL) {
>  			if (test_vec->plaintext.data == NULL)
>  				return -1;
> -		} else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
> +		} else {
>  			if (test_vec->plaintext.data == NULL)
>  				return -1;
>  			if (test_vec->plaintext.length < opts-
> >max_buffer_size)
> @@ -440,7 +440,7 @@ cperf_check_test_vector(struct cperf_options *opts,
>  				return -1;
>  			if (test_vec->plaintext.length < opts-
> >max_buffer_size)
>  				return -1;
> -		} else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
> +		} else {
>  			if (test_vec->plaintext.data == NULL)
>  				return -1;
>  			if (test_vec->plaintext.length < opts-
> >max_buffer_size)
> --
> 2.26.2

Thanks Ferruh!

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>


  reply	other threads:[~2020-11-23 15:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200824094021.2323605-1-ferruh.yigit@intel.com>
2020-08-24  9:40 ` [dpdk-stable] [PATCH 6/7] ethdev: remove invalid symbols from map file Ferruh Yigit
2020-08-29 12:14   ` Andrew Rybchenko
     [not found] ` <20200903211000.244931-1-ferruh.yigit@intel.com>
2020-09-03 21:09   ` [dpdk-stable] [PATCH v2 " Ferruh Yigit
     [not found] ` <20200909111220.1195759-1-ferruh.yigit@intel.com>
2020-09-09 11:12   ` [dpdk-stable] [PATCH v3 " Ferruh Yigit
     [not found] ` <20200909130148.1756518-1-ferruh.yigit@intel.com>
2020-09-09 13:01   ` [dpdk-stable] [PATCH v4 " Ferruh Yigit
     [not found] ` <20201119115900.4095566-1-ferruh.yigit@intel.com>
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 01/10] app/procinfo: fix redundant condition Ferruh Yigit
2021-01-08 10:36     ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 02/10] app/procinfo: fix negative check on unsigned variable Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 04/10] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one Ferruh Yigit
2021-01-08 10:31     ` David Marchand
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 06/10] net/bonding: " Ferruh Yigit
2021-01-08 10:34     ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-01-11  1:03     ` [dpdk-stable] " Min Hu (Connor)
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 07/10] net/af_xdp: remove useless assignment Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 08/10] net/bnxt: fix redundant return Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 09/10] app/crypto-perf: remove always true condition Ferruh Yigit
2020-11-23 15:25     ` Zhang, Roy Fan [this message]
2020-11-19 11:59   ` [dpdk-stable] [v21.02 v3 10/10] net/avp: " Ferruh Yigit
2020-11-20 17:40     ` Steven Webster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR11MB3043FBF564EF340269A65E78B8FC0@BL0PR11MB3043.namprd11.prod.outlook.com \
    --to=roy.fan.zhang@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=marcin.kerlin@intel.com \
    --cc=michal.kobylinski@intel.com \
    --cc=piotrx.t.azarewicz@intel.com \
    --cc=slawomirx.mrozowicz@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git